From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90ECCCA0FFA for ; Fri, 30 Aug 2024 14:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4lRwp2hvgHPjG02fs19zbaMkHdYCxt+tSEadREfOm7s=; b=SXiQnIxr0MhzbYzP3AQ5ZZC7wE Sj3yOgXpi+qWYRGJUuUxvNkjUBKWIKL6zuE0dobpJ/bp6f2lCX5A4a0F3DAtagh7p8PTZVRHIxLj5 2pJrGB1RlzwaLQAA/AOJICdm74Fw6gjhxNYJA/xqx9G/5q2Ovx+ApHsS5SAqVkQmESvb4g3KSGwPR w59SRDmRbOpR654HhC9adQTU9+KpoPV8PeG5cLPVJnU2c+8NKAipxvra15rb/uPOKfuF4DpsA59wZ kUopmW8YnyoDuwNe391dN7kKmW/WORJm7uoe8oV3wh1F1xoiIj8l1FPuDGiejoHwMnWp2GXWn/c4E feoBcchw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sk2U6-00000006aMT-1Bf9; Fri, 30 Aug 2024 14:20:18 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sk2Oa-00000006ZDC-3Yk8 for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 14:14:38 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id F143FA44A15; Fri, 30 Aug 2024 14:14:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84557C4CEC2; Fri, 30 Aug 2024 14:14:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725027275; bh=5j7HFB56Qes7cUqNRYyxZbdUq7SCpbJ5SR/AqrEbXS0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B98t+uoISTwZgIdwFFb49Q+0WxtjN/hAxtwIAIOVvQ82isK25mwJH+WO9rMO6TYsR /ITgdeMdg9nxXdNuWBbUvcqrZdq3QVp3uBM1BrvMIiu4lXwKFTKkwWKosLI2YRduf8 WAEEEsUGzEBiTRbphnLDwS9+WPaP12bVRDiU0xhaGpPlhum5xgV08KtKKqnDs1xvRf bUNPbaMl99KDwVc4kVnyClI4qEMWd9Ft8bV4lYw85Zq8fjr3sUZsoYYZrlOjakodsb 16MWn4CXLbmAluDqAaaBXeBVN1k3NmUC12AGxHw++d00mpLrWWvxYYtW3kFNfh/4vJ SKwSLZau0m+rw== Date: Fri, 30 Aug 2024 15:14:31 +0100 From: Conor Dooley To: Fabio Estevam Cc: broonie@kernel.org, linux-spi@vger.kernel.org, otavio.salvador@ossystems.com.br, heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] dt-bindings: trivial-devices: Add a reference to spi-peripheral-props.yaml Message-ID: <20240830-anchor-glucose-f8dcc1b0fd16@spud> References: <20240829201315.3412759-1-festevam@gmail.com> <20240829201315.3412759-2-festevam@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="69Vy0EJSs26on1AY" Content-Disposition: inline In-Reply-To: <20240829201315.3412759-2-festevam@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_071436_983029_22C28519 X-CRM114-Status: GOOD ( 19.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --69Vy0EJSs26on1AY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 29, 2024 at 05:13:15PM -0300, Fabio Estevam wrote: > There may be cases where a trivial-device needs to describe > the SPI clock polarity and phase via spi-cpol and spi-cpha > properties. Since those don't come from spi-peripheral-props, not really the correct justification (although why they don't, I'm not sure). If you still saw dtbs_check complaints after the first patch, I maybe the controller schema is missing a reference to spi-controller.yaml? That said, I think the reference is useful for other the properties, like spi-max-frequency, so the diff here is sound. Thanks, Conor. >=20 > Add a reference to spi-peripheral-props.yaml to allow that. >=20 > Suggested-by: Rob Herring > Signed-off-by: Fabio Estevam > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Doc= umentation/devicetree/bindings/trivial-devices.yaml > index 75a5fad08c44..356b89ade6a8 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -424,6 +424,9 @@ required: > - compatible > - reg > =20 > -additionalProperties: false > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +unevaluatedProperties: false > =20 > ... > --=20 > 2.34.1 >=20 --69Vy0EJSs26on1AY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZtHTxwAKCRB4tDGHoIJi 0sOAAP9yK04bIiTPD5Sfk5DzJgGryfVA1de8A9yAys6RNugj/gEAmGmC8Bu5HGX4 LlQSfsQxgaa4DtMSr15pHxP+4HRGUAk= =qdxo -----END PGP SIGNATURE----- --69Vy0EJSs26on1AY--