From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 653FDCA0FFA for ; Fri, 30 Aug 2024 14:21:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8Qpxu1MxW3k5nDhIBCHmdialVMRvmvE2icPsTxcOC/g=; b=o/NNEaZLPi8hXC8ltM41uyYxwS MWUChyFKvas6BUELsKNg3ZWfI89lcQYTJts/xzC/UEz8hRo6/7fb6LvAKd/FBR3p/CNYaoFBhBuyZ wlpwSppFV1wxsUo4ydEc0Ds8OaLw4V9vWTd6HAdbqXLKZO6RtY/zrYw0NvUM2J0gO3rYH6vMdkzQ3 L62zn+iW6BA0RVdj+CleA/z2uFB9k9h0n6ODxDqvwijl+jifJMpZhy7zGJB1ho6ittt6gozXjghzq KyMn8k9HN1hOJs6NgOjVnkK+hlzWuMKN1Pv7JzNqnsHLlvoj0I9IKpbH2RoKbhDvzNEpFBJ8+FB/o F43imMEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sk2Uv-00000006aU9-2eie; Fri, 30 Aug 2024 14:21:09 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sk2QS-00000006ZYS-3Ai0 for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 14:16:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C43F7A449F5; Fri, 30 Aug 2024 14:16:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2C51C4CEC2; Fri, 30 Aug 2024 14:16:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725027391; bh=6k0EBPAToTHacrO5Vk2++06yO8LBCkYLbbqyVIV3Nyc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ugd9ODmX3NVQo5A8dl6N88A1o4+8y5g2DAg1agAi3/pD61gFqNz85A9VVD4zYj548 Y69GIOmUjRuIHTzbp6r+lGhS7tuBMTJ2uVoeSJzdJhS+MrsyLLopTzbpa8eWFL8Mhu ZXz0Jc2XtZLMqfT0r2blTRUGpchkG+U0geSIMWU0XyizzAsSBK+g8lqmAbTpJaTXig CkSNNlO9TUYZWxu5vEL4HlvHLpTZyh2rL6M3gi1IWXkoxF7C6T0lQg+O/x30ovl7i7 VBUJS+VI3zVmMUuJ+ksBqLdTVIegnqBJAHAdXKcu0Atat794rh0dfyfDNyGKpdfW+8 YXExgpd0UttPA== Date: Fri, 30 Aug 2024 15:16:26 +0100 From: Conor Dooley To: Dharma.B@microchip.com Subject: Re: [PATCH v2 1/2] dt-bindings: mmc: sdhci-atmel: Convert to json schema Message-ID: <20240830-retry-ranger-fdd01812a120@spud> References: <20240830-atmel-sdhci-v2-0-b7f58973f3fc@microchip.com> <20240830-atmel-sdhci-v2-1-b7f58973f3fc@microchip.com> <20240830-satisfy-dislike-27ed075138b3@spud> <9e9c8274-6bf2-45f9-8b65-ddc73a0802bc@microchip.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s794SldV2zC1SmKv" Content-Disposition: inline In-Reply-To: <9e9c8274-6bf2-45f9-8b65-ddc73a0802bc@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_071632_956138_766FEBF7 X-CRM114-Status: GOOD ( 23.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robh@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, Aubin.Constans@microchip.com, linux-mmc@vger.kernel.org, ulf.hansson@linaro.org, claudiu.beznea@tuxon.dev, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --s794SldV2zC1SmKv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 30, 2024 at 02:12:48PM +0000, Dharma.B@microchip.com wrote: > Hi Conor, >=20 > On 30/08/24 7:18 pm, Conor Dooley wrote: > > On Fri, Aug 30, 2024 at 01:49:42PM +0530, Dharma Balasubiramani wrote: > >> Convert sdhci-atmel documentation to yaml format. The new file will in= herit > >> from sdhci-common.yaml. > >> > >> Note: Add microchip,sama7g5-sdhci to compatible list as we already use= it > >> in the DT. > >> > >> Signed-off-by: Dharma Balasubiramani > >> --- > >> .../bindings/mmc/atmel,sama5d2-sdhci.yaml | 98 ++++++++++++= ++++++++++ > >> .../devicetree/bindings/mmc/sdhci-atmel.txt | 35 -------- > >> 2 files changed, 98 insertions(+), 35 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci= =2Eyaml b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml > >> new file mode 100644 > >> index 000000000000..91d18b2545e1 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml > >> @@ -0,0 +1,98 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id:http://devicetree.org/schemas/mmc/atmel,sama5d2-sdhci.yaml# > >> +$schema:http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Atmel SDHCI controller > >> + > >> +maintainers: > >> + - Aubin Constans > >> + - Nicolas Ferre > >> + > >> +description: > >> + Bindings for the SDHCI controller found in Atmel/Microchip SoCs. > >> + > >> +properties: > >> + compatible: > >> + oneOf: > >> + - enum: > >> + - atmel,sama5d2-sdhci > >> + - atmel,sama5d3-sdhci > >> + - atmel,sama5d4-sdhci > >> + - microchip,sam9x60-sdhci > >> + - items: > >> + - enum: > >> + - microchip,sama7g5-sdhci > >> + - const: microchip,sam9x60-sdhci > >> + > >> + reg: > >> + maxItems: 1 > >> + > >> + interrupts: > >> + maxItems: 1 > >> + > >> + clocks: > >> + minItems: 2 > >> + maxItems: 3 > >> + description: | > >> + The sama5d2 family includes three clocks: `hclock`, `multclk`, = and `baseclk`. > >> + For other families, including sam9x60 and sam9x7, only `hclock`= and `multclk` are used. > > This should instead be an items list, rather than a text based > > description. > Sure, I will update it like this below >=20 > clocks: > items: > - description: hclock > - description: multclk > - description: baseclk > minItems: 2 > maxItems: 3 This shouldn't pass dt_binding_check, because the max in this snippet is redundant due to it matching the size of the items list. --s794SldV2zC1SmKv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZtHUOgAKCRB4tDGHoIJi 0mRbAQDWBI8NgkX+ksGcgXOabPePzRu6PCDTAOkCM3/F9x0RbQEA26WvR+3rxxKM by1bfuJKmyiFwGLR2bZj041Nr82IjA0= =4oBx -----END PGP SIGNATURE----- --s794SldV2zC1SmKv--