Re: [PATCH 2/2] dt-bindings: trivial-devices: Add a reference to spi-peripheral-props.yaml

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2047 bytes --]

On Fri, Aug 30, 2024 at 12:05:20PM -0300, Fabio Estevam wrote:
> Hi Conor,
> 
> On Fri, Aug 30, 2024 at 11:14 AM Conor Dooley <conor@kernel.org> wrote:
> 
> > Since those don't come from spi-peripheral-props, not really the correct
> > justification (although why they don't, I'm not sure). If you still saw
> > dtbs_check complaints after the first patch, I maybe the controller
> > schema is missing a reference to spi-controller.yaml?
> 
> I changed the first patch as suggested:
> 
> --- a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
> @@ -29,6 +29,10 @@ properties:
>      description:
>        Chip select used by the device.
> 
> +  spi-cpha: true
> +
> +  spi-cpol: true
> +
>    spi-cs-high:
>      $ref: /schemas/types.yaml#/definitions/flag
>      description:
> 
> spi-rockchip.yaml does reference spi-controller.yaml, but I still get
> dtbs_check complaints after the first patch.
> 
> $ make CHECK_DTBS=y rockchip/rv1108-elgin-r1.dtb -j12
>   UPD     include/config/kernel.release
>   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
>   DTC [C] arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb
> /home/fabio/linux-next/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb:
> display@0: 'spi-cpha', 'spi-cpol' do not match any of the regexes:
> 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
> 
> I would appreciate some suggestions on how to fix this warning.

Ah, I think I suggested something garbage, because I misread the diff,
as my quoted mail evidences. I was really trying to suggest putting
spi-cpha: true
spi-cpol: true
in trivial-devices.yaml, but I didn't notice that the patch was to
spi-peripheral-props rather than trivial-devices. These properties are
defined (for reasons I don't quite understand) in spi-controller.yaml
and applied to children of the controller node by that binding and I
wanted to avoid the redefinition.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]