From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11842CA0FF6 for ; Fri, 30 Aug 2024 14:05:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m5/zpJrYsVD/HODcZt4itNwcD8Vn10Bg80heSIvUWuA=; b=qCCLk/ALkSD8IUU4Vh2xFzxwcn yEDVrBp+8tSfCp5BR1B2PZLhq98KbBZoJVkAf1i+Oh/6V89YmDHe8GOV3PKMhvMxKRlwzq7whHMoi WWYZJJ3vXW4ye4Zxaw03IGIKG3Y45F4IUx8BcNngpnEKX0cRTsrAQg/0Toq0QP8JHAUTku0fW3cAs rOAZhzR0wKcQvYet0mFTRP02ZyUoDd/KBAj8G1ClS/Cuy3xtK19/6ghs5ztl6dTIxIFcIUrSBU4jt cAh1EMqBIb5VfCb37CcJ0Foi/twH8/scTv7Gkq+X2jlrkLzeohQEI4Aq59uVq8iTWzBzoBOOiJrxv FSC7FFcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sk2FO-00000006Wsv-1LN8; Fri, 30 Aug 2024 14:05:06 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sk2EV-00000006Weu-22Vq for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 14:04:13 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B5D20CE1E53; Fri, 30 Aug 2024 14:04:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DDD6C4CEC7; Fri, 30 Aug 2024 14:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725026648; bh=cUtegsdQGft/33fvng7kM3QvVXPpZ8tTkRiGBNE+zUg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dwVr6Fhbu0HJyBQUEE/PYUHtHEHAjHlzPqeEJWv3PgtxGBbXmxsEmJ7CtWrUw32af T8X4E9xmQpZKVaPU3/FqHPn8BcXq6DsLqISWOun0l/O6Tn0TQISkWDOsla3pC4MnBj 9nOtPFr3/vCtszYttV5ejjUY7Rni77fXf/3URqlpCcZ+RyLq08NUR+kDipQjpkpHtL 55vHfDNPhOuCrB9aADukxJWh43pLgB0+RsQ3Qz/Gs9Oc79X3NYaYlzbLPYo5Al2Nji D79RoCmeElWQFw9D7KPiVWQOjiRINESDCm0xoX+qpBESDVErOfIwq2jsvuOp1jTSUZ eBX+RRhdMbkJw== Date: Fri, 30 Aug 2024 15:04:04 +0100 From: Conor Dooley To: Billy Tsai Cc: linus.walleij@linaro.org, brgl@bgdev.pl, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, BMC-SW@aspeedtech.com Subject: Re: [PATCH v2 1/4] dt-bindings: gpio: aspeed,ast2400-gpio: Support ast2700 Message-ID: <20240830-untangled-charting-48503e510ea7@spud> References: <20240830034047.2251482-1-billy_tsai@aspeedtech.com> <20240830034047.2251482-2-billy_tsai@aspeedtech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gPClO003GyM59AhI" Content-Disposition: inline In-Reply-To: <20240830034047.2251482-2-billy_tsai@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_070411_720367_B8BF6995 X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --gPClO003GyM59AhI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 30, 2024 at 11:40:44AM +0800, Billy Tsai wrote: > The AST2700 is the 7th generation SoC from Aspeed, featuring two GPIO > controllers: one with 12 GPIO pins and another with 216 GPIO pins. >=20 > Signed-off-by: Billy Tsai > --- > .../bindings/gpio/aspeed,ast2400-gpio.yaml | 46 ++++++++++++++++++- > 1 file changed, 45 insertions(+), 1 deletion(-) >=20 > diff --git a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.y= aml b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > index cf11aa7ec8c7..4d439972c14b 100644 > --- a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > @@ -15,6 +15,7 @@ properties: > - aspeed,ast2400-gpio > - aspeed,ast2500-gpio > - aspeed,ast2600-gpio > + - aspeed,ast2700-gpio > =20 > reg: > maxItems: 1 > @@ -42,7 +43,7 @@ properties: > const: 2 > =20 > ngpios: > - minimum: 36 > + minimum: 12 > maximum: 232 Aren't you missing a corresponding update to gpio-line-names, which has a minimum of 36? --gPClO003GyM59AhI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZtHRUwAKCRB4tDGHoIJi 0qUNAPkB52NMtklicYstcjTeGcpQkkGuzLTEMofpB2ZohjYAaQD/TjytJlaCvEJi pT2l9A8yH2bXdPPSVl+JQxnmZmrnJAc= =Q1AY -----END PGP SIGNATURE----- --gPClO003GyM59AhI--