linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: ti: k3-am642-evm-nand: Rename pinctrl node and gpio-hog names
@ 2024-08-30 10:27 Nishanth Menon
  2024-08-30 11:21 ` Dhruva Gole
  0 siblings, 1 reply; 2+ messages in thread
From: Nishanth Menon @ 2024-08-30 10:27 UTC (permalink / raw)
  To: Conor Dooley, Krzysztof Kozlowski, Rob Herring
  Cc: Tero Kristo, Vignesh Raghavendra, Nishanth Menon, linux-kernel,
	devicetree, linux-arm-kernel, Roger Quadros

Rename the pin mux and gpio-hog node names to match up with binding
rules. This fixes dtbs_check warnings:
'gpmc0-pins-default' does not match any of the regexes: '-pins(-[0-9]+)?$|-pin$', 'pinctrl-[0-9]+'
'gpio0-36' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$'

Signed-off-by: Nishanth Menon <nm@ti.com>
---
Cc: Roger Quadros <rogerq@kernel.org>

This is a trivial fix, so applying Fixes seemed over-board.

 arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso b/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
index f08c0e272b53..f91589818e32 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
+++ b/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
@@ -12,7 +12,7 @@
 #include "k3-pinctrl.h"
 
 &main_pmx0 {
-	gpmc0_pins_default: gpmc0-pins-default {
+	gpmc0_pins_default: gpmc0-default-pins {
 		bootph-all;
 		pinctrl-single,pins = <
 			AM64X_IOPAD(0x0094, PIN_INPUT, 7) /* (T19) GPMC0_BE1n.GPIO0_36 */
@@ -50,7 +50,7 @@ AM64X_IOPAD(0x00a4, PIN_OUTPUT, 0) /* (N17) GPMC0_DIR */
 };
 
 &main_gpio0 {
-	gpio0-36 {
+	gpmc0-hog {
 		bootph-all;
 		gpio-hog;
 		gpios = <36 0>;

base-commit: d2bafcf224f3911b183113b2fcb536c9e90684a3
prerequisite-patch-id: a9c45d98345ca492c945cd5050191ad605de242b
-- 
2.46.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: ti: k3-am642-evm-nand: Rename pinctrl node and gpio-hog names
  2024-08-30 10:27 [PATCH] arm64: dts: ti: k3-am642-evm-nand: Rename pinctrl node and gpio-hog names Nishanth Menon
@ 2024-08-30 11:21 ` Dhruva Gole
  0 siblings, 0 replies; 2+ messages in thread
From: Dhruva Gole @ 2024-08-30 11:21 UTC (permalink / raw)
  To: Nishanth Menon
  Cc: Conor Dooley, Krzysztof Kozlowski, Rob Herring, Tero Kristo,
	Vignesh Raghavendra, linux-kernel, devicetree, linux-arm-kernel,
	Roger Quadros

Hi,

On Aug 30, 2024 at 05:27:09 -0500, Nishanth Menon wrote:
> Rename the pin mux and gpio-hog node names to match up with binding
> rules. This fixes dtbs_check warnings:
> 'gpmc0-pins-default' does not match any of the regexes: '-pins(-[0-9]+)?$|-pin$', 'pinctrl-[0-9]+'
> 'gpio0-36' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$'
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Cc: Roger Quadros <rogerq@kernel.org>
> 
> This is a trivial fix, so applying Fixes seemed over-board.
> 
>  arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso b/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
> index f08c0e272b53..f91589818e32 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
> @@ -12,7 +12,7 @@
>  #include "k3-pinctrl.h"
>  
>  &main_pmx0 {
> -	gpmc0_pins_default: gpmc0-pins-default {
> +	gpmc0_pins_default: gpmc0-default-pins {

I mean, if you are anyway renaming,
s/gpmc0_pins_default/gpmc0_default_pins

>  		bootph-all;
>  		pinctrl-single,pins = <
>  			AM64X_IOPAD(0x0094, PIN_INPUT, 7) /* (T19) GPMC0_BE1n.GPIO0_36 */
> @@ -50,7 +50,7 @@ AM64X_IOPAD(0x00a4, PIN_OUTPUT, 0) /* (N17) GPMC0_DIR */
>  };
>  
>  &main_gpio0 {
> -	gpio0-36 {
> +	gpmc0-hog {
>  		bootph-all;
>  		gpio-hog;
>  		gpios = <36 0>;

With the change,
Reviewed-by: Dhruva Gole <d-gole@ti.com>

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-30 11:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-30 10:27 [PATCH] arm64: dts: ti: k3-am642-evm-nand: Rename pinctrl node and gpio-hog names Nishanth Menon
2024-08-30 11:21 ` Dhruva Gole

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).