From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3DA8CA0EFC for ; Fri, 30 Aug 2024 10:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ICQdyYdF5rb3B1uO2hvjco8kKQoI9LtMf7/n4JMzPNY=; b=Mf6uFc9ii80YOoEwR5IwLsKKd9 gl9W2k5GhTiqTZGtYN9YGDh+bczZ0wwMeTRHWlv/t56FUjTmddSUF74VQKL0XjPRsxFXKOA+0Vfz5 faxAYmtkxLdLwm8VCE/TrKSxgk2TIjCa/u+mAwDd9A5ll7tiMrrVhydiXN7nt33xjwDCB9QC5khrt 1bZ90/wj6E20vKZOqJAry/XIpPCqZ0NPQiEjjVuIZG6ftALDiDiipjIGbVpQ3CAIYSyhfF+7x1G0b vbNPSRk4qflcRWJlCCC8NC0h4Z0AJgXZ39QMwnRmkIs3QS5L1K2Cqd+gS113du4tanl01e6DGHWwS A6VGhdHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjz2r-00000005rda-0Fxl; Fri, 30 Aug 2024 10:39:57 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjz1d-00000005rMl-3Qs3 for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 10:38:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 26317A44663; Fri, 30 Aug 2024 10:38:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6A2AC4CEC6; Fri, 30 Aug 2024 10:38:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725014320; bh=GAeIC74l96iRabcZuiiGMaXKEqc6GeEolRNrnRRbe2k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UqGO9PSqbI4Yflj4w4+Q6amN5f4Ub2zApg3Di9Cxykn83M0UByHYZcV0ivVCqt7um UnX+FkINMp2HbLgP5Qclr0QR5O4ItpPcWCK31Vc1RODJYOnCdFpLy4NIuUK6lUEBbg Ti1azcdENtqg9GWstucjduCkvoAOiN6D1vLpyYNJjCmgXEZ+5ShMiDcHnckIUAnwoL qIvMjqwX6e9SiP7APHzCpMU4DbFKuz0GEuW0MxDD3NYttoxexmELXQlPmO+guWvhyR KfRisrQS8ZVIzV0gcCk0Aw0r3G8cPrmKCSKHSLF0pXPBvhN0mRoyrQd+u7B8MtJxiu xjAeH/QfrGXTA== Date: Fri, 30 Aug 2024 11:38:34 +0100 From: Will Deacon To: Leo Yan Cc: Arnaldo Carvalho de Melo , Mark Rutland , Suzuki K Poulose , Mike Leach , James Clark , John Garry , Namhyung Kim , Ian Rogers , Adrian Hunter , "Liang, Kan" , Jonathan Cameron , Yicong Yang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH v1 1/9] perf: arm_spe: Introduce 'lds' capacity Message-ID: <20240830103834.GA8000@willie-the-truck> References: <20240827164417.3309560-1-leo.yan@arm.com> <20240827164417.3309560-2-leo.yan@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240827164417.3309560-2-leo.yan@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_033841_951143_116D6B48 X-CRM114-Status: GOOD ( 20.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 27, 2024 at 05:44:09PM +0100, Leo Yan wrote: > This commit adds a new entry 'lds' in the capacity folder. 'lds' stands > for "loaded data source". When its value is 1, it indicates the data > source implemented, and data source packets will be recorded in the > trace data. > > Signed-off-by: Leo Yan > --- > drivers/perf/arm_spe_pmu.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c > index 9100d82bfabc..81c1e7627721 100644 > --- a/drivers/perf/arm_spe_pmu.c > +++ b/drivers/perf/arm_spe_pmu.c > @@ -110,6 +110,7 @@ enum arm_spe_pmu_buf_fault_action { > /* This sysfs gunk was really good fun to write. */ > enum arm_spe_pmu_capabilities { > SPE_PMU_CAP_ARCH_INST = 0, > + SPE_PMU_CAP_LDS, > SPE_PMU_CAP_ERND, > SPE_PMU_CAP_FEAT_MAX, > SPE_PMU_CAP_CNT_SZ = SPE_PMU_CAP_FEAT_MAX, > @@ -118,6 +119,7 @@ enum arm_spe_pmu_capabilities { > > static int arm_spe_pmu_feat_caps[SPE_PMU_CAP_FEAT_MAX] = { > [SPE_PMU_CAP_ARCH_INST] = SPE_PMU_FEAT_ARCH_INST, > + [SPE_PMU_CAP_LDS] = SPE_PMU_FEAT_LDS, > [SPE_PMU_CAP_ERND] = SPE_PMU_FEAT_ERND, > }; > > @@ -160,6 +162,7 @@ static ssize_t arm_spe_pmu_cap_show(struct device *dev, > > static struct attribute *arm_spe_pmu_cap_attr[] = { > SPE_CAP_EXT_ATTR_ENTRY(arch_inst, SPE_PMU_CAP_ARCH_INST), > + SPE_CAP_EXT_ATTR_ENTRY(lds, SPE_PMU_CAP_LDS), > SPE_CAP_EXT_ATTR_ENTRY(ernd, SPE_PMU_CAP_ERND), > SPE_CAP_EXT_ATTR_ENTRY(count_size, SPE_PMU_CAP_CNT_SZ), > SPE_CAP_EXT_ATTR_ENTRY(min_interval, SPE_PMU_CAP_MIN_IVAL), What will userspace do with this? I don't think you can turn LDS on/off, so either you'll get the data source packet or you won't. Will