From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F676CA0FE0 for ; Fri, 30 Aug 2024 11:26:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TIEukrcez7k0Vd5WA4TMRIIlNJy5YtgOqtfdkYZcvVk=; b=wXhwgn+qbZtvinZrCcfHfzDw3i NLeZEkSx10PJZQLifN2BY8BLHMSZgDJEHaMEd2mY8hcUq15/8DM0Nyck0deRsW7lZp1+nJsxTEudR RdqYcYm817q5k25/4IcsEaG5/gwLEXbNJJRnzQAi7Z2lVg4Joth9WuQIDc2x+rcNde9o7R8YM1Jyx UaPzPao5jHqCrdu5mnDaaendZaMXxzkGQ52SMEeTSQRrLZlrSdXCWp6Ut8EtYVJpms6qgaKBEHV+I pAR0gpCi8/dEz2oq2TG/nBvvvaFhN3nUkCtC7sLqFx22DvQtI4qA3MBgiW8FACLkt56lGaNvJFCO7 lI6dttMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjzlI-000000062Xe-11eU; Fri, 30 Aug 2024 11:25:52 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjzkO-000000062FD-2YZy for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 11:24:58 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 47UBOq74110121; Fri, 30 Aug 2024 06:24:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1725017092; bh=TIEukrcez7k0Vd5WA4TMRIIlNJy5YtgOqtfdkYZcvVk=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=CWCDqXH1Uat7p+WMEwITec5HUGc7K34gSk6FiYlGDql0sdPnFZgGqowJ/XQZodHGZ PZkeq3EpiGWMFIv2rTOW5Sn18RTOWRKJlQaxPYlaPchrr02jeMV8wCD6kRkcZECZWB PtDMCQakzzCouoN1D3sxTW04LkekU3ZHmSDKmCGI= Received: from DFLE101.ent.ti.com (dfle101.ent.ti.com [10.64.6.22]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 47UBOqFo111288 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 30 Aug 2024 06:24:52 -0500 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 30 Aug 2024 06:24:52 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 30 Aug 2024 06:24:52 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 47UBOqqJ041257; Fri, 30 Aug 2024 06:24:52 -0500 Date: Fri, 30 Aug 2024 06:24:52 -0500 From: Nishanth Menon To: Prasanth Babu Mantena CC: , , , , , , , , , , Subject: Re: [PATCH] arm64: dts: ti: k3-am68-sk-som: Update Partition info for OSPI Flash Message-ID: <20240830112452.geyv7tecpb6ydhmz@quotable> References: <20240828060830.555733-1-p-mantena@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240828060830.555733-1-p-mantena@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_042456_759558_1BFE8D3A X-CRM114-Status: GOOD ( 16.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11:38-20240828, Prasanth Babu Mantena wrote: > Commit 73f1f26e2e4c ("arm64: dts: ti: k3-am68-sk-som: Add support > for OSPI flash") introduced the flash node with discontinuous > partitions. Updating the partition offset to be continuous from > the previous partition to maintain linearity. > > Signed-off-by: Prasanth Babu Mantena > --- Please note my response to a similar patch https://lore.kernel.org/all/20240830092234.veog3e22te7qi3ao@dugout/ I do not want us breaking existing users unless absolutely warranted, even then, I'd like us to be very cognizant of the minimum amount of disruption possible. Normally, I'd say no to this kind of patches. But, since this is in the backup env, I am not *that* worried, but I want to make sure folks understand breaking existing users without a just cause is a NO NO. > arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi > index 5c66e0ec6e82..2e5730216caa 100644 > --- a/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi > @@ -215,9 +215,9 @@ partition@680000 { > reg = <0x680000 0x40000>; > }; > > - partition@740000 { > + partition@6c0000 { > label = "ospi.env.backup"; > - reg = <0x740000 0x40000>; > + reg = <0x6c0000 0x40000>; > }; > > partition@800000 { > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D