From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52531CA1009 for ; Fri, 30 Aug 2024 18:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EL+MI7Mr/CJD3hjBANyNZBwJwaRQWtMAAIu9Dv/uPW4=; b=nbsTtDZRQs8MYz/LI1piFIUZ77 wnhbeZrfNI1PStHASkf7g/ltozoS4IgPwBfhWNHSzBhelOzD5KLXm4u8NNsWuORnsvQti2yfTpfaC nCoU+ah7tewe6FOF1F4jsUwnfLcM8e4aArImfZ3/J0drEbuWkRBrzFnZbNzhLWu0AwOUIPIcfqWzc S0hgSY/++D0f08ENnmNvabADbwkfzoL/bMYrUBE0VIzEcT+X+oAe3VTVCiC8jIcL16hp/gaJi3EjV bGew2MR3vMNSAWRZNqQnTDdTTflv0i0i3/QEP0xFOVuUWuiji7GTwO0cjmpxz1ttvB325MwDrNoOy DBRbfElw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sk60d-00000007I33-0Uso; Fri, 30 Aug 2024 18:06:07 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sk5zk-00000007Hze-2hD2 for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 18:05:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A3B225C1119; Fri, 30 Aug 2024 18:05:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C992AC4CEC2; Fri, 30 Aug 2024 18:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725041111; bh=5zCcseGgAQsWFWzSxH/LG13rTYVwh1PQugqe7G42R3E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qP9Dm6FEQPmlI+S6Tgya29krfv0VrR52xgbMT45ncn5Thq0SuwVLj4uXF5kJCgFrF GLaCj4sLVqQaSLZfS6eSGV5gkDPcZF/0nYVyZiIPYr+Q/D/85kwRMkdjX4DqlJq470 f44DRYzMfT/0OH9SelSdBRj77frx9hLr2VkWDLkX2k0KCDSr6MaRWNWpCCNOeeFPgb dxgXZfIMNNLa1+vP3npUXXtA6Doqe/zwlfTaA3ZnUInfdPV2oOGids46d4TYZrKHKN eP9P8dw1MI7e+1SWVnYj2G+H1vYvTKPma3bfRp6FioGfPZRLPG2M5tBfnUaJ0wMtFH zqwwb7RFNJeGg== Date: Fri, 30 Aug 2024 13:05:09 -0500 From: Rob Herring To: Conor Dooley Cc: Fabio Estevam , broonie@kernel.org, linux-spi@vger.kernel.org, otavio.salvador@ossystems.com.br, heiko@sntech.de, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] dt-bindings: trivial-devices: Add a reference to spi-peripheral-props.yaml Message-ID: <20240830180509.GA565970-robh@kernel.org> References: <20240829201315.3412759-1-festevam@gmail.com> <20240829201315.3412759-2-festevam@gmail.com> <20240830-anchor-glucose-f8dcc1b0fd16@spud> <20240830-rockfish-shun-da3e42b69f1d@spud> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240830-rockfish-shun-da3e42b69f1d@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_110512_787701_2A6D4B28 X-CRM114-Status: GOOD ( 25.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 30, 2024 at 04:17:02PM +0100, Conor Dooley wrote: > On Fri, Aug 30, 2024 at 12:05:20PM -0300, Fabio Estevam wrote: > > Hi Conor, > > > > On Fri, Aug 30, 2024 at 11:14 AM Conor Dooley wrote: > > > > > Since those don't come from spi-peripheral-props, not really the correct > > > justification (although why they don't, I'm not sure). If you still saw > > > dtbs_check complaints after the first patch, I maybe the controller > > > schema is missing a reference to spi-controller.yaml? > > > > I changed the first patch as suggested: > > > > --- a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml > > +++ b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml > > @@ -29,6 +29,10 @@ properties: > > description: > > Chip select used by the device. > > > > + spi-cpha: true > > + > > + spi-cpol: true > > + > > spi-cs-high: > > $ref: /schemas/types.yaml#/definitions/flag > > description: > > > > spi-rockchip.yaml does reference spi-controller.yaml, but I still get > > dtbs_check complaints after the first patch. > > > > $ make CHECK_DTBS=y rockchip/rv1108-elgin-r1.dtb -j12 > > UPD include/config/kernel.release > > SCHEMA Documentation/devicetree/bindings/processed-schema.json > > DTC [C] arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb > > /home/fabio/linux-next/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb: > > display@0: 'spi-cpha', 'spi-cpol' do not match any of the regexes: > > 'pinctrl-[0-9]+' > > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > > > > I would appreciate some suggestions on how to fix this warning. > > Ah, I think I suggested something garbage, because I misread the diff, > as my quoted mail evidences. I was really trying to suggest putting > spi-cpha: true > spi-cpol: true > in trivial-devices.yaml, but I didn't notice that the patch was to > spi-peripheral-props rather than trivial-devices. These properties are > defined (for reasons I don't quite understand) in spi-controller.yaml > and applied to children of the controller node by that binding and I > wanted to avoid the redefinition. I steered Fabio wrong... I think we originally had these in spi-peripheral-props, but then decided they are properties of the device, not the controller. These properties should really only be needed if the device supports different modes. If what a device supports is fixed, then that can be implicit. There's one other case I see with "dh,dhcom-board". So I guess add spi-cpha and spi-cpol directly to trivial-devices.yaml. Rob