* [PATCH 1/3] ARM: dts: stm32: Sort properties in audio endpoints on STM32MP15xx DHCOM PDK2
@ 2024-08-30 21:56 Marek Vasut
2024-08-30 21:56 ` [PATCH 2/3] ARM: dts: stm32: Switch bitclock/frame-master to flag " Marek Vasut
2024-08-30 21:56 ` [PATCH 3/3] ARM: dts: stm32: Use SAI to generate bit and frame clock " Marek Vasut
0 siblings, 2 replies; 4+ messages in thread
From: Marek Vasut @ 2024-08-30 21:56 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Alexandre Torgue, Conor Dooley, Krzysztof Kozlowski,
Maxime Coquelin, Rob Herring, devicetree, kernel, linux-stm32
Sort properties alphabetically in audio endpoints of STM32MP15xx
DHCOM PDK2 DT. No functional change.
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: kernel@dh-electronics.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-stm32@st-md-mailman.stormreply.com
---
arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi
index 466d9701add0f..22a2a204433b5 100644
--- a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi
+++ b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi
@@ -191,16 +191,16 @@ sgtl5000_port: port {
sgtl5000_tx_endpoint: endpoint@0 {
reg = <0>;
- remote-endpoint = <&sai2a_endpoint>;
- frame-master = <&sgtl5000_tx_endpoint>;
bitclock-master = <&sgtl5000_tx_endpoint>;
+ frame-master = <&sgtl5000_tx_endpoint>;
+ remote-endpoint = <&sai2a_endpoint>;
};
sgtl5000_rx_endpoint: endpoint@1 {
reg = <1>;
- remote-endpoint = <&sai2b_endpoint>;
- frame-master = <&sgtl5000_rx_endpoint>;
bitclock-master = <&sgtl5000_rx_endpoint>;
+ frame-master = <&sgtl5000_rx_endpoint>;
+ remote-endpoint = <&sai2b_endpoint>;
};
};
@@ -246,9 +246,9 @@ sai2a_port: port {
sai2a_endpoint: endpoint {
remote-endpoint = <&sgtl5000_tx_endpoint>;
dai-format = "i2s";
- mclk-fs = <512>;
dai-tdm-slot-num = <2>;
dai-tdm-slot-width = <16>;
+ mclk-fs = <512>;
};
};
};
@@ -264,9 +264,9 @@ sai2b_port: port {
sai2b_endpoint: endpoint {
remote-endpoint = <&sgtl5000_rx_endpoint>;
dai-format = "i2s";
- mclk-fs = <512>;
dai-tdm-slot-num = <2>;
dai-tdm-slot-width = <16>;
+ mclk-fs = <512>;
};
};
};
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] ARM: dts: stm32: Switch bitclock/frame-master to flag on STM32MP15xx DHCOM PDK2
2024-08-30 21:56 [PATCH 1/3] ARM: dts: stm32: Sort properties in audio endpoints on STM32MP15xx DHCOM PDK2 Marek Vasut
@ 2024-08-30 21:56 ` Marek Vasut
2024-08-30 21:56 ` [PATCH 3/3] ARM: dts: stm32: Use SAI to generate bit and frame clock " Marek Vasut
1 sibling, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2024-08-30 21:56 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Alexandre Torgue, Conor Dooley, Krzysztof Kozlowski,
Maxime Coquelin, Rob Herring, devicetree, kernel, linux-stm32
Switch the bitclock-master and frame-master properties from phandle to
flag on STM32MP15xx DHCOM PDK2. There is no real reason to use phandle
in this system DT, since the phandle points to the endpoint node which
contains the property itself. Simplify the DT. No functional change.
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: kernel@dh-electronics.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-stm32@st-md-mailman.stormreply.com
---
arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi
index 22a2a204433b5..ea933da64903c 100644
--- a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi
+++ b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi
@@ -191,15 +191,15 @@ sgtl5000_port: port {
sgtl5000_tx_endpoint: endpoint@0 {
reg = <0>;
- bitclock-master = <&sgtl5000_tx_endpoint>;
- frame-master = <&sgtl5000_tx_endpoint>;
+ bitclock-master;
+ frame-master;
remote-endpoint = <&sai2a_endpoint>;
};
sgtl5000_rx_endpoint: endpoint@1 {
reg = <1>;
- bitclock-master = <&sgtl5000_rx_endpoint>;
- frame-master = <&sgtl5000_rx_endpoint>;
+ bitclock-master;
+ frame-master;
remote-endpoint = <&sai2b_endpoint>;
};
};
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] ARM: dts: stm32: Use SAI to generate bit and frame clock on STM32MP15xx DHCOM PDK2
2024-08-30 21:56 [PATCH 1/3] ARM: dts: stm32: Sort properties in audio endpoints on STM32MP15xx DHCOM PDK2 Marek Vasut
2024-08-30 21:56 ` [PATCH 2/3] ARM: dts: stm32: Switch bitclock/frame-master to flag " Marek Vasut
@ 2024-08-30 21:56 ` Marek Vasut
2024-09-05 7:34 ` Alexandre TORGUE
1 sibling, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2024-08-30 21:56 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Alexandre Torgue, Conor Dooley, Krzysztof Kozlowski,
Maxime Coquelin, Rob Herring, devicetree, kernel, linux-stm32
By default the SGTL5000 derives bit and frame clock from MCLK, which
does not produce particularly accurate results. The SGTL5000 PLL does
improve the accuracy, but also increases power consumption. Using the
SoC SAI interface as bit and frame clock source results in the best
accuracy without the power consumption increase downside. Switch the
bit and frame clock direction from SAI to SGTL5000, reduce mclk-fs to
match.
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: kernel@dh-electronics.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-stm32@st-md-mailman.stormreply.com
---
arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi
index ea933da64903c..171d7c7658fa8 100644
--- a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi
+++ b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi
@@ -191,15 +191,11 @@ sgtl5000_port: port {
sgtl5000_tx_endpoint: endpoint@0 {
reg = <0>;
- bitclock-master;
- frame-master;
remote-endpoint = <&sai2a_endpoint>;
};
sgtl5000_rx_endpoint: endpoint@1 {
reg = <1>;
- bitclock-master;
- frame-master;
remote-endpoint = <&sai2b_endpoint>;
};
};
@@ -245,10 +241,12 @@ sai2a: audio-controller@4400b004 {
sai2a_port: port {
sai2a_endpoint: endpoint {
remote-endpoint = <&sgtl5000_tx_endpoint>;
+ bitclock-master;
dai-format = "i2s";
dai-tdm-slot-num = <2>;
dai-tdm-slot-width = <16>;
- mclk-fs = <512>;
+ frame-master;
+ mclk-fs = <256>;
};
};
};
@@ -263,10 +261,12 @@ sai2b: audio-controller@4400b024 {
sai2b_port: port {
sai2b_endpoint: endpoint {
remote-endpoint = <&sgtl5000_rx_endpoint>;
+ bitclock-master;
dai-format = "i2s";
dai-tdm-slot-num = <2>;
dai-tdm-slot-width = <16>;
- mclk-fs = <512>;
+ frame-master;
+ mclk-fs = <256>;
};
};
};
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] ARM: dts: stm32: Use SAI to generate bit and frame clock on STM32MP15xx DHCOM PDK2
2024-08-30 21:56 ` [PATCH 3/3] ARM: dts: stm32: Use SAI to generate bit and frame clock " Marek Vasut
@ 2024-09-05 7:34 ` Alexandre TORGUE
0 siblings, 0 replies; 4+ messages in thread
From: Alexandre TORGUE @ 2024-09-05 7:34 UTC (permalink / raw)
To: Marek Vasut, linux-arm-kernel
Cc: Conor Dooley, Krzysztof Kozlowski, Maxime Coquelin, Rob Herring,
devicetree, kernel, linux-stm32
Hi Marek
On 8/30/24 23:56, Marek Vasut wrote:
> By default the SGTL5000 derives bit and frame clock from MCLK, which
> does not produce particularly accurate results. The SGTL5000 PLL does
> improve the accuracy, but also increases power consumption. Using the
> SoC SAI interface as bit and frame clock source results in the best
> accuracy without the power consumption increase downside. Switch the
> bit and frame clock direction from SAI to SGTL5000, reduce mclk-fs to
> match.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: kernel@dh-electronics.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> ---
> arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
3 PHDK2 patches applied on stm32-next.
Thanks
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-09-05 7:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-30 21:56 [PATCH 1/3] ARM: dts: stm32: Sort properties in audio endpoints on STM32MP15xx DHCOM PDK2 Marek Vasut
2024-08-30 21:56 ` [PATCH 2/3] ARM: dts: stm32: Switch bitclock/frame-master to flag " Marek Vasut
2024-08-30 21:56 ` [PATCH 3/3] ARM: dts: stm32: Use SAI to generate bit and frame clock " Marek Vasut
2024-09-05 7:34 ` Alexandre TORGUE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).