From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2D0ECA101A for ; Fri, 30 Aug 2024 22:24:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1Mr/XM0IOeC9CAiUkzLYAD1zk8kqSoivz83a6WFbbRM=; b=yInf7fPswL2VBfxjigJUScO2h8 ViagfkM6hXxvvTK5qzxsrqgkciUTAE/UCjQpt6EDZ4ohlDmPlip1qGDl4oSV+itj8vELCzmSbEz0Y B1yMQ/Nhd1Vm3JLL+Tca1uUeSQLApFJ/VFA+1hOyI0KS5BWybtpKkJaD5crXScLfBvkbtNhhVWbf/ FMdB70HimZEYdAZLrMzD6A+wa4ZPn9/b2GVZcpfgYcCHa8r8R8sOLpArwyrjTMleqmoFHMGiy8L+s gzWoVoRQHPrS1grhw71tqR+UKEp0DWHcBpQhGYY4uKDrDWePK3X8FfZ9AP5UGH6eWfF2ymNr6URNe xeh8qmRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1skA2h-00000007rHE-3bBn; Fri, 30 Aug 2024 22:24:31 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1skA1o-00000007r7y-10DU for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 22:23:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CE88B5C10E6; Fri, 30 Aug 2024 22:23:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29B00C4CEC2; Fri, 30 Aug 2024 22:23:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725056614; bh=B8VQl5DFu5C3eYK4CExKtHZCyDO+jvgcRht3lHI+Qwk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T4RVNyaYiUfiztps76wYOxGaAqTvFn+2fD8jyGJ++g9hwSXomSRSCAxX6lMqk5WiV WiSN5NDTvtZdzrMlROpKcPYo+KT868J09a3CRHAcZyjStASEKAFtJcx1tMg0/dLkb3 i9bXSK0iwk+HTSTVKuwdk8QUuxddV9g5le8w5GFLR6pJr1dykZYSFSVL2PRXWvqS7R 06dbdfXtsJ0wr9iof+QpVFVbL/2BDJ3gEhTLBsUl9JUw3bgQTXh+HpaFN4bMTeQoTb i1KbBWvhvqDmPwjT/C0ycd317d05VzqFu+dnQdCF3muJoMRScrySTvDOWZc8ttZ1WA R+6jahvx1fUCw== Date: Fri, 30 Aug 2024 15:23:32 -0700 From: Nathan Chancellor To: Mark Brown Cc: Geert Uytterhoeven , Yang Ruibin <11162571@vivo.com>, Daniel Mack , Haojian Zhuang , Robert Jarzmik , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com, Andy Shevchenko Subject: Re: [PATCH v2] drivers: spi: Insert the missing pci_dev_put()before return Message-ID: <20240830222332.GA3862110@thelio-3990X> References: <20240829033511.1917015-1-11162571@vivo.com> <0a906ee9-7b28-45e4-be67-ab3b6c5f89b1@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0a906ee9-7b28-45e4-be67-ab3b6c5f89b1@sirena.org.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_152336_661373_FD350638 X-CRM114-Status: GOOD ( 15.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 30, 2024 at 08:57:47PM +0100, Mark Brown wrote: > On Fri, Aug 30, 2024 at 10:55:06AM +0200, Geert Uytterhoeven wrote: > > On Thu, Aug 29, 2024 at 5:35 AM Yang Ruibin <11162571@vivo.com> wrote: > > > > - if (ret) > > > + if (ret) { > > > + pci_dev_put(dma_dev); > > > dma_dev is still uninitialized at this point. > > I'm a bit concerned that this isn't picked up by an allmodconfig with > the -Werror... I'm currently using GCC 12 for that. It shows up with -Wmaybe-uninitialized for GCC but that's disabled for the normal kernel build with commit 78a5255ffb6a ("Stop the ad-hoc games with -Wno-maybe-initialized"). With GCC 12: drivers/spi/spi-pxa2xx-pci.c: In function ‘mrfld_spi_setup’: drivers/spi/spi-pxa2xx-pci.c:228:17: error: ‘dma_dev’ may be used uninitialized [-Werror=maybe-uninitialized] 228 | pci_dev_put(dma_dev); | ^~~~~~~~~~~~~~~~~~~~ drivers/spi/spi-pxa2xx-pci.c:198:25: note: ‘dma_dev’ was declared here 198 | struct pci_dev *dma_dev; | ^~~~~~~ drivers/spi/spi-pxa2xx-pci.c: In function ‘lpss_spi_setup’: drivers/spi/spi-pxa2xx-pci.c:150:17: error: ‘dma_dev’ may be used uninitialized [-Werror=maybe-uninitialized] 150 | pci_dev_put(dma_dev); | ^~~~~~~~~~~~~~~~~~~~ drivers/spi/spi-pxa2xx-pci.c:100:25: note: ‘dma_dev’ was declared here 100 | struct pci_dev *dma_dev; | ^~~~~~~ Clang has it under -Wuninitialized, where it was caught with a regular allmodconfig build: drivers/spi/spi-pxa2xx-pci.c:150:15: error: variable 'dma_dev' is uninitialized when used here [-Werror,-Wuninitialized] 150 | pci_dev_put(dma_dev); | ^~~~~~~ drivers/spi/spi-pxa2xx-pci.c:100:25: note: initialize the variable 'dma_dev' to silence this warning 100 | struct pci_dev *dma_dev; | ^ | = NULL drivers/spi/spi-pxa2xx-pci.c:228:15: error: variable 'dma_dev' is uninitialized when used here [-Werror,-Wuninitialized] 228 | pci_dev_put(dma_dev); | ^~~~~~~ drivers/spi/spi-pxa2xx-pci.c:198:25: note: initialize the variable 'dma_dev' to silence this warning 198 | struct pci_dev *dma_dev; | ^ | = NULL Perhaps a KCFLAGS=-Wmaybe-uninitialized in your make command or adding subdir-ccflags-$(CONFIG_CC_IS_GCC) := -Wmaybe-uninitialized to the makefiles of the drivers that you maintain might not be a bad idea. Cheers, Nathan