From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C27B8CD342B for ; Mon, 2 Sep 2024 07:34:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K/HbDe/HSz6pkXiW0JkEGHwpwJAfk4nlDzkL2IIO73Y=; b=1grIBSUv9Oh3kGgI+oEPogw3uO sohVWhGn/GB5rCroXeCoT+k5DWn3mIH2mAUtEVknOi8cnvR4WhpA0+VgcJJGsv12NeyyyodHA1S7h nSmiijv81Blhp4/UrboTQb639BOAyQwjkjczfCaOzYo4vbUIqs5fBWzXhQRTnWPzCTr7O+p4okRYe TMOMq93NkxGCLXXoInbvQ19IWF5ADDOKgVa11/r/YYW+L7h0D05YqoZmMKC5FOe+CjX5e2h9oESwF eDWm993nCCe31WroMiSI2aGJd+1aaqNUfg8eq0hoc5YFnIoddubUIj2/zx0g7n5YbLainHX+7P80L H27FuyFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sl1aE-0000000DKGY-1J1r; Mon, 02 Sep 2024 07:34:42 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sl1ZI-0000000DK06-0EJh for linux-arm-kernel@lists.infradead.org; Mon, 02 Sep 2024 07:33:45 +0000 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-7141b04e7a3so3296325b3a.3 for ; Mon, 02 Sep 2024 00:33:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725262422; x=1725867222; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=K/HbDe/HSz6pkXiW0JkEGHwpwJAfk4nlDzkL2IIO73Y=; b=ioJkeeY5+u1KyBB21SK745JB5n066hvT5Gw9UzhWz9w767yj28KWKBtdeHpP/P4DWT uI7aVABQi9NVLduspX8yBVmJ7qMKJ2NpxcxIOM3m56jFQr8H7KJYkYTaxj1vYAsjeRUP 3Nj0QeZqpDl6DEFdTlmh5vfItWHqA/zchvgvoRuT4WdA2UCYsDzJFjhmX8IlkDwRCOBD SdkWyEWXYnllpEXonU+rfVjqph79HwvD9GPfrhrnuC9JZXBNJ+hAl3yXUHETdPN4D18N xlQHLg1ES0rpvdu2ilcY4A8fYxHUQ6fPICj/24rcJzyZb1J0hqZTK9d6zWxc2+0TgTIq 0Zvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725262422; x=1725867222; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K/HbDe/HSz6pkXiW0JkEGHwpwJAfk4nlDzkL2IIO73Y=; b=gLzzw1rk4+qKmFX3AzcyoPU65DOnrb9og0I/JflR+brO9FjjRbw1F3XIabNJrOFAfZ I2qkg3HaManeLiVN8/yHzAEX/PDc3+CXPgRkpF26QYn8fvmhiRJXWRYsp4FGGNFy3V8x 6ozrGmTMhrwL95npYghQYoIfc08G1lDW2JO6BP9oJ6SZHrw2T/RAq+ZleCtmWANwqjRM 0gJuJIKPAUgE8d0eS0hg40pGBSuXLzW8yeeuNy79DuSc0gTv4i3wYqB/4SDOHTre2YOm CtqMARQMMDgsZRGJiO/RXd1dxALcXfzLSVPq8AcGvT/ilIC7yfDMPv78sn+7vhvAwl+Y NIvA== X-Forwarded-Encrypted: i=1; AJvYcCVzs2lsJdlSEd6HqbQrR3H3mk1o9P1PWGDEKo6l1NrU6TG/Line9p2M9zM70m09PFsP91IHlNAjLHgztyaie3Yr@lists.infradead.org X-Gm-Message-State: AOJu0Yx0p+jwYH5oUtNsnyE0KGQ4Knq+500OY5T5ZsKN3fpwxIlaU2vP P8ESSpxlOmx05BFM/COO6aPBtfGow7ij0KpR/mcHC8/1dwstZIdAxKql8YoxzQ== X-Google-Smtp-Source: AGHT+IEQZNvphTM9Na+10ZEQH+EVEVCFHgFa3BpTs1lm8QBLXCV8lFWg/7nLZZbMHQm9nljqgMjFIA== X-Received: by 2002:a05:6a20:ae86:b0:1cc:e41d:58f0 with SMTP id adf61e73a8af0-1cce41d59b5mr10376233637.13.1725262422332; Mon, 02 Sep 2024 00:33:42 -0700 (PDT) Received: from thinkpad ([120.60.58.247]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-205152cd543sm60805665ad.76.2024.09.02.00.33.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Sep 2024 00:33:41 -0700 (PDT) Date: Mon, 2 Sep 2024 13:03:36 +0530 From: Manivannan Sadhasivam To: Siddharth Vadapalli Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, vigneshr@ti.com, kishon@kernel.org, j-keerthy@ti.com, linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, u-kumar1@ti.com, srk@ti.com Subject: Re: [PATCH 1/2] PCI: dra7xx: Fix threaded IRQ request for "dra7xx-pcie-main" IRQ Message-ID: <20240902073336.fwyjm27ruvfb7gva@thinkpad> References: <20240827122422.985547-1-s-vadapalli@ti.com> <20240827122422.985547-2-s-vadapalli@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240827122422.985547-2-s-vadapalli@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240902_003344_119873_B4A7B57D X-CRM114-Status: GOOD ( 19.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 27, 2024 at 05:54:21PM +0530, Siddharth Vadapalli wrote: > Commit da87d35a6e51 ("PCI: dra7xx: Use threaded IRQ handler for > "dra7xx-pcie-main" IRQ") switched from devm_request_irq() to > devm_request_threaded_irq() for the "dra7xx-pcie-main" interrupt. > Since the primary handler was set to NULL, the "IRQF_ONESHOT" flag > should have also been set. Fix this. > > Fixes: da87d35a6e51 ("PCI: dra7xx: Use threaded IRQ handler for "dra7xx-pcie-main" IRQ") > Cc: > Reported-by: Udit Kumar > Suggested-by: Vignesh Raghavendra > Signed-off-by: Siddharth Vadapalli Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/dwc/pci-dra7xx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c > index 4fe3b0cb72ec..20fb50741f3d 100644 > --- a/drivers/pci/controller/dwc/pci-dra7xx.c > +++ b/drivers/pci/controller/dwc/pci-dra7xx.c > @@ -850,7 +850,8 @@ static int dra7xx_pcie_probe(struct platform_device *pdev) > dra7xx->mode = mode; > > ret = devm_request_threaded_irq(dev, irq, NULL, dra7xx_pcie_irq_handler, > - IRQF_SHARED, "dra7xx-pcie-main", dra7xx); > + IRQF_SHARED | IRQF_ONESHOT, > + "dra7xx-pcie-main", dra7xx); > if (ret) { > dev_err(dev, "failed to request irq\n"); > goto err_gpio; > -- > 2.40.1 > -- மணிவண்ணன் சதாசிவம்