From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D676CD342D for ; Tue, 3 Sep 2024 12:58:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pCib/IRg7/CXDznhduqYaavWCjHDSzq5T5maGxoi/1M=; b=OBrzjDVXcKmouT8aK01wQNd1wc pOoGgZB6M5hFo3ZcZjY/9yl3eKbPcn7SAA+WHax4Q5kD3S0gJhQ9VxZjpBzNAS0b7NmUksEepLsKi UHQhU66RX/akF8patSjPvzp4FoRLzFK4w1QyJl4YhjjSuwM8ldzNVgVUj6upTvO8Tc30AvEXlNEYE KA3ebrljmmLMpaQgZsvuIi1iEnQwi+8hXz5OJ78I556hRi7tsNrS9P5lnl7+vmfcQ2EV40p+J0D2P XbLVcil8BDqnPCta4NHABCFWb/5XFTUNDfpy/zImbH0Y1oJQi9+qFI5TI+FRMHWbSFqFvt+IV/Siw yrB5ZUww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slT7P-00000000Gtj-3Kz6; Tue, 03 Sep 2024 12:58:47 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slSum-00000000E0X-0jsc for linux-arm-kernel@lists.infradead.org; Tue, 03 Sep 2024 12:45:45 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 483CjeuT050627; Tue, 3 Sep 2024 07:45:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1725367540; bh=pCib/IRg7/CXDznhduqYaavWCjHDSzq5T5maGxoi/1M=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=nh9hCt5jvnQUgVwZr49rNRiL6TyH9i+wNkjLNhpMIYzkojXpTfuJaeiqpcKZf5AIH q6LC4YTMKT2UGoZtDAIaiO/Rk2QiomJrMiJ/pvP2kdd/LqiOuET6+nJ7htFU1KTUe9 ALh9+wAqGGPNEE00fkPEkjKQ7cgEMZnAF6TU9dvU= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTP id 483CjeLY049539; Tue, 3 Sep 2024 07:45:40 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 3 Sep 2024 07:45:40 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 3 Sep 2024 07:45:39 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 483CjelL013961; Tue, 3 Sep 2024 07:45:40 -0500 Date: Tue, 3 Sep 2024 07:45:40 -0500 From: Nishanth Menon To: Nathan Chancellor CC: Markus Schneider-Pargmann , Tero Kristo , Santosh Shilimkar , Vibhore Vardhan , Kevin Hilman , Dhruva Gole , , Subject: Re: [PATCH v11 4/4] firmware: ti_sci: add CPU latency constraint management Message-ID: <20240903124540.73cdhsf755lyfisa@tartness> References: <20240829201606.1407773-1-msp@baylibre.com> <20240829201606.1407773-5-msp@baylibre.com> <20240903005422.GA4638@thelio-3990X> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240903005422.GA4638@thelio-3990X> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240903_054544_383896_36444B58 X-CRM114-Status: GOOD ( 14.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17:54-20240902, Nathan Chancellor wrote: [...] > > @@ -3669,7 +3671,27 @@ static int ti_sci_prepare_system_suspend(struct ti_sci_info *info) > > static int __maybe_unused ti_sci_suspend(struct device *dev) > > { > > struct ti_sci_info *info = dev_get_drvdata(dev); > > - int ret; > > + struct device *cpu_dev, *cpu_dev_max = NULL; > > + s32 val, cpu_lat = 0; > > + int i, ret; > > + > > + if (info->fw_caps & MSG_FLAG_CAPS_LPM_DM_MANAGED) { > > + for_each_possible_cpu(i) { > > + cpu_dev = get_cpu_device(i); > > + val = dev_pm_qos_read_value(cpu_dev, DEV_PM_QOS_RESUME_LATENCY); > > This change is now in -next as commit 458d22d2e064 ("firmware: ti_sci: > add CPU latency constraint management"), where it breaks the build > when this driver is built as a module because dev_pm_qos_read_value() is > not exported to modules: > > ERROR: modpost: "dev_pm_qos_read_value" [drivers/firmware/ti_sci.ko] undefined! > > Obviously exporting it would fix the build but sometimes that is > controversial, hence just the report. Thank you for the report. I will drop the series from my queue for now. That should give us some time to sort things out properly for the next window. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D