From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9B15CD379F for ; Tue, 3 Sep 2024 17:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=7i8RVId+gxBNNgOSOqL9u8QAKXOBB3hGM6lpV0N0f58=; b=a1pYWFwKy0lkeIJGkqgUdEWOVX GXYurzjPIaZ47mPKr3UY7qNhn0TlI45J4g7nPzbRZnb/j3RzZbmDWvYDpb5SU6R67BbAjcG3Stjir 7yVSS8zasNXuA04V4di2iB8w8e3jBLcmfmln3JDKxMg8gOsBY66auildSrIzM4T7gSx/8Y7OzBkln 0cDWMBNvvFfrPd2h+JCRmiJ70trubQlQvL5jmjEw9JaPLn//ptEPW7ZVLwr4HtB4qCtswe2zC/sAa jcubrD+Lu9w6POGUYbbh5xzm0AdnYyPI5K7Kz2aUR/S0OaQLyp9KGDXAaOW3PLUB/QeW4JldpdyHX 3nEtL6KA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slXAz-00000001H4o-2SQX; Tue, 03 Sep 2024 17:18:45 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slXA3-00000001GpV-3lXL; Tue, 03 Sep 2024 17:17:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7FDBFA43D19; Tue, 3 Sep 2024 17:17:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A29DEC4CEC4; Tue, 3 Sep 2024 17:17:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725383866; bh=MNR8RLx4Vsu7p3+DVMYZuUkv4rATd9Di0StxoIN+wDw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=MzyyugKcCRC/cUB3wB5lEFnNbZIBGyUAFdoCmpVJ/rklZK0FWwDpEmKPWEMmH/34B ni/Jfuiq/+Nue1I9H7VKo1JxLz0MEUGsucqAd1WRyx07oGsOJYAWpR9T5ee7+W8Ml6 o1M2jtooI+P1a1iTsl+wHpdCeUdp59RuRiO6CPvL7ndAGRei0lNjIZirlJgEI11u0w VE0JuQmftsvUn6ETFKCr9XjVqJN4CgtJxm6WVcSvg6fEDvaXCq2hX1mo28Ylv6NogB rjmmKpFZf+pGkajon5ERiE3D6AfyNBWOV4xZ7o0rz5Q5Lq6fnxl452MQiircuPvcQ7 LE3qih4U1Zu/A== Date: Tue, 3 Sep 2024 12:17:43 -0500 From: Bjorn Helgaas To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Cc: Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Manivannan Sadhasivam , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, Florian Fainelli , Lorenzo Pieralisi , Rob Herring , Philipp Zabel , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v6 05/13] PCI: brcmstb: Use bridge reset if available Message-ID: <20240903171743.GA255170@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240903144613.GC1403301@rocinante> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240903_101748_089650_1575F359 X-CRM114-Status: GOOD ( 16.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 03, 2024 at 11:46:13PM +0900, Krzysztof Wilczyński wrote: > Hello, > > [...] > > > > static void brcm_pcie_bridge_sw_init_set_generic(struct brcm_pcie *pcie, u32 val) > > > > { > > > > - u32 tmp, mask = RGR1_SW_INIT_1_INIT_GENERIC_MASK; > > > > - u32 shift = RGR1_SW_INIT_1_INIT_GENERIC_SHIFT; > > > > + if (val) > > > > + reset_control_assert(pcie->bridge_reset); > > > > + else > > > > + reset_control_deassert(pcie->bridge_reset); > > > > > > > > - tmp = readl(pcie->base + PCIE_RGR1_SW_INIT_1(pcie)); > > > > - tmp = (tmp & ~mask) | ((val << shift) & mask); > > > > - writel(tmp, pcie->base + PCIE_RGR1_SW_INIT_1(pcie)); > > > > + if (!pcie->bridge_reset) { > > > > + u32 tmp, mask = RGR1_SW_INIT_1_INIT_GENERIC_MASK; > > > > + u32 shift = RGR1_SW_INIT_1_INIT_GENERIC_SHIFT; > > > > + > > > > + tmp = readl(pcie->base + PCIE_RGR1_SW_INIT_1(pcie)); > > > > + tmp = (tmp & ~mask) | ((val << shift) & mask); > > > > + writel(tmp, pcie->base + PCIE_RGR1_SW_INIT_1(pcie)); > > > > + } > > > > > > This pattern looks goofy: > > > > > > reset_control_assert(pcie->bridge_reset); > > > if (!pcie->bridge_reset) { > > > ... > > > > > > If we're going to test pcie->bridge_reset at all, it should be first > > > so it's obvious what's going on and the reader doesn't have to go > > > verify that reset_control_assert() ignores and returns success for a > > > NULL pointer: > > > > > > if (pcie->bridge_reset) { > > > if (val) > > > reset_control_assert(pcie->bridge_reset); > > > else > > > reset_control_deassert(pcie->bridge_reset); > > > > > > return; > > > } > > > > > > u32 tmp, mask = RGR1_SW_INIT_1_INIT_GENERIC_MASK; > > > ... > > > > > Will do. > [...] > > You will do what? If you don't mind me asking. Can you just do the rework on the branch, Krzysztof? I think that will be easier/quicker than having Jim repost the entire series. Bjorn