From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8036CD37AC for ; Tue, 3 Sep 2024 19:38:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=wi7q0CEOORqDXrXQHDpAOraFfAIetsiZdaNJUx7kbXI=; b=UFFiT541ELTZQ6 2NQKZV2BAHUyKUYmnZDW4hEbuOa187UTHp8EYlscHGlb/Wn1s8AcXUBCsOL3rTNi6q0tZD0oCtXoq h+q+qgCoZ0emQiIoOiFEwhgnfrEErPk2ydo36gcpCSHr2k89tNHuwRiQM3smhDzZIWSVOLGgoYHHA tCPCF1jK4Uk7WWRYg0qnlWqRQoqU79RFZ1xH6jEIx+C0IDz5OgJC8mT+jFRSKA2mIfjDvdEpJrOUF 4KU6YcXsE4DL/vJBa8e4XgqbPSTDlIuWLLuNPcuMv0UDO1wlZxI+uCwBlYT787CO257iC3XtwgSiI OwATx93YJeCnBuYpobjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slZMP-00000001d1d-1k02; Tue, 03 Sep 2024 19:38:41 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slZLU-00000001ctV-0eOU for linux-arm-kernel@lists.infradead.org; Tue, 03 Sep 2024 19:37:45 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 586C3A43DFA; Tue, 3 Sep 2024 19:37:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB56BC4CEC4; Tue, 3 Sep 2024 19:37:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725392262; bh=SIJNjyq5dxaon4/zdpaiOfQn11sjOiaAf/Z1TfCGKVQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=BOlAiJpaGGK7mXIy7BGmiCpR7kTGpTjWCBfEbhPm7x5fiFWyCEE3W6/99cBdQ3Ndy r/bBfZ0U+zak0u1tlasJqbve5qyYsUSDPuk2MLDoMGY0Jb5xIgftAH3Yl3nrD7+sSQ uDYm92IUQBMeVd4jtzNM4Gr5Ezx6lpE07ed2BYkCer8eVXminTil3eB6AFb4prspmg SLY0QJNaLtGFZU7zxEx9jaxmlB1ymTPQJAE0hwB0ETjZqkIX+5ocSIaAleYwgKghIG pyN/MMaobCtErRaJJNjSjqFkYasFZU2Izr1o9KFRd6bA5SZ/eS6tO0uTJUVa0aLu6R 74ymjaDa9J5BQ== Date: Tue, 3 Sep 2024 14:37:39 -0500 From: Bjorn Helgaas To: Frank Li Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Manivannan Sadhasivam , Krzysztof Kozlowski , Conor Dooley , linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v8 04/11] PCI: imx6: Rename imx6_* with imx_* Message-ID: <20240903193739.GA230579@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240729-pci2_upstream-v8-4-b68ee5ef2b4d@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240903_123744_281039_6BBFDF71 X-CRM114-Status: GOOD ( 11.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 29, 2024 at 04:18:11PM -0400, Frank Li wrote: > Since this driver has evolved to support other i.MX SoCs such as i.MX7/8/9, > let's rename the 'imx6' prefix to 'imx' to avoid confusion. But the driver > name is left unchanged to avoid breaking userspace scripts s/let's// It's not a proposal, it's what the patch *does*. s/But the driver name is left unchanged/Leave the driver name unchanged/ s/scripts/scripts./ (add period) > -#define IMX6_PCIE_FLAG_IMX6_PHY BIT(0) > -#define IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE BIT(1) > -#define IMX6_PCIE_FLAG_SUPPORTS_SUSPEND BIT(2) > -#define IMX6_PCIE_FLAG_HAS_PHYDRV BIT(3) > -#define IMX6_PCIE_FLAG_HAS_APP_RESET BIT(4) > -#define IMX6_PCIE_FLAG_HAS_PHY_RESET BIT(5) > -#define IMX6_PCIE_FLAG_HAS_SERDES BIT(6) > -#define IMX6_PCIE_FLAG_SUPPORT_64BIT BIT(7) > +#define IMX_PCIE_FLAG_IMX_PHY BIT(0) > +#define IMX_PCIE_FLAG_IMX_SPEED_CHANGE BIT(1) > +#define IMX_PCIE_FLAG_SUPPORTS_SUSPEND BIT(2) > +#define IMX_PCIE_FLAG_HAS_PHYDRV BIT(3) Good opportunity to fix the whitespace errors while renaming these. IMX_PCIE_FLAG_IMX_SPEED_CHANGE and IMX_PCIE_FLAG_HAS_PHYDRV end up with the wrong indentation. > -#define imx6_check_flag(pci, val) (pci->drvdata->flags & val) > +#define imx_check_flag(pci, val) (pci->drvdata->flags & val) > > -#define IMX6_PCIE_MAX_CLKS 6 > +#define IMX_PCIE_MAX_CLKS 6 Could also make these look nicer. We can touch these up, no need to repost.