From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3048CA0ED3 for ; Wed, 4 Sep 2024 08:44:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TUGv9wHevgRZb5cc15QcdSSIcNgojKzy+jo82zKMyNc=; b=kWjTh13QpdLrr33LzY9G6uIIkb 7htbjBRJFxeBIQA5m7CrDwSxB/4ImhUfDKgVKRwiSHesC3pTmOFN04XDrRnZ66gQwA6xHBHqhtWRu qKq/dFSa7adDLIwiMdMFm4bVq7jcr3kgQw857m/kzP2kaBJLK/TVI4V4d00ePr0avOsjIucf3iwbN gsvcgMnaYivSLsaf44zstMyyCoOgF1m3fzNzgDHNDnBclDlIr3SIrbkOW0ekU8Dy6M/ZPu/ytGGV/ tL6adGJhQePh1U9lyXTgbOyXG05X+kFShr6xBiOAQyQjmVS05ppINa87LgKpZ1SxWkc6v0rTUIWMA jPNb3XAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sllcQ-00000003UHL-2WqN; Wed, 04 Sep 2024 08:44:02 +0000 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sllS5-00000003QJd-26K7 for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2024 08:33:23 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 6A26AE0002; Wed, 4 Sep 2024 08:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1725438797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TUGv9wHevgRZb5cc15QcdSSIcNgojKzy+jo82zKMyNc=; b=eGVbKqY1J+/gbeDzfyyEbvjwQtZ/8Gz6/IvBdLy9Z7ZMyo/3mmyPyiQYv+f7P0fCtK50AL ji6uVTvvZ8lZPOjkb8l9US43KD7pugQf+XszbkD2i73SKjZsy3DIuETg2t0ry/4CmFyQRq aOFJl1rYEQ3v4xXsLClVU/Qvev41Dklh/Zi7lJl31HcrTz9tytd8d6xGS2rUP1ZqajP2bP czUUX6rmfRRlnk7QK5ndVnndzHCG2v0w4xvzSNJzEKvAxI3EfD6Wd45jS1B6dIAXe0o+Aj g7IO5Tmm9H9cc91OU5zUkSkwPBLhf97o6taIa+QkbuBk5rx5j7h86NNoZgq6AQ== Date: Wed, 4 Sep 2024 10:33:13 +0200 From: Herve Codina To: Christophe Leroy Cc: Stephen Rothwell , Arnd Bergmann , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Qiang Zhao Subject: Re: [PATCH] soc: fsl: cpm1: qmc: Fix dependency on fsl_soc.h Message-ID: <20240904103313.21aed2de@bootlin.com> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_013321_860334_468EB050 X-CRM114-Status: GOOD ( 16.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Christophe, On Wed, 4 Sep 2024 09:51:09 +0200 Christophe Leroy wrote: > QMC driver requires fsl_soc.h to use function get_immrbase(). > This header is provided by powerpc architecture and the functions > it declares are defined only when FSL_SOC is selected. > > Today the dependency is the following: > > depends on CPM1 || QUICC_ENGINE || \ > (FSL_SOC && (CPM || QUICC_ENGINE) && COMPILE_TEST) > > This dependency tentatively ensure that FSL_SOC is there when doing a > COMPILE_TEST. > > CPM1 is only selected by PPC_8xx and cannot be selected manually. > CPM1 selects FSL_SOC > > QUICC_ENGINE on the other hand can be selected by ARM or ARM64 which > doesn't select FSL_SOC. QUICC_ENGINE can also be selected with just > COMPILE_TEST. > > It is therefore possible to end up with CPM_QMC selected > without FSL_SOC. > > So fix it by making it depend on FSL_SOC at all time. > > The rest of the above dependency is the same as the one for CPM_TSA on > which CPM_QMC also depends, so it can go away, leaving only a simple > dependency on FSL_SOC. > > Reported-by: Stephen Rothwell > Closes: https://lore.kernel.org/lkml/20240904104859.020fe3a9@canb.auug.org.au/ > Fixes: 8655b76b7004 ("soc: fsl: cpm1: qmc: Handle QUICC Engine (QE) soft-qmc firmware") > Signed-off-by: Christophe Leroy Thanks for this patch! Acked-by: Herve Codina Best regards, Hervé