From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91782CD4853 for ; Wed, 4 Sep 2024 15:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nyHRUbS96LQJMnxC77/pMoO0AXemk+GGLf2OYY2VbUE=; b=xQq3HORpg2jDXVVn0HCiJDHOw3 4g2+qoWsXsnm41mQq+O+H9f8ibKIGPs19INVp79+mzIMOc44oOwVTyE7Il24vkoGu7Ijd0Sx1FaO8 f1oRB91c5VuEKgLjkcXI1bU3y27dZ2mKGwI6pOs4dw8F+2OsdUx0lPyEPagp7Yb+wUTNVDrvc0FZV j7b+fSgTdBno+1Dpe+7AWyrIyQK4mVbEDsHYUXHnPbWwi/HlZo6nMXNVgY+jFeMWL9H6wwmzJkGN6 uBwxTDaaLVen9TBo4p3Fmm1Nr+tHaCLYnCqf9bCcHMb8w5+OjFH/xziwU1I60Xr8ygwlp2YNryeNR ON9Rwo3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slrVK-00000004udp-28wx; Wed, 04 Sep 2024 15:01:06 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slrT1-00000004tpP-0gW7 for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2024 14:58:44 +0000 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-a868b4d67c6so27566366b.1 for ; Wed, 04 Sep 2024 07:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725461921; x=1726066721; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nyHRUbS96LQJMnxC77/pMoO0AXemk+GGLf2OYY2VbUE=; b=PlgwrHDuIeapm1Hec7M/JcRoaVtdKoE+aoETtMsp4Mr0Gq3Rm8TAIFA3xWbIiO4duM vQlXNx5u42cyHZvqUM+viPW50BrAJJ4MsQAsL3Yh8D4xuD40Zt+EgGxWfwZIVRa422Vp ktMGn93BwU3TIDLaeZNN/QYeqE78y981Ioau2GBDn8ArQKhaYUd4X2wQu3+RdM9pyYag rBZRppUZPkD/TEdSToK7HMYOrMWZIISeAmrRl52+NbLZdWTTp5zPrM4OvdPAtLQZcBzx d+VNpGHi557mj5Mi3a3sAOYCZCleVVrnTITVNxJdKpKwEbXIc0kZC9SUzjo6qTBAkgov SjTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725461921; x=1726066721; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nyHRUbS96LQJMnxC77/pMoO0AXemk+GGLf2OYY2VbUE=; b=pVr+nhsKfipFxu4UUVt9lYXyn6J79tR+QAcTtFTlkJE6dOBv38VjLZgRj/UGVlw9pb TViPrFrsgn4mMe+Xy08yiYvj+pJ6jOYEAmm9Zf6s5L9mssCm52yI2mZBFjgcOtxvyd3E 50XJsKpCscB4UjSxYC7WNMD09WZULPl7nkNUw0MdXuzVJAvnVLtO4A1h410j3pte0edX wWTfIyKZqNAAScc5kRs4uLTz9NsU/D4z6XG75VRIdmskORSC3Oa7JejfLqlcGpnUbsCP 3CycDStpJYfAlTmKkVMjsg8QxWZxHO81shQ646cCazTbf/3tzkR3qTwtOxoLPPM5aZ2P +7wQ== X-Forwarded-Encrypted: i=1; AJvYcCXIwu2X4kPoToskWRdTyyahhKjlobvY18H0mzM2XiRWoE/QgDk9d0tKq4xaX/SpYnb+dScwG0gwklyPvzdJ5dga@lists.infradead.org X-Gm-Message-State: AOJu0YwEjaUHemA8SLSpfXWG1QJ5kAMIU+UfVUy84cXuEKRMRkS49Gqg bp1HaXjxLgT97S4VtVyaVbPP8QmVsj2SE9ZFOZg8AlVEJJ/VZclQ X-Google-Smtp-Source: AGHT+IF9fNPAMV3rkGRPbruFXWJ88SAxEy28gAk+8MFg+kx8FVMQrf0q3A1TSlP9jRdQelWzVhiB+g== X-Received: by 2002:a17:907:3e92:b0:a80:a37f:c303 with SMTP id a640c23a62f3a-a89a357825bmr653597266b.4.1725461921263; Wed, 04 Sep 2024 07:58:41 -0700 (PDT) Received: from skbuf ([188.25.134.29]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8a6236d041sm1984566b.132.2024.09.04.07.58.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2024 07:58:40 -0700 (PDT) Date: Wed, 4 Sep 2024 17:58:37 +0300 From: Vladimir Oltean To: Furong Xu <0x1207@gmail.com> Cc: Alexander Lobakin , Serge Semin , "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, rmk+kernel@armlinux.org.uk, linux@armlinux.org.uk, xfr@outlook.com, Vladimir Oltean Subject: Re: [PATCH net-next v7 3/7] net: stmmac: refactor FPE verification process Message-ID: <20240904145837.wh7tdrffsiqpot22@skbuf> References: <1e452525e496b28c0b1ea43afbdc3533c92930c6.1725441317.git.0x1207@gmail.com> <1e452525e496b28c0b1ea43afbdc3533c92930c6.1725441317.git.0x1207@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1e452525e496b28c0b1ea43afbdc3533c92930c6.1725441317.git.0x1207@gmail.com> <1e452525e496b28c0b1ea43afbdc3533c92930c6.1725441317.git.0x1207@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_075843_224909_5DA6779C X-CRM114-Status: GOOD ( 14.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 04, 2024 at 05:21:18PM +0800, Furong Xu wrote: > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 3072ad33b105..e2f933353f40 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -969,17 +969,30 @@ static void stmmac_mac_config(struct phylink_config *config, unsigned int mode, > static void stmmac_fpe_link_state_handle(struct stmmac_priv *priv, bool is_up) > { > struct stmmac_fpe_cfg *fpe_cfg = &priv->fpe_cfg; > - enum stmmac_fpe_state *lo_state = &fpe_cfg->lo_fpe_state; > - enum stmmac_fpe_state *lp_state = &fpe_cfg->lp_fpe_state; > - bool *hs_enable = &fpe_cfg->hs_enable; > + unsigned long flags; > > - if (is_up && *hs_enable) { > - stmmac_fpe_send_mpacket(priv, priv->ioaddr, fpe_cfg, > - MPACKET_VERIFY); > + del_timer_sync(&fpe_cfg->verify_timer); Interesting comments in include/linux/timer.h: * Do not use in new code. Use timer_delete_sync() instead. Also, interesting comment in the timer_delete_sync() kernel-doc: Callers must prevent restarting of the timer, otherwise this function is meaningless. I don't think you have any restart prevention mechanism. So between the timer deletion and the spin_lock_irqsave(), another thread has enough time to acquire fpe_cfg->lock first, and run stmmac_fpe_verify_timer_arm().