From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 447E2CD4853 for ; Wed, 4 Sep 2024 16:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u562QhIJrAV/3yEwnR0FdisLkB+lO3ntNL3108Pvrss=; b=go1mykt5l6SX0YNazPkfCfgop0 jEASTC4taCtMNupSrL/MTzc8d+yIIQYnWRlY5AlKAKi5qybOAo2gpy4sT0hjxs8Cxg0UnnlBN2HeP TIZQzGyOWvdOHXlz92yU+tOf1iw4YAGOcoL3PpiZmUiQQN4ifn6erznS+DQDJERBFvkDrTzvUrwX0 7ayeQhS7tXJdDxZ1dyI4BjVf5RBsu2WBSfPdXOaKtSEr4PAMuw9vZ1/VopVFC5go/W3VevQFeqxx8 deot3zQb/cfDsfhvzBQeDhVY4u2bGYL2B/LoaGzoTzoTbWVeM55C5l6JLy8uuK4UR4LvDF+7w1hh+ XAYwGNsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slsYF-00000005B7j-1hDb; Wed, 04 Sep 2024 16:08:11 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slsQs-000000058pb-20tR for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2024 16:00:35 +0000 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5c24b1ed83eso622945a12.2 for ; Wed, 04 Sep 2024 09:00:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725465632; x=1726070432; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=u562QhIJrAV/3yEwnR0FdisLkB+lO3ntNL3108Pvrss=; b=jsQ50Vu3zCti+TQimWKRCm4boa050HbTQvxIVP1EOe4Cna2NVAKDMtxxer1gF+sozq NFVzsfZfdTzwMW1sDQLb4eZoz21R2i0ItExvddtDQT/ZElHhXOj3cB6WlGsU3WpYzNQN 5Vi+bA4300J0gDS3KOF6iVugxDgQlw+xd2/DS3PBVfcHALKleC4uWcuv+JT9CxCqOEUp /x6kK+zU/0vug4tP74C8im2ARwgfuBHG/9//WXPMFIUll7iabViC0zNYUpa3/aLlYW5/ rzJ6I2vv3wKDUNu4keFa/aDfFZY4JD38ULgVcOwJoU/915FcjVhPrX96E4AhjbLQ+LIz u3cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725465632; x=1726070432; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u562QhIJrAV/3yEwnR0FdisLkB+lO3ntNL3108Pvrss=; b=FwPUrTR6qVBGVqywoCE/ghINRwRn6ek7RPkurW5+sBKObpKpJ4ic2aO8pkj0rYDTns 5zV4sj+dzF5RJFpMr7RWScz8tNCcFefUGWoY7jHwGGN7+fNXgvY9LJB40zKDVYFdF6tb D2DXhNySNiW5+TtOrpZcFftM66LGmqN7nsKZbTK52rqJliRqtPCstUxIl0kZWhmkrEWm plsq4Pi9roVCybc4ZBvmXXPNzm6jG1fVBY5xod243AGMtOGGBSu06YWEQU4Ra/Z0r+Zw 1dQXLXV+rXxUZoBl21BxejsAG8s2QiXnUHHcyfhdbp2TPySHGAOG66m65Cs9/Jwua1n3 U+yQ== X-Forwarded-Encrypted: i=1; AJvYcCXrbei9chNNzn7eTEJCgMFbfAVNM8Sv/2QsRpSpmH+4jEe95rUnQ+vWQRmrLqH7Hf+Y0ydnjuJI8zy/0pOSjaRK@lists.infradead.org X-Gm-Message-State: AOJu0YzR+5caC0vTWAflSll5suvae7A3XUy6CYcHeJEmTAsX2+v51bVL g30aYO9T56weub7f12M7pTsRuietFi58wQlhMOBlSYE1HbSGyjCg X-Google-Smtp-Source: AGHT+IEFcd58xREyckVIyq3G5fmmOo1FJAe+mAd3TL6j9pcVBAaX2pHXbBv1SNKS0+RCOnrBGwCzHQ== X-Received: by 2002:a05:6402:13d1:b0:5c2:5dda:973d with SMTP id 4fb4d7f45d1cf-5c25dda9906mr3890079a12.2.1725465632250; Wed, 04 Sep 2024 09:00:32 -0700 (PDT) Received: from skbuf ([188.25.134.29]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c3cc544a3esm76216a12.29.2024.09.04.09.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2024 09:00:31 -0700 (PDT) Date: Wed, 4 Sep 2024 19:00:28 +0300 From: Vladimir Oltean To: Furong Xu <0x1207@gmail.com> Cc: Alexander Lobakin , Serge Semin , "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, rmk+kernel@armlinux.org.uk, linux@armlinux.org.uk, xfr@outlook.com Subject: Re: [PATCH net-next v7 7/7] net: stmmac: silence FPE kernel logs Message-ID: <20240904160028.cjmnadqgcwynncmh@skbuf> References: <3cc959e1ab2e6cc7a4b39d22e34c38df70f01125.1725441317.git.0x1207@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3cc959e1ab2e6cc7a4b39d22e34c38df70f01125.1725441317.git.0x1207@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_090034_538245_DAAD824C X-CRM114-Status: GOOD ( 11.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 04, 2024 at 05:21:22PM +0800, Furong Xu wrote: > ethtool --show-mm can get real-time state of FPE. > Those kernel logs should keep quiet. > > Signed-off-by: Furong Xu <0x1207@gmail.com> > --- I don't have a stmmac-based setup to judge in person. But to me, these still look too chatty, for being things that user space can always query through netlink. 1070 » netdev_info(priv->dev, "configured EST\n"); 1090 » netdev_info(priv->dev, "disabled FPE\n"); Also, they don't seem to be balanced. We don't have "disabled EST" and "enabled FPE"?! I wonder if "disabled FPE" is actually a typo and should have been "disabled EST"? What do you think, should these also be suppressed / deleted?