From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BEB50CD4853 for ; Wed, 4 Sep 2024 16:10:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pTWIkafvhIyaw72vYF2nIu0q0KkJZo9TWe5SKwwB1cE=; b=aps2bHHanQG9MwUozKMbGQRM+f Rnp0tg25HARjSJbhmwnQsjpZV15Bo/8Jf5vcPjOw+bS6ibTOmpv4S/BKiYaAXWX/lByZTOb8Z9P9O Of96GYv6kwSVGHohpAG+fp4ZdkI617shusFw+z0IdBsK+fIQO784vi4VlxpJ+eCM57LMiE3HQrNzv 4w8E5+6AKH0BYP58GxtWrhyo3fc41e0gwReyGRN+s5pXlLMn8gEUJrW3H4UjACRjHFxTkpYHxcawd kCZlocZFa39+oFkVp9jusXJ/f4/ANfwDdYaAzhFoaAIUpX723t8YnJ57YqAhSXYJYkvyq6QLoKTpR 4mlBc7xA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slsak-00000005BgM-3L1J; Wed, 04 Sep 2024 16:10:46 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slsUj-00000005A1S-0yiV for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2024 16:04:34 +0000 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-71788bfe60eso97603b3a.1 for ; Wed, 04 Sep 2024 09:04:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725465872; x=1726070672; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=pTWIkafvhIyaw72vYF2nIu0q0KkJZo9TWe5SKwwB1cE=; b=sqfEJgvtL7BTP1E7ekZqWVnCyFaHPgSkk16LSHTdoIGzH83S2+YqXBBOLje5cFRmHi sC4ZjGsxPBuB8dZ/tP/T94JD3wUG96jCc/4SDWjfdGoDujOGlDSXZtdvRNpXhfD1SXNE giH0rDKTtyeC5mFe9aCIPMt3130uBBH1zAZNwgZfSYkIcazcGFLms7ygXWGtHXFcI41s 73o1Jij9tinHcwj6bg5NIdYQkeXuUM859xnkmb01mjoLM1EV6sAvVxV7BTwom4R9AyKz OA3sb1dcfSw8IpWSnFMN5mI7jM/fMcoWm+d3qMJcQt8RItcfg7hnHFuFy7uaiAOp16Mg p0FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725465872; x=1726070672; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pTWIkafvhIyaw72vYF2nIu0q0KkJZo9TWe5SKwwB1cE=; b=odek0WzVSCr6NWr6pHPb7lTDjZ6jLZ292GXizvxYzXWm6+T+RaobiQ+EKUeoQc4S0X EuIKCEfdwlw/xJy0Sca7W4qeipMl+YvWhOwfv76jcYt1ZlMtHo2lQx1TSmkba2vliNoy RW1jwDbZED5Re9Y0Y1MFNKpgVpGhsQ3HG6RJOuhBeh0hI6DC4k3Ppr2lU/h50sfNA1wx KJwjmy7QcHpUZ4fab7EE0j4Imyl0DNUnA/1a18ZTBfppZEnUiq/boLWaXFc6oKAyS9J0 A5aPFWBL24gf2FN/az4IALuMAsCP1zvrqhPr9mEhV+SulA1DTO//+hSu6b65L64BiUdu /Gfg== X-Forwarded-Encrypted: i=1; AJvYcCVoFxLZVaN4BdGr5Az+itB9kMFn2MWYGtDjVzs6uDAeHJORzhkEf9Gc0NxfHPojaEjjJHKmdepOvB/ptkcnbgzy@lists.infradead.org X-Gm-Message-State: AOJu0YwCGXGQRZh9czMoumVXqK9lgKaFlb0wXMbV4mh5otWR12tzCpwL BjZo+KZP1ivuC+FrXwykbpoXzepK8nJz5C6Czk6VPAx3YmeuBy46qtLnPswa6w== X-Google-Smtp-Source: AGHT+IF8ZgHhZFQkLhu7G3/0nDy7t863NQyJpS+P5ULnYu+8Srp8PCWJulYiZnF2PeyUTMgRJhj56w== X-Received: by 2002:a05:6a00:3e21:b0:714:241d:a323 with SMTP id d2e1a72fcca58-717457cf069mr12861507b3a.17.1725465872123; Wed, 04 Sep 2024 09:04:32 -0700 (PDT) Received: from thinkpad ([120.60.128.165]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7178a9482d1sm25096b3a.71.2024.09.04.09.04.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2024 09:04:31 -0700 (PDT) Date: Wed, 4 Sep 2024 21:34:22 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jingoo Han , Chuanhua Lei , Marek Vasut , Yoshihiro Shimoda , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, abel.vesa@linaro.org, johan+linaro@kernel.org, Shashank Babu Chinta Venkata Subject: Re: [PATCH v6 4/4] PCI: qcom: Add RX margining settings for 16.0 GT/s Message-ID: <20240904160422.gcyrdrzgc47w7pbd@thinkpad> References: <20240904-pci-qcom-gen4-stability-v6-0-ec39f7ae3f62@linaro.org> <20240904-pci-qcom-gen4-stability-v6-4-ec39f7ae3f62@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_090433_336932_B6ED5B85 X-CRM114-Status: GOOD ( 28.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 04, 2024 at 11:53:42AM +0200, Johan Hovold wrote: > On Wed, Sep 04, 2024 at 12:42:00PM +0530, Manivannan Sadhasivam via B4 Relay wrote: > > From: Shashank Babu Chinta Venkata > > > > Add RX lane margining settings for 16.0 GT/s (GEN 4) data rate. These > > settings improve link stability while operating at high date rates and > > helps to improve signal quality. > > > > Signed-off-by: Shashank Babu Chinta Venkata > > Reviewed-by: Manivannan Sadhasivam > > [mani: dropped the code refactoring and minor changes] > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/pci/controller/dwc/pcie-designware.h | 18 ++++++++++++++++ > > drivers/pci/controller/dwc/pcie-qcom-common.c | 31 +++++++++++++++++++++++++++ > > drivers/pci/controller/dwc/pcie-qcom-common.h | 1 + > > drivers/pci/controller/dwc/pcie-qcom-ep.c | 4 +++- > > drivers/pci/controller/dwc/pcie-qcom.c | 4 +++- > > 5 files changed, 56 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h > > index 51744ad25575..f5be99731f7e 100644 > > --- a/drivers/pci/controller/dwc/pcie-designware.h > > +++ b/drivers/pci/controller/dwc/pcie-designware.h > > @@ -209,6 +209,24 @@ > > > > #define PCIE_PL_CHK_REG_ERR_ADDR 0xB28 > > > > +/* > > + * 16.0 GT/s (GEN4) lane margining register definitions > > nit: Gen 4? > > > + */ > > +#define GEN4_LANE_MARGINING_1_OFF 0xb80 > > nit: upper case hex > > > +#define MARGINING_MAX_VOLTAGE_OFFSET GENMASK(29, 24) > > +#define MARGINING_NUM_VOLTAGE_STEPS GENMASK(22, 16) > > +#define MARGINING_MAX_TIMING_OFFSET GENMASK(13, 8) > > +#define MARGINING_NUM_TIMING_STEPS GENMASK(5, 0) > > + > > +#define GEN4_LANE_MARGINING_2_OFF 0xb84 > > Same here > > > +#define MARGINING_IND_ERROR_SAMPLER BIT(28) > > +#define MARGINING_SAMPLE_REPORTING_METHOD BIT(27) > > +#define MARGINING_IND_LEFT_RIGHT_TIMING BIT(26) > > +#define MARGINING_IND_UP_DOWN_VOLTAGE BIT(25) > > +#define MARGINING_VOLTAGE_SUPPORTED BIT(24) > > +#define MARGINING_MAXLANES GENMASK(20, 16) > > +#define MARGINING_SAMPLE_RATE_TIMING GENMASK(13, 8) > > +#define MARGINING_SAMPLE_RATE_VOLTAGE GENMASK(5, 0) > > /* > > * iATU Unroll-specific register definitions > > * From 4.80 core version the address translation will be made by unroll > > diff --git a/drivers/pci/controller/dwc/pcie-qcom-common.c b/drivers/pci/controller/dwc/pcie-qcom-common.c > > index dc7d93db9dc5..99b75e7f085d 100644 > > --- a/drivers/pci/controller/dwc/pcie-qcom-common.c > > +++ b/drivers/pci/controller/dwc/pcie-qcom-common.c > > @@ -43,3 +43,34 @@ void qcom_pcie_common_set_16gt_eq_settings(struct dw_pcie *pci) > > dw_pcie_writel_dbi(pci, GEN3_EQ_CONTROL_OFF, reg); > > } > > EXPORT_SYMBOL_GPL(qcom_pcie_common_set_16gt_eq_settings); > > + > > +void qcom_pcie_common_set_16gt_rx_margining_settings(struct dw_pcie *pci) > > I'd try to find a shorter symbol name here, "settings" seems redundant > after "set". Perhaps just > > qcom_pcie_common_enable_lane_margining() > > or > > qcom_pcie_common_enable_16gt_lane_margining()? > This one looks better. Since lane margining is implemented in the receiver, we don't really need 'rx' in the function name. > if these settings are indeed specific to 16 GT/s. But perhaps it's > better to let the helper honour pci->max_link_speed if different > settings will later be needed for higher speeds: > > if (pcie_link_speed[pci->max_link_speed] >= PCIE_SPEED_16_0GT) > qcom_pcie_common_enable_lane_margining(pci) > I did thought about it during the review, but this setting claims to be for 16 GT/s only. So I wouldn't recommend applying it to other speeds without checking with Qcom. Unfortunately, I'm on vacation for 2 weeks and have limited access to Qcom internal docs/chat. So won't be able to check it soon. If Shashank could check it, it is fine. But on the conservative side, let's stick to 16 GT/s only? - Mani > > void qcom_pcie_common_set_16gt_eq_settings(struct dw_pcie *pci); > > +void qcom_pcie_common_set_16gt_rx_margining_settings(struct dw_pcie *pci); > > And maybe something similar for the eq settings for symmetry. > > Johan -- மணிவண்ணன் சதாசிவம்