From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E02FCD4F21 for ; Wed, 4 Sep 2024 16:30:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=dS4ZeJxSiku8iXspYoVwHHZ8/8DKLfEgc8n0+jdQ0S0=; b=19alSmNOWYZVJqSIFgMdEfkTBQ dMINQKEScH4Da5jyQhPSKpKDJ+vMdCayMTAtloFFtETrGfjufSWXHkGL5tpOoBQ+of5GrtnfIHW/N UaFVPZ9iwrJH574tL2zW17h0rCgkJu7CckKGPdYCeu0QF+gNxw1CMWjiJq4keq1gBDSxzhIyrp6ZW yQv6ZWVp2orTMepCXHT+xX4Cj3bh724XfETYnAeMv+rmWGmSSo31tuA94TRNcyKmUJrK/T4hIz47Y FJ5FQIbKmhjlqTeOqQpzlM7g/Ehj9XuPi1HTxgqN279d5oAR/odIAF02Zw0tvp53hSl5wLCz9EjDS n6R58s2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slsu4-00000005GDP-46MD; Wed, 04 Sep 2024 16:30:44 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slslH-00000005EYA-3BYZ; Wed, 04 Sep 2024 16:21:41 +0000 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-2053f6b8201so35428025ad.2; Wed, 04 Sep 2024 09:21:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725466898; x=1726071698; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dS4ZeJxSiku8iXspYoVwHHZ8/8DKLfEgc8n0+jdQ0S0=; b=kCN+mVpn1EVS3WLkZhsqjkJTCYdcPzXnb0Y/gu5NrN7VE8sY4eARYIeMFhF2bu9pKY bt2fv8itFMQGMZLg0Gj8HhOYbbgHSoaprNH2k9HJsOA8ypw7kwPQD7N6Yqt01jz50kd+ l0ohlV8+HsoTs+5TL7D0X31eEyDc/GjI70CQlnso7PyRuRso+kxkJK0VPo1ZiBb4CSfG r3OOG9gGgW4iIcFTRR2oTpqD7/N7ZnbAYbJHTd9ZoboDV/hx5xNysWkTY63Jaaw5dfOr 6nrI5ixLzU2HagLI4GeWUEmQAs0nTr4fe9o7pQH9ZiMF6EDDLK2ZLn0bf1qONny3/6VQ n5Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725466898; x=1726071698; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dS4ZeJxSiku8iXspYoVwHHZ8/8DKLfEgc8n0+jdQ0S0=; b=MTbJIRDuZvD22ZpRF4TR6Y9p4YnWVVPzog/2OwnCBV7Ub4RcOuLye97uy9bVRAvLTl eGgg2MydFcIyIJrXBrVCnUubjlCkcnUyXHy0Vthust/Z5qzPsy5xq0M7Oyl5dANFQa9W w2zedeRTYK2FHjqqzyFYRUDI9WwimzaFbRdJ0cvGsr+ZrnnweV8Db9MekXAnuILtCw2c Anby6K8Kge/B86A0A/tAvQpfBeJc/tTFe1Z8yYN1RBZI5baDw6qm5gEmGZtKrG48IvO9 MPmtgSZS5MPxwCOnd9Zp124O5RbGSEEp3Rb7+7JG14CLrtRiWaqEkBX9tPDQ1aeQOENT aizg== X-Forwarded-Encrypted: i=1; AJvYcCWVrr9LlJI9VUQr1AZeHK+/3jxQ8QZaYxXjigBYMAVvjvHCSgGHB23pzY94+u6FHyCAot4JBU5OO0Dgi+/nwKKe@lists.infradead.org, AJvYcCXn/4JuRkWhMncx+YIIJiRKXajhic4bKmfq2/XwnnB5o6DchOvFrORI4xSB7wOA5E5YafELrFrfW4C4v4HiP+UVkw==@lists.infradead.org X-Gm-Message-State: AOJu0YyiJ5IDPxhjqoPy8HnfYjLCpejqYbS3tYnJBs6CN8fUFf4nbo6r ZQfdJo1049I1M8HYzQWXC1N4F5KxN5Yy2RgX2uAp2/sHYLlBoRaS X-Google-Smtp-Source: AGHT+IH8pTFO9vIr0YaBR42MHh6KIRHCMK398x+2mhfnYznIbMjWOg4qLWVLoeGg0z6Q1caTBnmwHw== X-Received: by 2002:a17:903:2a8f:b0:205:79c:56f5 with SMTP id d9443c01a7336-20546600327mr148748115ad.27.1725466897699; Wed, 04 Sep 2024 09:21:37 -0700 (PDT) Received: from fedora.. ([106.219.166.153]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-206aea35478sm15316985ad.123.2024.09.04.09.21.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2024 09:21:37 -0700 (PDT) From: Riyan Dhiman To: jim2101024@gmail.com, nsaenz@kernel.org, lorian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com, bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Riyan Dhiman Subject: [PATCH next] PCI: brmstb: Fix type mismatch for num_inbound_wins in brcm_pcie_setup() Date: Wed, 4 Sep 2024 21:49:54 +0530 Message-ID: <20240904161953.46790-2-riyandhiman14@gmail.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_092139_821795_8E54BD4E X-CRM114-Status: GOOD ( 11.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Change num_inbound_wins from u8 to int in brcm_pcie_setup() function to correctly handle potential negative error codes returned by brcm_pcie_get_inbound_wins(). The u8 type was inappropriate for capturing the function's return value, which can include error codes. Signed-off-by: Riyan Dhiman --- drivers/pci/controller/pcie-brcmstb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index e8332fe5396e..b2859c4fd931 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -1030,7 +1030,8 @@ static int brcm_pcie_setup(struct brcm_pcie *pcie) struct pci_host_bridge *bridge; struct resource_entry *entry; u32 tmp, burst, aspm_support; - u8 num_out_wins = 0, num_inbound_wins = 0; + u8 num_out_wins = 0 + int num_inbound_wins = 0; int memc, ret; /* Reset the bridge */ -- 2.46.0