* [PATCH net-next] net: cadence: macb: Enable software IRQ coalescing by default
@ 2024-09-03 18:49 Sean Anderson
2024-09-04 16:26 ` Simon Horman
2024-09-05 0:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Sean Anderson @ 2024-09-03 18:49 UTC (permalink / raw)
To: Nicolas Ferre, Claudiu Beznea, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev
Cc: Michal Simek, linux-arm-kernel, linux-kernel, Sean Anderson
This NIC doesn't have hardware IRQ coalescing. Under high load,
interrupts can adversely affect performance. To mitigate this, enable
software IRQ coalescing by default. On my system this increases receive
throughput with iperf3 from 853 MBit/sec to 934 MBit/s, decreases
interrupts from 69489/sec to 2016/sec, and decreases CPU utilization
from 27% (4x Cortex-A53) to 14%. Latency is not affected (as far as I
can tell).
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
---
drivers/net/ethernet/cadence/macb_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 127bb3208034..8e1e4b2b2386 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4184,6 +4184,8 @@ static int macb_init(struct platform_device *pdev)
dev->ethtool_ops = &macb_ethtool_ops;
}
+ netdev_sw_irq_coalesce_default_on(dev);
+
dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
/* Set features */
--
2.35.1.1320.gc452695387.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: cadence: macb: Enable software IRQ coalescing by default
2024-09-03 18:49 [PATCH net-next] net: cadence: macb: Enable software IRQ coalescing by default Sean Anderson
@ 2024-09-04 16:26 ` Simon Horman
2024-09-05 0:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-09-04 16:26 UTC (permalink / raw)
To: Sean Anderson
Cc: linux-kernel, netdev, Claudiu Beznea, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Michal Simek, David S. Miller,
linux-arm-kernel
On Tue, Sep 03, 2024 at 02:49:12PM -0400, Sean Anderson wrote:
> This NIC doesn't have hardware IRQ coalescing. Under high load,
> interrupts can adversely affect performance. To mitigate this, enable
> software IRQ coalescing by default. On my system this increases receive
> throughput with iperf3 from 853 MBit/sec to 934 MBit/s, decreases
> interrupts from 69489/sec to 2016/sec, and decreases CPU utilization
> from 27% (4x Cortex-A53) to 14%. Latency is not affected (as far as I
> can tell).
>
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
Nice performance improvement :)
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: cadence: macb: Enable software IRQ coalescing by default
2024-09-03 18:49 [PATCH net-next] net: cadence: macb: Enable software IRQ coalescing by default Sean Anderson
2024-09-04 16:26 ` Simon Horman
@ 2024-09-05 0:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-09-05 0:20 UTC (permalink / raw)
To: Sean Anderson
Cc: linux-kernel, netdev, claudiu.beznea, edumazet, kuba, pabeni,
michal.simek, davem, linux-arm-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 3 Sep 2024 14:49:12 -0400 you wrote:
> This NIC doesn't have hardware IRQ coalescing. Under high load,
> interrupts can adversely affect performance. To mitigate this, enable
> software IRQ coalescing by default. On my system this increases receive
> throughput with iperf3 from 853 MBit/sec to 934 MBit/s, decreases
> interrupts from 69489/sec to 2016/sec, and decreases CPU utilization
> from 27% (4x Cortex-A53) to 14%. Latency is not affected (as far as I
> can tell).
>
> [...]
Here is the summary with links:
- [net-next] net: cadence: macb: Enable software IRQ coalescing by default
https://git.kernel.org/netdev/net-next/c/d57f7b45945a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-05 0:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-03 18:49 [PATCH net-next] net: cadence: macb: Enable software IRQ coalescing by default Sean Anderson
2024-09-04 16:26 ` Simon Horman
2024-09-05 0:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).