From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 739D0CD4F22 for ; Wed, 4 Sep 2024 16:30:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S+lIKhw/kfaSVku34X0Ab9bGmDq0FbkIcAeTMZFTisM=; b=s+DSwL6ZGREn1uGbhwfGXzO2P3 a25kYm2/mVVQbmiZTker8LW3NMVsZjHrNWeSmkKaEpGNbErUnu0zGyc7Fx7oi5Nh8jkZyL0SWMCLi GeSP4ggN57Jd6y5WdBBkihv3OI10pwHPmA7OD/ghZ25Vc/HquCrFNpaz5vQ8foY9q0xrRsq7MPn4X xK0NlrDIhfov6z7CPLXCh9xbSPppg3AHPAI1KxOikjfodFCL8PXHkgAJBoT10EHoMBn58gbv39ul7 WeL2jnigvfSXJ4Tl4IPdZZayRg8PfFnntFtl8ySncdQyLr/L5+ZIK9RlbWcLjkJXOJBmL7O44RsfY yBPbHksg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slsu6-00000005GEL-30pb; Wed, 04 Sep 2024 16:30:46 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slsqQ-00000005Fdy-0Wdy for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2024 16:26:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 2DB0AA445EE; Wed, 4 Sep 2024 16:26:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D134DC4CEC6; Wed, 4 Sep 2024 16:26:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725467217; bh=7j0XF4fV98dLGEL3CqtnSJa083XT0sBfqDuPR+hB+gE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h6cooEZDs685/cCiJF7fR1w63yDIR7tmeb4VdA/qaJspmdd3Ibk0rjbbMByYCUCYd u3O9QgZPdyvP5IDEAYxgEMVbSj03/I0yd/4x7ncDlHX9aua/q+Oe/Pu1Fm0+0SjUvv wgNuzehelYkvDdXPUoGV5yUVUBLXebDUR4Szi4RV3aUNCT/mLeWWgMG+ZH8dasmf7s uxy5psEOeRoEZwlF0uAJ68YLUGVYkZ4xqb2+TEcljQywdeXORfdJC966XhyqEkOjck H/b9oRBIpdvMLTaYErJMvivihra2K15zJz5Oe6z3klUF+vnyH+6jwILqrItvsVrRKF OHsDmcNZ7rcbQ== Date: Wed, 4 Sep 2024 17:26:52 +0100 From: Simon Horman To: Sean Anderson Subject: Re: [PATCH net-next] net: cadence: macb: Enable software IRQ coalescing by default Message-ID: <20240904162652.GB4792@kernel.org> References: <20240903184912.4151926-1-sean.anderson@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240903184912.4151926-1-sean.anderson@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_092658_247593_0DFEAB89 X-CRM114-Status: UNSURE ( 9.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Claudiu Beznea , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , "David S. Miller" , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 03, 2024 at 02:49:12PM -0400, Sean Anderson wrote: > This NIC doesn't have hardware IRQ coalescing. Under high load, > interrupts can adversely affect performance. To mitigate this, enable > software IRQ coalescing by default. On my system this increases receive > throughput with iperf3 from 853 MBit/sec to 934 MBit/s, decreases > interrupts from 69489/sec to 2016/sec, and decreases CPU utilization > from 27% (4x Cortex-A53) to 14%. Latency is not affected (as far as I > can tell). > > Signed-off-by: Sean Anderson Nice performance improvement :) Reviewed-by: Simon Horman