From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18666CD4F4A for ; Thu, 5 Sep 2024 00:10:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AoPYghqLUu+vGBdDpZKT4h6NSjDL4l76OPjzQ4XqDeA=; b=Cv/BIMbRLtgdXdETPwSVhk2eN8 CgJsijkweeslUMuDP20HLId0Oay+siZ12VgBY84BeqCRN/hf2HqvsPe1Zg5+ogBDU4TGgbFAIyI04 +iR6LlZRWnInKAJXOMac/DFYo1DfJGGcuytVqwxj4yDVyQaHkIQaMw66eptKuFmio20vh+VpSMYaz HnxRz02nG4zhbK4W1i8j6olnnnQGHxDL8lvzB9dknv5I9F8tu1gcdyo2aXoRWXRH5rCW/2QYI3tma HC/N0QqekgLgjfxDNFqrKldx24rt8SPgdsKHr6q5O/bUwO2ftHZWLRlItB3sqEL6INJR58WQirWOc 3nTLQRVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sm04p-00000006S5W-1NP4; Thu, 05 Sep 2024 00:10:19 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sm03s-00000006RzK-2RZm for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2024 00:09:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 00D575C5596; Thu, 5 Sep 2024 00:09:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF8D4C4CEC2; Thu, 5 Sep 2024 00:09:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725494959; bh=q3AawZYiR83gvNqLyrg3h35TpmUjY6dSAlxTeoKxfcY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PC51BajVeh8uoZEgXFXMlKJi/HIycQJtgVU0WBCWlMliGx3g8guZRxNc/MGJQykxH MOsqd4JrGA7ZkMSO/raxNMsMhNiuJ1BkKI6A6ukmPFOBi3gntdT7KOqbWUmJ4NcIxy FYwZk8WQEWZ6UtphDOVYvo71zGHpYjKVgN1EhVHpt4ZO/DP9sBVeN8z6GkIhXP75DX yQqNpc3qtpumSa2dOjD7Cyki01Ledo1m0J2I8UZAhICtaE9hKyOQAIXSJgccMA5AnQ IXd1N131JwopHBjQW8MItzWEqFB+UQj7Tp6tR5JbcrYl7pK9M742Z3JMMZ1uGWf/jC E482mY15sYcmg== Date: Wed, 4 Sep 2024 17:09:17 -0700 From: Jakub Kicinski To: Sean Anderson Cc: Radhey Shyam Pandey , "David S . Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michal Simek , Andy Chiu , Daniel Borkmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: xilinx: axienet: Fix packet counting Message-ID: <20240904170917.29692bcb@kernel.org> In-Reply-To: <20240903175619.4133633-1-sean.anderson@linux.dev> References: <20240903175619.4133633-1-sean.anderson@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_170920_720443_6108BE56 X-CRM114-Status: UNSURE ( 8.63 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 3 Sep 2024 13:56:19 -0400 Sean Anderson wrote: > axienet_free_tx_chain returns the number of DMA descriptors it's > handled. However, axienet_tx_poll treats the return as the number of > packets. When scatter-gather SKBs are enabled, a single packet may use > multiple DMA descriptors, which causes incorrect packet counts. Fix this > by explicitly keepting track of the number of packets processed as > separate from the DMA descriptors. budget doubles up as a "are we really in NAPI" flag. You can't pass non-zero budget to napi_consume_skb() if not in NAPI. -- pw-bot: cr