From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2B34CA0ED3 for ; Wed, 4 Sep 2024 06:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MgWJAjsOa8a8nRhPswXACA87Tmi1mN8iGhRRAMVSQq4=; b=KS7UNBlEfkyclc5Uz4hjq5Eo0W p3WNIAgOKOYdtKV5XK/MMJVqC6kTqhNBLzAO4k4MxkVy9Sz2wQQvDarTmC/cqSCshIoYygwdBQ+yT nr7HjPpG+mk2GuI0r6RoFmszp/D1QeGk3/avuWG2FNUbyUiJE5jf5n7BBTgY8kzhLKFtERfPB9MEW ObUE0YiwBaO6LON3W+b4coAqDSNwJDUXonYd0DfJFaQtjVgF7xLr69joDW7Jk14ck1hlhAIB6Y9o8 ztCrfhTezyuneRVNlzCzQHnBwh55NKKloNGVoUi0tBA1Q6VdCdg8CPNm5XFEFXwwSdWKatKtuOfUt qdhoLXqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sljPp-000000030p9-1RXi; Wed, 04 Sep 2024 06:22:53 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sljOu-000000030kA-48CI for linux-arm-kernel@bombadil.infradead.org; Wed, 04 Sep 2024 06:21:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MgWJAjsOa8a8nRhPswXACA87Tmi1mN8iGhRRAMVSQq4=; b=XG1spjCDjWTMIAhRnPbRgFzWju dr9UDz9LjvBIYDyZJYFD1PK/zrtDzeXx+7Iqy73Cmf/PI5ty6OZ2bYdgg9UiVO3oAbAa7QAJRdoep BBdm99OzUoh6OHHTM1wwiWRt7LGvVVFdUrj2B0h2/Wfih6//Dv6E0hDxiarm7GP5++uxtw6A2ANcf tSPtvNU3Yqqjy89Jzjbii7K3fhIXCPNIsbYnrHF21i3d0xgf2J2pdcSS2TP5Qaacsjk8+ebHYLgly 7lzT0yZjajpUEA3XkryCLj+PZ+CTO77zsS6MMHqms/Iu2BzrGeNzhpVSjdZVtfPzAkFs/cSH5TRfu hUoyfzEw==; Received: from nyc.source.kernel.org ([147.75.193.91]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sljOf-000000008on-0QdN for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2024 06:21:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 36AA3A40E52; Wed, 4 Sep 2024 06:21:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D618C4CEC2; Wed, 4 Sep 2024 06:21:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725430888; bh=45T0UdM4XULpq6I/wvSmgNZL5OfJfMSSqZmgV1iBb8c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kVDDzh6QVMrQmWm/Ayy6BLEtPbpWxLD7Dmok9kpi96Xv/j0ze8gum1MQweUGRZbqZ 31M1w8Yh3WWSQU6f7wOP33I8H5JvRqJZUjUc19FCXDNw81VsJpVLEVOi+xUaEzIhOj SWymqg1X2y7EYjHRJXXnn0znfNviyj2J1jFaQMw8= Date: Wed, 4 Sep 2024 08:21:25 +0200 From: Greg KH To: Paul Pu Cc: p.zabel@pengutronix.de, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sasha Levin , Lucas Stach , HuanWang@gehealthcare.com, taowang@gehealthcare.com, sebastian.reichel@collabora.com, ian.ray@gehealthcare.com, stable@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: imx: ipuv3-plane: fix HDMI cannot work for odd screen resolutions Message-ID: <2024090452-canola-unwoven-1c6c@gregkh> References: <20240904024315.120-1-hui.pu@gehealthcare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240904024315.120-1-hui.pu@gehealthcare.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_072152_939866_57CD6AF6 X-CRM114-Status: GOOD ( 13.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 04, 2024 at 05:43:15AM +0300, Paul Pu wrote: > This changes the judgement of if needing to round up the width or not, > from using the `dp_flow` to the plane's type. > > The `dp_flow` can be -22(-EINVAL) even the plane is a PRIMARY one. > See `client_reg[]` in `ipu-common.c`. > > [ 0.605141] [drm:ipu_plane_init] channel 28, dp flow -22, possible_crtcs=0x0 > > Per the commit message in commit: 71f9fd5bcf09, using the plane type for > judging if rounding up is needed is correct. > > Fixes: 71f9fd5bcf09 ("drm/imx: ipuv3-plane: Fix overlay plane width") That id is not in Linus's tree :( > Cc: stable@vger.kernel.org > > Signed-off-by: Paul Pu No need for the blank line before this. thanks, greg k-h