From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4BDCCD5BC9 for ; Thu, 5 Sep 2024 14:54:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2g54gJr7dWkd7+x+HAWM4aabzzENjq1zl97emHDcyg0=; b=HJUlNc/ScbkO/0E709dnxI2bR+ qY6lhsht7l2CVaPG4QJxZDt7ws5tY0ky6Mmjudi4ZC7mnLEUsiRhLh2mPH6TcY4ntvpEtw92dVKdA 5UnjTtm5DsctfwQh/0zlupVvl7XrLbFsAc1YgQtsFFpOLAeaO63ArvFtpeRFYohXkXcpghIsRvTub R+et5g5vOC9Id3YZKwEVGzWnSx1ng3rMBqTqoja47nt2BlGPy+fm+vsJHSG/aPCVCsTACk++uTekC j83tJyx6NTOUnqbko6NX+Rthm9cTPugEobpy5m0hBzto4ap4iwP6YA/tJp9IY6czC/IM+ErfPQPsk tWeLsUpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smDsd-00000008oat-2gR7; Thu, 05 Sep 2024 14:54:39 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smDqe-00000008nwV-0vea for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2024 14:52:37 +0000 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5c245580f5cso111424a12.0 for ; Thu, 05 Sep 2024 07:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725547954; x=1726152754; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2g54gJr7dWkd7+x+HAWM4aabzzENjq1zl97emHDcyg0=; b=QKDe+TVaqUon7jUR/ehiMyPQ+agc6aVBkmns06m5C9RM4i+/+yGmnEHJO/bqrEdxEH mJRcvkXr4vDvgnkOfkkfXvrEO8d+uYHvIgvqDhoeeVwvC8+SF0iQ0nm91+4oiOvAL3YD 6JuboqHMeIfIiK5d6MqLIbdYKH86+rQoj2Dwvhkxv+nhhx/9EH1I3kUDW4IQum8kN5T6 vVUPNlFx9acTgPdI09HU6Gaea0/jubRUft0hQQzxncmqOdrKFpSCygygzgcTZT6S/ENN QaW9DMQpaxRAUg4AsW0uL+sUO2aV/1Q5f3mQssimF1hzCh5HLi4/k16KC7op5luQgR7v 8dpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725547954; x=1726152754; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2g54gJr7dWkd7+x+HAWM4aabzzENjq1zl97emHDcyg0=; b=DbC22iljhMzFEeR0xd1w28/UzUSxwj3kyX4gCJutNtJOCFyIkIjBgCCkqXcI3zIxMf PvRiSxeq0168T2SvdaMzpznnzBER0i1VoX1Orfv4Tu4/Q1miZDZIXQ5528CDHBvhPmYi OyzsY+tD9zbt/kj6UzAEIK0LoRZs6KHB3gViK+v5IZ9VvPwqyu2GPCtAasUcG7oFxB2z IoEG+CwIABz00btNspui6NEur6c9ZGtmFfHAWOydpJPtZYxVAuR1ucpdXGB6+EqUmLqy TZWfFMl1fsJxwaeeEth/juVlyGpmwEUzCnUbEY1mAE+28sPDNNCoyf6SznWoppIePory cF0Q== X-Forwarded-Encrypted: i=1; AJvYcCUvAoabhIsXVyQZaV61UPUfP34EGqW91iGaewxonznhx0zcgt/vS0WqmTjQSyQ95MFX0PBXGFwpphEL2PIIkZGS@lists.infradead.org X-Gm-Message-State: AOJu0YzUaYjYs2YkkAamBFAxkPPBo9e/jOHcJPj40tendhWQgtyCczVr Phn5vDlKgD4Wpaof5bZJ2heKCrucpIUwgUkDWAkeBpOit0b7MAqf X-Google-Smtp-Source: AGHT+IEgYP9p1NEcW+b7LA2SeKoblfl5T6ojFMNpFfgzLYg4QChmu3Sjk2pZhSKhLGsFCf2S5rRTOQ== X-Received: by 2002:a05:6402:1ecb:b0:5c2:67da:9742 with SMTP id 4fb4d7f45d1cf-5c267da9903mr5148025a12.4.1725547953042; Thu, 05 Sep 2024 07:52:33 -0700 (PDT) Received: from skbuf ([188.25.134.29]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c3cc551234sm1303917a12.36.2024.09.05.07.52.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 07:52:32 -0700 (PDT) Date: Thu, 5 Sep 2024 17:52:28 +0300 From: Vladimir Oltean To: Furong Xu <0x1207@gmail.com> Cc: Alexander Lobakin , Serge Semin , "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, rmk+kernel@armlinux.org.uk, linux@armlinux.org.uk, xfr@outlook.com Subject: Re: [PATCH net-next v8 6/7] net: stmmac: support fp parameter of tc-taprio Message-ID: <20240905145228.raglhbpikfxolgrw@skbuf> References: <55067bfa505933731cbd018d19213b89126321e3.1725518136.git.0x1207@gmail.com> <55067bfa505933731cbd018d19213b89126321e3.1725518136.git.0x1207@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55067bfa505933731cbd018d19213b89126321e3.1725518136.git.0x1207@gmail.com> <55067bfa505933731cbd018d19213b89126321e3.1725518136.git.0x1207@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240905_075236_284170_CDA10E3F X-CRM114-Status: GOOD ( 10.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 05, 2024 at 03:02:27PM +0800, Furong Xu wrote: > tc-taprio can select whether traffic classes are express or preemptible. > > 0) tc qdisc add dev eth1 parent root handle 100 taprio \ > num_tc 4 \ > map 0 1 2 3 2 2 2 2 2 2 2 2 2 2 2 3 \ > queues 1@0 1@1 1@2 1@3 \ > base-time 1000000000 \ > sched-entry S 03 10000000 \ > sched-entry S 0e 10000000 \ > flags 0x2 fp P E E E > > 1) After some traffic tests, MAC merge layer statistics are all good. > > Local device: > [ { > "ifname": "eth1", > "pmac-enabled": true, > "tx-enabled": true, > "tx-active": true, > "tx-min-frag-size": 60, > "rx-min-frag-size": 60, > "verify-enabled": true, > "verify-time": 100, > "max-verify-time": 128, > "verify-status": "SUCCEEDED", > "statistics": { > "MACMergeFrameAssErrorCount": 0, > "MACMergeFrameSmdErrorCount": 0, > "MACMergeFrameAssOkCount": 0, > "MACMergeFragCountRx": 0, > "MACMergeFragCountTx": 17837, > "MACMergeHoldCount": 18639 > } > } ] > > Remote device: > [ { > "ifname": "end1", > "pmac-enabled": true, > "tx-enabled": true, > "tx-active": true, > "tx-min-frag-size": 60, > "rx-min-frag-size": 60, > "verify-enabled": true, > "verify-time": 100, > "max-verify-time": 128, > "verify-status": "SUCCEEDED", > "statistics": { > "MACMergeFrameAssErrorCount": 0, > "MACMergeFrameSmdErrorCount": 0, > "MACMergeFrameAssOkCount": 17189, > "MACMergeFragCountRx": 17837, > "MACMergeFragCountTx": 0, > "MACMergeHoldCount": 0 > } > } ] > > Tested on DWMAC CORE 5.10a > > Signed-off-by: Furong Xu <0x1207@gmail.com> > --- Reviewed-by: Vladimir Oltean