From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FC79CD5BC9 for ; Thu, 5 Sep 2024 14:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xylf9X58PdeAvnejc6uMarphR5HQ4AIAHZcsnVNJFQk=; b=bd4mBP2cQzQ6Rrlc+YRZoQwG8+ Zy0OIkRy6oAagQ6SRWf0G/Vh+bQ03GfvTo6b9pn35gSDRddLTT7hcsEL2/rmVEYvNqwTHspMa5f4/ PnPRDhNfuYdok7qGfKaEUs2czsiXkgdcPJPF9YMxDStRC2SMSXqRt4Hl0InatPvPETVGq9jwHwrNB DpMabaNK0VwYlmJvRkWncPiWW4lsc1aGMwwrCOmbkoObnGMCL77MtORE5C07hFNmNQtudmo2wL2jk +CEx+NOINMFnee2lHyDKtpfU9f0j5eS2CtG4Lr8wZVBDebDoFjyzgaPnWk00rSauzUt0iC8vzSkCZ QgXSyicw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smDxA-00000008q6T-2x3d; Thu, 05 Sep 2024 14:59:20 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smDvz-00000008pgU-2n5Q for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2024 14:58:09 +0000 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-a86a69bfcdaso6126666b.0 for ; Thu, 05 Sep 2024 07:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725548285; x=1726153085; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xylf9X58PdeAvnejc6uMarphR5HQ4AIAHZcsnVNJFQk=; b=nk5p2jD4+dAF4X9pc2JZP67PKb915Leqqeg+fObYNhFbdFN03QZagJ5n+0k8atPeNX aHBx7Uj6UhKgP045MQ9WUT9CzmiGa1NZBXAZxlD8nxIlwwijcKiiANHeq52xc+jIIg1T gU8R5PhaDZ0u62cu15aSqoEOA/BmXV2uuxu8Up/QOOPb278mXvP8XabNJ3ws3jdCpmH+ Q4/H/5LDLBA7ifi6R3hRSGN7tQVG7GVdQc5k2DteVNtYSx0q2Xg2LmLUJS4YChH19Kj9 g9FcDIEmBfJaiAYxE/UJEiqgQ7HIShZIa4TbIBkMO2UOMuOJay/0JilxQ/BQG5PU02lt l75A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725548285; x=1726153085; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xylf9X58PdeAvnejc6uMarphR5HQ4AIAHZcsnVNJFQk=; b=SlXh00ssytpFqx8vDXo5NU0uP6gkhs1SdgNVHFA7iwFfHPqLMeffUoC4JFPR7aCSSM mW7HhcQBoQHG5RAIevCAFNHs9gO0gbws3aaq5+CD9peE0Tb7vOWUHin7WyqblYW1y8bl RQcbD9T7a/dKC1S2ayobPICbwYIW4LsVvdBq4pURpfcj7MyNXgWL4R+JtHrEkNGNYuFT QYcsTe0N30vI9DspcKVbG58K1vc/Zk/lnGLaIykVXK+BZ6oEwYhIWXaa3PFXJg6Y16K0 jKleROSzXtjIZ+87wFedNq7E+MHhnRFKD6xfNrmQJZtbtYAWPZATZqEvDMMYS3OnLHWi 5jIQ== X-Forwarded-Encrypted: i=1; AJvYcCWgWeedMYKl2yK/U+r5ogXjq8SuSd/ypbNTHB7H/2SNTQ39Yalt0oWD8wGue8h39ali8Opkaj/2z0i6IstYEMUJ@lists.infradead.org X-Gm-Message-State: AOJu0YxKH7Ms9D2YyM8bHZMLQC2VYj3XE2/4dxLq4jPQPqFYxEPe6Nx2 CBBPiUq1aBSJLx/TkjiXtYppPScgP2yYf46lk4rOpteSUYdqTC+8 X-Google-Smtp-Source: AGHT+IFWgUHQjpPyF03ycuCrazcYNTIjo4bK7NC3jvKTTABsJhGvL/b4OqvEVAPSV5x1wPS7VF4ZTg== X-Received: by 2002:a17:907:c21:b0:a7a:9d1e:3b28 with SMTP id a640c23a62f3a-a89a377d761mr914720066b.5.1725548285025; Thu, 05 Sep 2024 07:58:05 -0700 (PDT) Received: from skbuf ([188.25.134.29]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8a623a464csm145762466b.150.2024.09.05.07.58.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 07:58:04 -0700 (PDT) Date: Thu, 5 Sep 2024 17:58:01 +0300 From: Vladimir Oltean To: Furong Xu <0x1207@gmail.com> Cc: Alexander Lobakin , Serge Semin , "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, rmk+kernel@armlinux.org.uk, linux@armlinux.org.uk, xfr@outlook.com, Vladimir Oltean Subject: Re: [PATCH net-next v8 3/7] net: stmmac: refactor FPE verification process Message-ID: <20240905145801.hyhjalu3bjfh5gs5@skbuf> References: <0b72fd0463b662796fd3eaa996211f1a5d0a4341.1725518135.git.0x1207@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0b72fd0463b662796fd3eaa996211f1a5d0a4341.1725518135.git.0x1207@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240905_075807_744161_668918B8 X-CRM114-Status: GOOD ( 12.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 05, 2024 at 03:02:24PM +0800, Furong Xu wrote: > struct stmmac_fpe_cfg { > - bool enable; /* FPE enable */ > - bool hs_enable; /* FPE handshake enable */ > - enum stmmac_fpe_state lp_fpe_state; /* Link Partner FPE state */ > - enum stmmac_fpe_state lo_fpe_state; /* Local station FPE state */ > + /* Serialize access to MAC Merge state between ethtool requests > + * and link state updates. > + */ > + spinlock_t lock; > + > u32 fpe_csr; /* MAC_FPE_CTRL_STS reg cache */ > + struct timer_list verify_timer; > + struct ethtool_mm_state state; I don't know what to say about keeping a full-blown struct ethtool_mm_state copy in struct stmmac_fpe_cfg. You don't populate two of its members: tx_active and tx_min_frag_size, and thus they would be invalid if anyone tried to access them. And two more of its member variables are populated with driver-constant values: max_verify_time and rx_min_frag_size. This leaves only verify_time, verify_status, pmac_enabled, tx_enabled, verify_enabled. Maybe it would be better to just open-code these variables directly in struct stmmac_fpe_cfg.