From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63E28CD5BC9 for ; Thu, 5 Sep 2024 15:30:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oglj13jT8NZDdkH940RV6GyfjKTBkDr1yKpmIVrAzrY=; b=obJO6uIp17WFAGg7BhNHIm5fAj aSWCIXYhTsBxIIvG33nbKdNDc6E/c79y9v3tnXOdJaEnvV+3e7YjQRBexYvV/Hhi2Z4EjlAj1qryO n4j2bYEsgIAcN57IcEi3rEvSUhHwEuGCXAGXMR4rGmjSDBAU3E3vS8p88o6akX+db8MsgHuIXYvVr MgqRNmH9i/w0yJl0Bu6dzF4ee6iF2lXMpvMY09riTSn/uWs1p+/4N7qBHtoWoS8rW8XJhGqrzKxGg 19qyJzQ8nLj2aGMO5c9uRComihFygoCEk0VCMdcntcRFmk376vsBez2NkajREAvfkJwJkPWcOSlE7 Wob46Ijw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smERI-00000008x8J-24qa; Thu, 05 Sep 2024 15:30:28 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smEOr-00000008wnv-3sd6 for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2024 15:29:29 +0000 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-71788bfe60eso772179b3a.1 for ; Thu, 05 Sep 2024 08:27:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725550077; x=1726154877; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=oglj13jT8NZDdkH940RV6GyfjKTBkDr1yKpmIVrAzrY=; b=QXwsRMK375ovo18RGFq86c8hlT36a6tFk2fXOlByld98o9138YH5OmpTJUcib+OwgC JM67kwT3ogYrylTWFWAslt4qk0I9QrBkq5BLYGwZpUklzZjbBNW0p85sTxVz8JVZaNCY UNvsupPbm/wdX5npZe6DUH3PDyQZYiQ2y7IPuzA4Nczxf0GaB//rWwTDhhrmpliZZWYI whmet2oegOTlwhwGeYpc4h2mJzWAOuZUk+xbhgIamZ8CB6ozdiBq7jWv62OVQhWx7w7Z ry/4pWkwcznUFZVtiWIBl5K+IBtcm34eJJIZPBFFGa0GOartcM5Xh12ZJhRtuu6XqXxT XADw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725550077; x=1726154877; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oglj13jT8NZDdkH940RV6GyfjKTBkDr1yKpmIVrAzrY=; b=vQ4KsGw6/ErzyIq1Men9EsHT+j5bqqvJUcYuEctkETmNTF6IXlh9NyCFmzuhMHCZNm e2ZwhLw0qNKiB2GE6BrXRlmlTNx8QOd5nHxPGvh3djXcz0YCCjGF7ROeTiN3bVPAPETz yxxjSBLQlcIgIxWmhgEpzJVPJ7SPjvQlLmFPJw4i62YJ6sgaGw7gc8OdeH9MPo+Wx8dN u0SaEU1Pr7IqMM0foQ6ys03Q5dZuUyDneAAWFAy/exLJAAwbVhVOI/88ItRl6dblZWsW szo2V1d+QYhhGm6EPkidwjLYGBqChyRChMryV5U7jfDU8pWpU/ihmpSewWyogUXbe0l2 LO4Q== X-Forwarded-Encrypted: i=1; AJvYcCXGK2XanZZtgkq2JrC+7jkzWbssfG/FX0zDdZREYVV56bCN3y3LODAI41O+QvEmZcKzV40+5FyEGENoAAVuC0Li@lists.infradead.org X-Gm-Message-State: AOJu0YzBgiowcHa4uCi5l6TrGozKO9HAqXx1A2VEO75wdLKjB61Cx+cX WiG8465+j6kOi6CHQIqEJRbFv9QBEH9JGDUA23zzlipQe+qNt5fsjUULw07nyA== X-Google-Smtp-Source: AGHT+IFlXu8G84DVRp5SNbsxFjbfXP/Dw/Xcx3dm3n7P1qn/jaVoagoGhBzzqVVH6hqorkyr3amAiw== X-Received: by 2002:a05:6a00:4f88:b0:70d:3777:da8b with SMTP id d2e1a72fcca58-717458a9cfamr16603380b3a.25.1725550076860; Thu, 05 Sep 2024 08:27:56 -0700 (PDT) Received: from thinkpad ([120.60.52.248]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7178c66839dsm1508852b3a.15.2024.09.05.08.27.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 08:27:56 -0700 (PDT) Date: Thu, 5 Sep 2024 20:57:42 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jingoo Han , Chuanhua Lei , Marek Vasut , Yoshihiro Shimoda , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, abel.vesa@linaro.org, johan+linaro@kernel.org, Shashank Babu Chinta Venkata Subject: Re: [PATCH v6 3/4] PCI: qcom: Add equalization settings for 16.0 GT/s Message-ID: <20240905152742.4llkcjvvu3klmo6j@thinkpad> References: <20240904-pci-qcom-gen4-stability-v6-0-ec39f7ae3f62@linaro.org> <20240904-pci-qcom-gen4-stability-v6-3-ec39f7ae3f62@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240905_082757_986953_694E80CA X-CRM114-Status: GOOD ( 21.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 04, 2024 at 11:39:09AM +0200, Johan Hovold wrote: > On Wed, Sep 04, 2024 at 12:41:59PM +0530, Manivannan Sadhasivam via B4 Relay wrote: > > From: Shashank Babu Chinta Venkata > > > > During high data transmission rates such as 16.0 GT/s, there is an > > increased risk of signal loss due to poor channel quality and interference. > > This can impact receiver's ability to capture signals accurately. Hence, > > signal compensation is achieved through appropriate lane equalization > > settings at both transmitter and receiver. This will result in increased > > PCIe signal strength. > > > > Signed-off-by: Shashank Babu Chinta Venkata > > Reviewed-by: Manivannan Sadhasivam > > [mani: dropped the code refactoring and minor changes] > > Signed-off-by: Manivannan Sadhasivam [...] > > diff --git a/drivers/pci/controller/dwc/pcie-qcom-common.h b/drivers/pci/controller/dwc/pcie-qcom-common.h > > new file mode 100644 > > index 000000000000..259e04b7bdf9 > > --- /dev/null > > +++ b/drivers/pci/controller/dwc/pcie-qcom-common.h > > @@ -0,0 +1,8 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved. > > + */ > > + > > +#include "pcie-designware.h" > > You only need a forward declaration: > > struct dw_pcie; > > > + > > +void qcom_pcie_common_set_16gt_eq_settings(struct dw_pcie *pci); > > Compile guard still missing. > Perhaps we can just get rid of the Kconfig entry and build it by default for both RC and EP drivers? I don't see a value in building it as a separate module. And we may also move more common code in the future. - Mani -- மணிவண்ணன் சதாசிவம்