linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Min-Hua Chen <minhuadotchen@gmail.com>
To: andyshrk@163.com
Cc: airlied@gmail.com, andy.yan@rock-chips.com, daniel@ffwll.ch,
	dri-devel@lists.freedesktop.org, heiko@sntech.de,
	hjc@rock-chips.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	maarten.lankhorst@linux.intel.com, minhuadotchen@gmail.com,
	mripard@kernel.org, tzimmermann@suse.de
Subject: Re:[PATCH] drm/rockchip: include rockchip_drm_drv.h
Date: Fri,  6 Sep 2024 17:17:25 +0800	[thread overview]
Message-ID: <20240906091728.109570-1-minhuadotchen@gmail.com> (raw)
In-Reply-To: <6f07603.7f9.191c4c887b1.Coremail.andyshrk@163.com>

Hi,

>Hi  Min Hua,
>   Thanks for your work
>
>At 2024-09-06 06:38:50, "Min-Hua Chen" <minhuadotchen@gmail.com> wrote:
>>Include rockchip_drm_drv.h to fix the follow sparse warning:
>>
>>drivers/gpu/drm/rockchip/rockchip_vop2_reg.c:502:24: sparse:
>>warning: symbol 'vop2_platform_driver' was not declared.
>>Should it be static?
>>
>>No functional change intended.
>>
>>Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
>>---
>> drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>>diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>>index 18efb3fe1c00..c678d1b0fd7c 100644
>>--- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>>+++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>>@@ -14,6 +14,7 @@
>> #include <drm/drm_print.h>
>> 
>> #include "rockchip_drm_vop2.h"
>>+#include "rockchip_drm_drv.h"
>> 
>
>We already have a patch[0] include rockchip_drm_drv.h in rockchip_drm_vop2.h
>
>[0]https://patchwork.kernel.org/project/linux-rockchip/patch/20240904120238.3856782-3-andyshrk@163.com/ 

that's great, thanks for letting me know.

Min-Hua


  reply	other threads:[~2024-09-06  9:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-05 22:38 [PATCH] drm/rockchip: include rockchip_drm_drv.h Min-Hua Chen
2024-09-06  0:42 ` Andy Yan
2024-09-06  9:17   ` Min-Hua Chen [this message]
2024-09-06  9:28   ` [PATCH] " Diederik de Haas
2024-09-06  9:50     ` Andy Yan
2024-09-06 11:07       ` Diederik de Haas
2024-09-07  3:02         ` Min-Hua Chen
2024-09-07  8:47           ` Diederik de Haas
2024-09-07  8:56             ` Andy Yan
2024-09-08 13:12               ` Min-Hua Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240906091728.109570-1-minhuadotchen@gmail.com \
    --to=minhuadotchen@gmail.com \
    --cc=airlied@gmail.com \
    --cc=andy.yan@rock-chips.com \
    --cc=andyshrk@163.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).