From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E93AE6FE47 for ; Sat, 7 Sep 2024 05:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To:From:Subject :References:Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8ApYaFx0+sxUWqA8R+JFTFM43Yl04Vb2u4ryemp0VHs=; b=AEQ/QJZQBII9TEI/hwgu7DEiyn +pUI+CAIC7qw9t9r2C1QpoZ1xwfv3wI3RvTh51xwlyJHhzAxufeJUkigv/qOnHJH8qZ2FjLad9WoU GM+e3V6Bhzu0MOBwt/d6DjP95YPkka4Ru3k0l2Kzn1f07jgcblyaAMBKk08mCw3IHL3wjDDSuOp4S m/agxtASNjkNyPfsrukttJ1R3k0Paq2d5kHYvoMYgxHmm+SQdJZGup0QXFgbtS+bREVzDsEDhudIB wtTILOM78EflQG2Wv4n0ORJMPWPhor1k3hLnguDrsAyx0bKv4EloEZn+CMIji7O5x0svBJyn85DhT tyXSTMFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smnii-0000000EMmO-0khz; Sat, 07 Sep 2024 05:10:48 +0000 Received: from mail-yw1-x114a.google.com ([2607:f8b0:4864:20::114a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smngi-0000000EMDF-0pAU for linux-arm-kernel@lists.infradead.org; Sat, 07 Sep 2024 05:08:45 +0000 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-6d73c1c8356so86673437b3.1 for ; Fri, 06 Sep 2024 22:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725685723; x=1726290523; darn=lists.infradead.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=8ApYaFx0+sxUWqA8R+JFTFM43Yl04Vb2u4ryemp0VHs=; b=AU6b6+iReanmvFw90P/DnkAf7dciBUZWfEqfu9fB0dbD+RNlw1pBvcbWOvCszthW7G d6ZHp7SMbVp3yWX7xsufX5z6fTZ89rPg1TDo+Ll/KdVqTzC/yJxKLXRUj6WVcXvI3xhU 9AEmk5PLHUO6ZHd8bxfftq0tSrUp/c7Xm1DSX+ZcsPioZLGwzFCyWin1SzBz362dypc/ j0evQxv1KohBZdpAXH9a4LNnN10TfVtq/6Sp0FVoQni3a+quVfqao0qluloQfYSMVvlF fzju752jM/QnQbbzb7QJTmEOWI1Uoy90FtAkBGG2f8Sovz0pwB9cXg1yDRv9bZz7dcDM Ydbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725685723; x=1726290523; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8ApYaFx0+sxUWqA8R+JFTFM43Yl04Vb2u4ryemp0VHs=; b=hVA0kotgMxa2MN4g3SXJHQ7lDek2IAXOjKsg3JemvE51ZfvXwiYOGRPYFprPc2m0c6 LNBov3mJ0UWS0aLS8o+or19Fg3xPmqlNszgY5Lmz1aS/D95Lxldp5S7twZsVeemwjLaS QlO4jbWxgp0CWKbrJQghbamYZsi+T727D07xpl91b0A6vSizWElLIUU33KLhhEygLqx6 3IkeVE6o/R89WV7B+7fescG/pHCbelXtlEWlTP2GvYgGCrNn2In7a7gn8bS9OZ51kjEE ZhzAGiRM1trMUgzISfF3Znx0oqp3p02jngosdRnPfnD/WSOU2aulhLix0zmwJ7L9mNhd SDiw== X-Forwarded-Encrypted: i=1; AJvYcCXPxGrxlKDW8H13ax9yU6onsdw30JK6YArc/yFs0PhmrP5UNQeCEywhCo1HYyvG3Ra3lMJ/MwPNcHrG4Usrl6Y5@lists.infradead.org X-Gm-Message-State: AOJu0Yxyo3lIWGfThgk2blASD1sBS6AKh6dX6de63OTPCWvR8sRMACbA JrS8qS3z4vl6khRHWCu1U4bF2pbzjoiYfkoUunjJilFRxBKCu637C5eDe5dBYdZEeSpcwa0ugcD 93EOs1g== X-Google-Smtp-Source: AGHT+IEP84F/M2rTb3JNZ7bCbxgU/+jIK+b9LqWkHujq8bu5u0u7fEm7frKSL7le+5SzKQ0eekBwy8lqkNNo X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:90e5:a813:c3d3:daed]) (user=irogers job=sendgmr) by 2002:a05:6902:4d1:b0:e0e:a784:2957 with SMTP id 3f1490d57ef6-e1d34865f70mr12294276.1.1725685722506; Fri, 06 Sep 2024 22:08:42 -0700 (PDT) Date: Fri, 6 Sep 2024 22:08:16 -0700 In-Reply-To: <20240907050830.6752-1-irogers@google.com> Message-Id: <20240907050830.6752-2-irogers@google.com> Mime-Version: 1.0 References: <20240907050830.6752-1-irogers@google.com> X-Mailer: git-send-email 2.46.0.469.g59c65b2a67-goog Subject: [PATCH v1 01/15] perf list: Avoid potential out of bounds memory read From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Ravi Bangoria , Weilin Wang , Jing Zhang , Xu Yang , Sandipan Das , Benjamin Gray , Athira Jajeev , Howard Chu , Dominique Martinet , Yang Jihong , Colin Ian King , Veronika Molnarova , "Dr. David Alan Gilbert" , Oliver Upton , Changbin Du , Ze Gao , Andi Kleen , "=?UTF-8?q?Cl=C3=A9ment=20Le=20Goffic?=" , Sun Haiyong , Junhao He , Tiezhu Yang , Yicong Yang , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240906_220844_258684_79FFD414 X-CRM114-Status: GOOD ( 13.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If a desc string is 0 length then -1 will be out of bounds, add a check. Signed-off-by: Ian Rogers --- tools/perf/builtin-list.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c index 82cb4b1010aa..65b8cba324be 100644 --- a/tools/perf/builtin-list.c +++ b/tools/perf/builtin-list.c @@ -173,7 +173,7 @@ static void default_print_event(void *ps, const char *pmu_name, const char *topi if (pmu_name && strcmp(pmu_name, "default_core")) { desc_len = strlen(desc); desc_len = asprintf(&desc_with_unit, - desc[desc_len - 1] != '.' + desc_len > 0 && desc[desc_len - 1] != '.' ? "%s. Unit: %s" : "%s Unit: %s", desc, pmu_name); } -- 2.46.0.469.g59c65b2a67-goog