From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC391EB64CA for ; Sat, 7 Sep 2024 16:47:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U5R9nTQZu/hUTP42S2EgYrqwUADDe4Pdm/gKm03YwV4=; b=w1UVk3YNRGd9tFbWYz1moJz3Mv sjcGJ1pcjsQoEBBZP7EVQzQgPnpZf8GzuQqCRXvbXLONvV7UUCQvc9PwkFGLe3qg4Gf+6ax68G8Er AGX/yw57pQRjWO4VNVH/uGGmjACKfm/eCGuAmC6Qjlk1ByosvHqJt0Iw89s7Ys35CVRPQYiZHZ/H+ a/eKJHmQ62IwhQ7CTDkHesOQAkRKDbJuA2xGr+tbsUAZh93wrCbOODvq/KIJKiylVZ0WP8T9G8l/i qx47fZ8Ign0qbNApT6NYoJxnBJbU+lRnzv/8vuBliiqmJr9VbOGTRuEn+nGmHUxDAcwoBVLcuNeKD ytr/V8Ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smyan-0000000FKBE-2BtJ; Sat, 07 Sep 2024 16:47:21 +0000 Received: from mail-il1-f176.google.com ([209.85.166.176]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smyZl-0000000FK5Y-1NJt; Sat, 07 Sep 2024 16:46:18 +0000 Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-39f51371baeso11251485ab.3; Sat, 07 Sep 2024 09:46:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725727576; x=1726332376; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U5R9nTQZu/hUTP42S2EgYrqwUADDe4Pdm/gKm03YwV4=; b=nxe8FG/88EwLYHANH5TM/PQ+++sPiU3Lh8t6diDZtxtS2bRIBX0SPPe0YSdu/BlSDF mB2B5lFSTIMZTBbFuep723G3PwewGrFiSyXFWgxptenVw1xoZxtQ/a0VL6+Ev29J3T72 wJNUHl7H9tIdOKYAYySgSDUPoG3+p6ympfS99aPAp55OaV8wdxvoP6vs91H3nqzykNiH CfcZKFIVauMmOaK+IURDZehgt8RPm9r9n/pdW4QrxtIQEaq9jczo6isZbo2YY9HBCOeI mnI79hfsFFFUX+2sYBKlu+q5qv0N5tx4HLs+9Mqxx6CkWG6ubL0Awtum0DsvgkAuOe/U dWJQ== X-Forwarded-Encrypted: i=1; AJvYcCUzJoFLmJEsXB5+SsgdhjQKUgmWN9sfduDUwiZ+AH26LdXxD+ONhp257B0OVtMg0TwK1ahnldZhol42HvBTFnZNqw==@lists.infradead.org, AJvYcCX8KglKH/zqn6eeAOIfvDwklZBKiCAP2vl0g2AwnG2v6ELmouerksBodIiF+lagi7mQNOYy3yBFrqAoH654ZhSp@lists.infradead.org X-Gm-Message-State: AOJu0YwPRcbFQRSqeXVERE+2aRozMHtjf+hQioAgIa/HBaVEMmjk7m7B JkQA/Xw9PWnfLqxl0lVY99hMIHaHYtoe0ilDxbHNjNDvpae71aoB X-Google-Smtp-Source: AGHT+IHNhW+4AL/vtYy1m5e9sT5r7EuBt4u4EKhoJsDLpUAw8CxbrKpERnJGGfRriLcOhMS1mDwiQg== X-Received: by 2002:a05:6e02:2141:b0:39f:7020:6a13 with SMTP id e9e14a558f8ab-3a04f08000amr78154825ab.6.1725727575579; Sat, 07 Sep 2024 09:46:15 -0700 (PDT) Received: from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7d825ab14b0sm1193498a12.89.2024.09.07.09.46.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Sep 2024 09:46:15 -0700 (PDT) Date: Sun, 8 Sep 2024 01:46:13 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Riyan Dhiman Cc: jim2101024@gmail.com, nsaenz@kernel.org, lorian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH next V2] PCI: brmstb: Fix type mismatch for num_inbound_wins in brcm_pcie_get_inbound_wins Message-ID: <20240907164613.GA183432@rocinante> References: <20240907160926.39556-1-riyandhiman14@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240907160926.39556-1-riyandhiman14@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240907_094617_389388_5B4EAB2F X-CRM114-Status: UNSURE ( 9.06 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, > Change num_inbound_wins from u8 to int to correctly handle > potential negative error codes returned by brcm_pcie_get_inbound_wins(). > The u8 type was inappropriate for capturing the function's return value, > which can include error codes. I squashed with the current code on the controller/brcmstb branch, see: - https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/brcmstb&id=ae6476c6de187bea90c729e3e0188143300fa671 And credited you via the Co-developed-by tag such that you get credit for fixing this issue. Thank you, by the way. There is no Fixes: tag as this code is not yet merged into the mainline. Krzysztof