From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A641EB64CD for ; Sat, 7 Sep 2024 16:57:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7OEjKisGyZpikcENOe0EKCmxLKuxWqz4sfdKvQEqRUA=; b=obXti+K+E/Irtl15iVm/YhkDwL HjPA4JIGSeKScq8e7AmuTCzhBLfcDNnFY4axr1EK2vzqbmaSP4am82PbxhnIGSTOk7Iu1pFfFCiHh TQQgjsqbEV9CNwHNxNjujTPgOcN8/hOKf6V5k29tZpcxIvOartfSow1myD6NSFxpOopPucBC80kLz 5OvQhdmX6HjVutOCsQEXULbrhALwkTOGbM8H8m/8bQZ9/dozR6YgneU6QvPIYqrDx9KJWCPC4uHle z9d2eWVqDv6RzwfoUUcr76isz+bpzceAul1AUAIXIFNhfj90RRcbNcuDSzJcCqURToequeWrFevZW ivoYLPzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smykO-0000000FKvE-3c67; Sat, 07 Sep 2024 16:57:16 +0000 Received: from mail-pg1-f182.google.com ([209.85.215.182]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smyjO-0000000FKl1-2Jrx; Sat, 07 Sep 2024 16:56:15 +0000 Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-7ae3d7222d4so2588944a12.3; Sat, 07 Sep 2024 09:56:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725728173; x=1726332973; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7OEjKisGyZpikcENOe0EKCmxLKuxWqz4sfdKvQEqRUA=; b=HCVBJlkoRYAxrYhPMYiLlJoYHo5olY4fIUhr5dd8jtITiqjZON3S18q8Mab8m4xPyP 0Q0XcY7CQAAdoV7uOEfASorO7FEKM8k5IUec2Xr+3d9vRu7q/0sQjQV30eaomBLDBQZK q4tV0ldFd+tAV+B+1w4EXXWAkGQelEmvn/LhxDO/Tb1wMmnmsTO8wPnSOX0TtY52QAFC P7MvHwvcN5x5RMSVNQymZI4kcVEfLA/Fa7dKjFzFwLui61HQH+dGpyd/jH64nM+eIIRk LF+byRIDTdQZYIh69mqP6+L9tYj5rocRiIbhF0iURHCdpB6UIcAtQbxx8otiB9WrpV2t wvgg== X-Forwarded-Encrypted: i=1; AJvYcCW/kXxjYxmegiH5GfuN30yUza0jt4igdwGcFkUBYBZJnui+esEnOb7eEPL/jvIorjUs3cNZY8AKSq3D3dLvOZEaeA==@lists.infradead.org, AJvYcCX4ankmRVPR52nvWcKIZGebxac3BEV3GGMjF3oG4wdHvTwyGSL7Qf1h9Kkv+y97JjtYHmbXmZQ0IiTRKyMhm1lo@lists.infradead.org X-Gm-Message-State: AOJu0YxYUiMzPXfM/6m257l4na6ua3TBnsOkcIZzPNzdq6AmCYWBnf/C GSzUSRkhe3oR6GMDjs0L467iPhvF05zBwBZm4d9hhjd9u64TybFy X-Google-Smtp-Source: AGHT+IFhnEfqx9zlWtZDUEoXKA5kpIizfxwG/lM8NfgGOt5YnZlGPstyfe4XCWn8XKWtfokoFsEJlQ== X-Received: by 2002:a05:6a21:9201:b0:1cf:2d2f:3749 with SMTP id adf61e73a8af0-1cf2d2f3849mr2738865637.32.1725728173380; Sat, 07 Sep 2024 09:56:13 -0700 (PDT) Received: from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7d823736c78sm1029199a12.3.2024.09.07.09.56.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Sep 2024 09:56:12 -0700 (PDT) Date: Sun, 8 Sep 2024 01:56:11 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Riyan Dhiman Cc: jim2101024@gmail.com, nsaenz@kernel.org, florian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH next V2] PCI: brmstb: Fix type mismatch for num_inbound_wins in brcm_pcie_get_inbound_wins Message-ID: <20240907165611.GA238693@rocinante> References: <20240907160926.39556-1-riyandhiman14@gmail.com> <20240907164613.GA183432@rocinante> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240907164613.GA183432@rocinante> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240907_095614_617585_37D453D9 X-CRM114-Status: GOOD ( 12.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, > > Change num_inbound_wins from u8 to int to correctly handle > > potential negative error codes returned by brcm_pcie_get_inbound_wins(). > > The u8 type was inappropriate for capturing the function's return value, > > which can include error codes. > > I squashed with the current code on the controller/brcmstb branch, see: > > - https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/brcmstb&id=ae6476c6de187bea90c729e3e0188143300fa671 > > And credited you via the Co-developed-by tag such that you get credit for > fixing this issue. Thank you, by the way. > > There is no Fixes: tag as this code is not yet merged into the mainline. For the record, I would prefer if we went with Florian's first recommendation per the following message: - https://lore.kernel.org/linux-pci/159c5fcf-709d-42ba-8d45-a70b109fe261@broadcom.com To clearly separate errors returned from the value being updated. Albeit, this is fine too, especially as Jim expressed no opinion either way regarding his preference. Krzysztof