Re: [PATCH 1/3] ARM: dts: imx6qdl-apalis: Update audio card name

Krzysztof Kozlowski
2024-09-09T17:46:14Z

On 09/09/2024 14:54, Francesco Dolcini wrote:
> Hello Krzysztof,
> thanks for the review/feedback.
>
> On Mon, Sep 09, 2024 at 02:09:11PM +0200, Krzysztof Kozlowski wrote:
>> On 09/09/2024 13:49, Hiago De Franco wrote:
>>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
>>> index edf55760a5c1..1c72da417011 100644
>>> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
>>> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
>>> @@ -191,7 +191,7 @@ sound {
>>> "MIC_IN", "Mic Jack",
>>> "Mic Jack", "Mic Bias",
>>> "Headphone Jack", "HP_OUT";
>>> - model = "imx6q-apalis-sgtl5000";
>>> + model = "apalis-imx6";
>>
>> Doesn't this break all the users? E.g. ALSA UCM and whatever
>> user-space-parsing stuff you have?
>
> I am not sure about "all" users, but for sure it's a breaking change.
> There is no ALSA UCM for this board (and also not for the other twos in
> this series), we just worked on it and we thought that if we want to do
> such a change the moment is now.
>
> What should we do?

For me is enough to explain in commit msg such expected (or lack of it)
impact.

Best regards,
Krzysztof