From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BA26ECE57E for ; Mon, 9 Sep 2024 14:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QnSXas7Kyj7p0Fu4r085XlTcEZ0B9CQA226oYcBvoRs=; b=AFuG7GBYgpI1ZZH54dD9BTV17q G99IvLD9EnYZWtO59p99kaykyHf6xycqZmZV/EPAkpGGgDTnbp9PY2INdmm5/H7DcVIuYOGkbEYPm Rb9lIdL5UgVfvGiSmNFZ5q33+0V8J7x5UO1WMiC2zGQ5uO93fUnrpI1e/HDGLJKSeMGqVEHC3tdna kcOkAdwqWRyHD+yY/DcVontGCudLhdPxtkacP35US4r3p54DchrKIrmUVphbHhe4BdFkENHVaaDf5 e/2XqppFZQVFxGduuO0r6tfdv+ACBg0BhR86VnO0HlbWMLtPj3mSeuUBZjf/2qlqjx58JjvKEJ74n m+/0VHlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1snfJd-00000002GVc-11rI; Mon, 09 Sep 2024 14:24:29 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1snfIa-00000002GHd-3xv2; Mon, 09 Sep 2024 14:23:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A9D6C5C0162; Mon, 9 Sep 2024 14:23:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 393C7C4CEC5; Mon, 9 Sep 2024 14:23:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725891803; bh=kQNUgMMqW2iwr2oAKBhQG32X6tXltITcAFqjMRNSyXY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dl4odoGPDk3MUUCdQbLXfEPlxfKbjDQqtUOJTe8U98J/G9P2r8gXGTZXfSYYTsL3N cAdEhvX1DpuXRcPSap7JPkXhorFohALU/HXJuz2bPHMhc4Ad46QelmSa+7TyHlarVY kog9TVkgf9YPD1EGbID8ky1iZlPi0PvOAv3zVAu2wfcICLivIuJzbNC9J4C7Od0qRj xZScqLoBUTWa+PO35n8Zo0U9L+K7jNV7tw+hiOoSNBM4Z3nCUzg7zu5a6qbXKvfyx+ /4cUvFwNs5G/qVka1SseRhMSXn21yUTPzVzILhqjeVPuTUiDLAVyyTufxQinQ0n5+x juKE6cM8j8x4w== Date: Mon, 9 Sep 2024 15:23:18 +0100 From: Simon Horman To: Marc Kleine-Budde Cc: kernel@pengutronix.de, Vincent Mailhol , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heiko Stuebner , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] can: rockchip_canfd: rkcanfd_timestamp_init(): fix 64 bit division on 32 bit platforms Message-ID: <20240909142318.GW2097826@kernel.org> References: <20240909-can-rockchip_canfd-fix-64-bit-division-v1-1-2748d9422b00@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240909-can-rockchip_canfd-fix-64-bit-division-v1-1-2748d9422b00@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240909_072325_070271_8AB91355 X-CRM114-Status: GOOD ( 12.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 09, 2024 at 08:21:49AM +0200, Marc Kleine-Budde wrote: > On some 32-bit platforms (at least on parisc), the compiler generates > a call to __divdi3() from the u32 by 3 division in > rkcanfd_timestamp_init(), which results in the following linker > error: > > | ERROR: modpost: "__divdi3" [drivers/net/can/rockchip/rockchip_canfd.ko] undefined! > > As this code doesn't run in the hot path, a 64 bit by 32 bit division > is OK, even on 32 bit platforms. Use an explicit call to div_u64() to > fix linking. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202409072304.lCQWyNLU-lkp@intel.com/ > Signed-off-by: Marc Kleine-Budde Reviewed-by: Simon Horman