From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 113A6EB64DE for ; Tue, 10 Sep 2024 14:41:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fsILWgbWxswwNDq4qjA+5GO3RoSLBddo4AJ15a9w4rA=; b=1ivtR54CzTnO8x340lkyWrRuZ4 WZ6vgZeWljAJKxJ4xZmzFtlGQDrlc00eKqMjrwS1fKQuyO6CjzZra+QAnkE6d2BpXOCgE/6n+S+/t IUvReCPWtPIwmugYRl2FO6ubi1xnB5nz8fZJ21+SMloC1Y7CEm0SVlcaex7kZSgl1govFkKgbu19d qDyKUEmfG5Q2r1MYyuPQ7HQalVNBqDbNB/o3YCyxoPIGU6XqeaM82e66XF76ejYLEWqhHfaCfoLgj EUGxAuUDr7bEg4POh/cNjyR2ri+n2PZlViUTQf09xRcGatyeJe7vtOh+WOwU2IqXYIBe+rEG8EevB imbMf9jA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1so23D-00000005uYe-23BD; Tue, 10 Sep 2024 14:41:03 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1so22A-00000005u5e-2wr0 for linux-arm-kernel@lists.infradead.org; Tue, 10 Sep 2024 14:40:00 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 529EB5C01FE; Tue, 10 Sep 2024 14:39:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24AD2C4CEC3; Tue, 10 Sep 2024 14:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725979197; bh=t18TnYBLL1+l4katEmWAhTGQvY0YNQUsSAjgHtvdg+M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gV5P60fLDueL+Cg/li3w1huRpA96e9WlfpkID0g4dppLq1NnQErcfGFd6nWTQMuDh GQWv/1kXn+nmH5CTtX9fWNSC4q15oxBs/lGPwjgOhlF9+tOuBI980tR0dD2+TrjG9k MaiWXEdEvicJ/2aD6lT3NOr1Kj8ZaaY4yjElFRG6p2S3+mQiJISr87hrVRYjFK35II kMUxLr+vRkCZwWhfpmedapOETaTF/XHGsbaHN5kfbnLndAuBppOnaUCN0cB60V55ua kO6iEMGJ0QGSqzUNl1ZyaxHJ2LjFZYkbfEbZBhfV+2NXigsMwuabFiapCZxkIzJCQm w+ZD9mzqDep3A== Date: Tue, 10 Sep 2024 07:39:56 -0700 From: Jakub Kicinski To: Sean Anderson Cc: Radhey Shyam Pandey , "David S . Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, Michal Simek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Chiu , Daniel Borkmann Subject: Re: [PATCH net v2] net: xilinx: axienet: Fix packet counting Message-ID: <20240910073956.53278ffe@kernel.org> In-Reply-To: <318a13f6-da2d-4ba4-a51c-2f8444444bbf@linux.dev> References: <20240906164227.505984-1-sean.anderson@linux.dev> <20240909180013.4e064fd5@kernel.org> <318a13f6-da2d-4ba4-a51c-2f8444444bbf@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240910_073958_841837_637F0833 X-CRM114-Status: GOOD ( 12.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 10 Sep 2024 10:24:36 -0400 Sean Anderson wrote: > > why are you doing this? To make sure drivers doesn't complete more > > than "budget" Tx skbs? The budget is really for Rx, for Tx you can > > use a reasonable fixed value, independent of what budget core > > passes in, e.g. 128. See: > > https://www.kernel.org/doc/html/next/networking/napi.html#datapath-api > > I read this but it was unclear to me because it seems oriented towards > "combined" NAPI instances, while we have separate instances for RX and > TX. So even for TX-only instances, we can ignore budget? Yes, combined or dedicated it should still reap completions regardless of budget. > > Moving this chunk into axienet_free_tx_chain() is a noop, right? > > Please avoid code cleanups in fixes. > > The relevant variable (number of descriptors handled) is no longer > returned to axienet_tx_poll, so it can't update the current descriptor > properly. Got it, worth mentioning in the commit msg.