From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDDCBECE582 for ; Tue, 10 Sep 2024 09:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JSnxRe3fyzrwkDmIDASvcX9dIOZrTkB16272RgaGykc=; b=zqTciHMA0j98VR6s6rlDsHKEWZ 4i0vhGbM6qUAXNglDvIcVK5pCvC1DeF9fJfENpdHFdc0UhrnzEIuPWeZBecc5PchG0zEu3Eaoj3TO zldfXWDjfvij4dUw1JnBG7cNmv42dc2wQpabrZ1F9t6fM03R9V7j+gUCdM/WagJQxogqKnyowX9pW cCRmrUBl//prFy50N6GD2oZ/1yl57dCz1jKrza2nSFFLLpImledngGQPOby9ZtGMPG3dngEz5S+fs trwWBxROHy5AbKWcej+7fekfbibAzriIbTElh1CK37/QOXkWiJVCIgy2GuFeNfREUHH4pT2k6tOtk 0oFkPRpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1snxUX-00000005673-0oeg; Tue, 10 Sep 2024 09:48:57 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1snxTV-000000055yM-16hS for linux-arm-kernel@lists.infradead.org; Tue, 10 Sep 2024 09:47:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id DFB48A44434; Tue, 10 Sep 2024 09:47:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BA79C4CECC; Tue, 10 Sep 2024 09:47:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725961672; bh=32ZjKnbISZ5HfC13g6akEMY5BzbXnZdxgkLbbXDzTxA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IETI+2t329OYBYsMx1EZRAhMLEl1dL0aBVCOsZTV0f09eGVZ/LJ5bAkZ5dRqAmroq yOC6nmxEhzLeYSi/DtBVQe4rUKffMUVMRs54tXxw2b99SYx+aEFm9DuvapaNCEAW0L TkiYIkSse2yxbSDzKajHW4sW3tDGGmqO7PG0Pi+azRA+SCA03dxFmWxnvtfBqGyE2F uPN2EaXD62V0D1A50pHQaCQOdaf0UBfriIa/qUkUXmTfPkDjoMovh9z99MqkeMH952 CMe00OuUiS8AV3M+KG7VpRBsgly5oa9hqiyONnko9RK4tQ2MTc4cECnAcr10c0XUwh lSSYvMAMSadGg== Date: Tue, 10 Sep 2024 10:47:46 +0100 From: Will Deacon To: Marc Zyngier Cc: Catalin Marinas , Anastasia Belova , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, stable@vger.kernel.org Subject: Re: [PATCH v2] arm64: KVM: define ESR_ELx_EC_* constants as UL Message-ID: <20240910094746.GA20813@willie-the-truck> References: <865xr5856r.wl-maz@kernel.org> <20240910085016.32120-1-abelova@astralinux.ru> <86v7z37u5a.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86v7z37u5a.wl-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240910_024753_385605_8368F0B1 X-CRM114-Status: GOOD ( 18.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 10, 2024 at 10:08:49AM +0100, Marc Zyngier wrote: > On Tue, 10 Sep 2024 09:50:16 +0100, > Anastasia Belova wrote: > > > > Add explicit casting to prevent expantion of 32th bit of > > u32 into highest half of u64 in several places. > > > > For example, in inject_abt64: > > ESR_ELx_EC_DABT_LOW << ESR_ELx_EC_SHIFT = 0x24 << 26. > > This operation's result is int with 1 in 32th bit. > > While casting this value into u64 (esr is u64) 1 > > fills 32 highest bits. > > > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > > > Fixes: aa8eff9bfbd5 ("arm64: KVM: fault injection into a guest") > > Signed-off-by: Anastasia Belova > > nit: the subject line is misleading, as this doesn't only affect KVM, > but the whole of the arm64 port (the exception classes form a generic > architectural construct). Weird, this v2 landed in my spam for some reason. > This also probably deserve a Cc stable. > > Will, Catalin: I'm happy to queue this in the KVM tree, but if you are > taking it directly: > > Acked-by: Marc Zyngier I can take it via arm64. I assume it's ok to land in v6.12 (with the cc: stable), or is there an urgency to landing this in v6.11? It looks it was found using verification tools, rather than because of an actual issue affecting users. Will