From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68989ECE582 for ; Tue, 10 Sep 2024 17:03:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pBskbk3QBU0YMtrU99WpBguxflCzi8adsZB8njQ7nhU=; b=zeepTXTVmTXMV6cU8MbFa9f3AK 6K3bQw4zIfaCsemqMGfixljcZmFPG18qmGV0kNVotpWXz3A5RDHGgvJR72VSKAacLmOT50ZiB+ZSi ool3P6wGaj0PcLhbxtNOpdtDH7Klw4iFcijGjxOV3b2dFsIhDDSzm9sB3+I8dlM++MFrl8D+gUjV9 UCKGH09XzY21GI1FdVFjBMrrAOlmih0j8CcP4NjgRjlS0QMmhiwi6bl9sV+AwDfk/BEBRfKn1MWUW sB4ULvgSdvS+xPhRX84D39DGOS8tvGVS/68jX9xfYD8kzCGDOoSSAdOBpGs1iWVt57v3p9jnlajBl YMiMlN+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1so4Gz-00000006SIU-1eUD; Tue, 10 Sep 2024 17:03:25 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1so4Es-00000006RuO-0aYh for linux-arm-kernel@lists.infradead.org; Tue, 10 Sep 2024 17:01:16 +0000 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-205722ba00cso49817605ad.0 for ; Tue, 10 Sep 2024 10:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725987673; x=1726592473; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=pBskbk3QBU0YMtrU99WpBguxflCzi8adsZB8njQ7nhU=; b=q5etxkCQr44Njyg9Y7YwfK0M5BA2GpkbBeFFGBvE+4Jenvflcum2AR9G5igqHwYux+ 6OlJQkdMmT9Je35kUztT27lO+HfzoRJGT0ewz23lThTx21QXhLGO3oHHHXbDkySUSYzH vmJI+EnR6ERfKkxyFD9BT+7raPBhF0MvmodWwFh1mRrpsxzoT4UGjPIJ1aqeFhAL19QK 4weTXqoRORZcayDY7QER8OXmDoHNHieTms6lgSz99GPpOqzSx1u5G431QZlxwoMdc9Fm 4eCikcdAHEeDRJ7Q2CrC9Qo4pbQLn1ZdavjROwCBgsph4sVaZDD3LOcBXoL29d2JflDd gxyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725987673; x=1726592473; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pBskbk3QBU0YMtrU99WpBguxflCzi8adsZB8njQ7nhU=; b=m2Q6e1GgPW7goXeCzw/fa69wZpLzvayOFyMOCe721s814l/y1yNtPSR7r0A+YDOsVG 6VeooBXDvqYUIteiLXeUob5L0a/7KnzXx+wwZ62yHSuXYPVDyDmSPUAKnvFtLaG3whaE e4krhQ5/HodYjw8YO+dTUCTn08J4I/c5BIWcMImg8uptqnwU3hqToddWaAXSa6ilAg8c QUZUygd2pPdATORyn03LIatl5RLVPR3H6mAE8zoXVTli1kgevxhhYfJGn/KUpAbqaBVm Koff7rOng60sq97HC/UG8871g1luNgQ3hjAYEDcyuk+pdisMfNCejxAmqR2VTkkLTQT+ 5fCg== X-Forwarded-Encrypted: i=1; AJvYcCUeF8Xa4NvgE2f86j5KLWBD4NNXP6l3OUVzp6OMRiqjBvU7DQbveQjYNZ8wKZo2Ou3ZuWIel236I74euhCx3Mn6@lists.infradead.org X-Gm-Message-State: AOJu0YyWSfou30dywcdCpuA5W8JUez4gdAvNxrNVyVJQt63QqEeHKDJv x1vhsnQmVcOT96HefNttA/ock2QQyy8pvjr6i66h9fXWTUJSnsh0JUkNljAumA== X-Google-Smtp-Source: AGHT+IF/raqp+DCJypfwe5V7+Q+7qT8bMOaTzbFGyeYWrZCI1/k/X6tIvkrcWMVdJdlQehGHErlM4Q== X-Received: by 2002:a17:902:d2c9:b0:207:73f:59f3 with SMTP id d9443c01a7336-2074c681cecmr18549225ad.32.1725987672621; Tue, 10 Sep 2024 10:01:12 -0700 (PDT) Received: from thinkpad ([120.60.128.228]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710f1f469sm50762155ad.223.2024.09.10.10.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Sep 2024 10:01:12 -0700 (PDT) Date: Tue, 10 Sep 2024 22:30:52 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jingoo Han , Chuanhua Lei , Marek Vasut , Yoshihiro Shimoda , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, abel.vesa@linaro.org, johan+linaro@kernel.org, Shashank Babu Chinta Venkata Subject: Re: [PATCH v6 3/4] PCI: qcom: Add equalization settings for 16.0 GT/s Message-ID: <20240910170052.qorc7hedfy4oqzgt@thinkpad> References: <20240904-pci-qcom-gen4-stability-v6-0-ec39f7ae3f62@linaro.org> <20240904-pci-qcom-gen4-stability-v6-3-ec39f7ae3f62@linaro.org> <20240905152742.4llkcjvvu3klmo6j@thinkpad> <20240905173437.hm3hegv5zolaj7gj@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240910_100114_439515_72755BBB X-CRM114-Status: GOOD ( 24.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 06, 2024 at 08:49:03AM +0200, Johan Hovold wrote: > On Thu, Sep 05, 2024 at 11:04:37PM +0530, Manivannan Sadhasivam wrote: > > On Thu, Sep 05, 2024 at 06:27:36PM +0200, Johan Hovold wrote: > > > On Thu, Sep 05, 2024 at 08:57:42PM +0530, Manivannan Sadhasivam wrote: > > > > > Perhaps we can just get rid of the Kconfig entry and build it by default for > > > > both RC and EP drivers? I don't see a value in building it as a separate module. > > > > And we may also move more common code in the future. > > > > > > It is already built by default for both drivers. I'm not sure what > > > you're suggesting here. > > > > Right now it is selected by both drivers using a Kconfig symbol. But I'm > > thinking of building it by default as below: > > > > -obj-$(CONFIG_PCIE_QCOM) += pcie-qcom.o > > -obj-$(CONFIG_PCIE_QCOM_EP) += pcie-qcom-ep.o > > +obj-$(CONFIG_PCIE_QCOM) += pcie-qcom.o pcie-qcom-common.o > > +obj-$(CONFIG_PCIE_QCOM_EP) += pcie-qcom-ep.o pcie-qcom-common.o > > > > A separate Kconfig symbol is not really needed here as this file contains common > > code required by both the drivers. > > But the separate Kconfig symbol will only be enabled via either PCI > driver's option (e.g. can't be enabled on its own). > True. But since the common file is required by both drivers, I thought of just building it by default. But looking at your below reply, it won't be possible. > I'm also not sure if the above works if you build one driver as a module > and the other into the kernel (yes, I still intend to resubmit my patch > for making the rc driver modular). > Hmm, I thought you dropped that patch ;) Anyway, if that happens, it will be a problem. I'll keep it as it is. - Mani -- மணிவண்ணன் சதாசிவம்