From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42C4CEE01FA for ; Wed, 11 Sep 2024 01:59:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YJAoYGD0qRUbAt3k0+ZgnpX7Pslfei5VwHT6KgpCYNM=; b=VBVXFN3rteXQ3AOeqvnbECv2Uh F64dZF/bTzq+GIbTH59L5/FUUVFMI2XUVIpQLJRuPpIFILVsXVMzowSYlGsUntoKqTYvAAiG7OJe/ ZaiRpS/K5Nl4IRKfEgCorfNojEINH+vJ9IZo7XDZBzUa5gGgkHbjLnskqcB2ecz1nxF4a7aI8nm+m KPIJDAcWO+wWEwTiAixzmub+r14LV9uB2Z1FLCJslgcAToJ5fQpzzw9VW+i9dq4lSVvv5fz+P0URv ed35yEa5jGgwsip/7Y+X+Y7ePtJ29H2e/mHtGcg5abplENyRQ/ECbiGo/K2HvkXIM5uCZNSR7DgCe lBbXwXbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soCdU-00000007lVw-2QxC; Wed, 11 Sep 2024 01:59:12 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1soCcP-00000007lLN-09s2 for linux-arm-kernel@lists.infradead.org; Wed, 11 Sep 2024 01:58:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 794905C02F1; Wed, 11 Sep 2024 01:58:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 037FDC4CEC3; Wed, 11 Sep 2024 01:58:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726019883; bh=zkdw2rH+TkLEzbIu1yQDGVOw/xkWDfXnjb56Nw2onZU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GzMCClfAAlELgdZ3S3PJjAKBn0cPA5Pi6yy8hF0jcKIb3RwWk2doKOWnHTuAJpah2 Z6fmYFAgcpQ+CGha9uG4vFKmEPX6BXvjAfCtUNEsa+AmO99KfnbcLD+8Y0MR9oII6L lAR0R7pFhS9v2kdkJu8YYrEA5g8ffgvAGbXf2rSLoU2jtTeHF/Kt40cJVlmTih9LGI QeGac2Etm3Ed3apGcfU8/2Lj+xKg4FUXIwDlbwW3UoZPvHH+1/kJjSgVzwFD8yDGsr 9hZ94KEp/u/R1/r7OhIWvdo+Ky7Hx9IW5iUcPo11KeOYet2RB1k0mFjCHys7M7Pxxq Kdsy2aWYuNhyA== Date: Tue, 10 Sep 2024 18:58:01 -0700 From: Jakub Kicinski To: Sean Anderson Cc: Radhey Shyam Pandey , "David S . Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, Robert Hancock , linux-kernel@vger.kernel.org, Michal Simek , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net] net: xilinx: axienet: Schedule NAPI in two steps Message-ID: <20240910185801.42b7c17f@kernel.org> In-Reply-To: <20240909231904.1322387-1-sean.anderson@linux.dev> References: <20240909231904.1322387-1-sean.anderson@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240910_185805_155967_DD6FB8EF X-CRM114-Status: UNSURE ( 9.31 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 9 Sep 2024 19:19:04 -0400 Sean Anderson wrote: > Additionally, since we are running > in an IRQ context we can use the irqoff variant as well. The _irqoff variant is a bit of a minefield. It causes issues if kernel is built with forced IRQ threading. With datacenter NICs forced threading is never used so we look the other way. Since this is a fix and driver is embedded I reckon we should stick to __napi_schedule(). -- pw-bot: cr