* [PATCH 1/7] ARM: dts: amlogic: meson6: fix clk81 node name
2024-09-11 10:19 [PATCH 0/7] ARM: dts: amlogic: first easy dtbs fixes Neil Armstrong
@ 2024-09-11 10:19 ` Neil Armstrong
2024-09-11 10:19 ` [PATCH 2/7] ARM: dts: amlogic: meson8: fix soc thermal-zone " Neil Armstrong
` (6 subsequent siblings)
7 siblings, 0 replies; 18+ messages in thread
From: Neil Armstrong @ 2024-09-11 10:19 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl
Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
Neil Armstrong
Use the proper node name, fixing:
arch/arm/boot/dts/amlogic/meson6-atv1200.dtb: /: clk@0: 'anyOf' conditional failed, one must be fixed:
'reg' is a required property
'ranges' is a required property
from schema $id: http://devicetree.org/schemas/root-node.yaml#
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm/boot/dts/amlogic/meson6.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/amlogic/meson6.dtsi b/arch/arm/boot/dts/amlogic/meson6.dtsi
index 4716030a48d0..1c4ea7266f66 100644
--- a/arch/arm/boot/dts/amlogic/meson6.dtsi
+++ b/arch/arm/boot/dts/amlogic/meson6.dtsi
@@ -36,7 +36,7 @@ apb2: bus@d0000000 {
ranges = <0x0 0xd0000000 0x40000>;
};
- clk81: clk@0 {
+ clk81: clk81 {
#clock-cells = <0>;
compatible = "fixed-clock";
clock-frequency = <200000000>;
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 2/7] ARM: dts: amlogic: meson8: fix soc thermal-zone node name
2024-09-11 10:19 [PATCH 0/7] ARM: dts: amlogic: first easy dtbs fixes Neil Armstrong
2024-09-11 10:19 ` [PATCH 1/7] ARM: dts: amlogic: meson6: fix clk81 node name Neil Armstrong
@ 2024-09-11 10:19 ` Neil Armstrong
2024-09-15 19:02 ` Martin Blumenstingl
2024-09-11 10:19 ` [PATCH 3/7] ARM: dts: amlogic: meson8: fix ao_arc_sram " Neil Armstrong
` (5 subsequent siblings)
7 siblings, 1 reply; 18+ messages in thread
From: Neil Armstrong @ 2024-09-11 10:19 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl
Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
Neil Armstrong
Use proper name for the soc thermal, fixing:
thermal-zones: 'soc' does not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,10}-thermal$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml#
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm/boot/dts/amlogic/meson8.dtsi | 2 +-
arch/arm/boot/dts/amlogic/meson8b.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/amlogic/meson8.dtsi b/arch/arm/boot/dts/amlogic/meson8.dtsi
index f57be9ae150f..06174d8df789 100644
--- a/arch/arm/boot/dts/amlogic/meson8.dtsi
+++ b/arch/arm/boot/dts/amlogic/meson8.dtsi
@@ -196,7 +196,7 @@ power-firmware@4f00000 {
};
thermal-zones {
- soc {
+ soc-thermal {
polling-delay-passive = <250>; /* milliseconds */
polling-delay = <1000>; /* milliseconds */
thermal-sensors = <&thermal_sensor>;
diff --git a/arch/arm/boot/dts/amlogic/meson8b.dtsi b/arch/arm/boot/dts/amlogic/meson8b.dtsi
index 2d9d24d3a95d..a3669025d8da 100644
--- a/arch/arm/boot/dts/amlogic/meson8b.dtsi
+++ b/arch/arm/boot/dts/amlogic/meson8b.dtsi
@@ -173,7 +173,7 @@ hwrom@0 {
};
thermal-zones {
- soc {
+ soc-thermal {
polling-delay-passive = <250>; /* milliseconds */
polling-delay = <1000>; /* milliseconds */
thermal-sensors = <&thermal_sensor>;
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH 2/7] ARM: dts: amlogic: meson8: fix soc thermal-zone node name
2024-09-11 10:19 ` [PATCH 2/7] ARM: dts: amlogic: meson8: fix soc thermal-zone " Neil Armstrong
@ 2024-09-15 19:02 ` Martin Blumenstingl
0 siblings, 0 replies; 18+ messages in thread
From: Martin Blumenstingl @ 2024-09-15 19:02 UTC (permalink / raw)
To: Neil Armstrong
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, devicetree, linux-arm-kernel, linux-amlogic,
linux-kernel
On Wed, Sep 11, 2024 at 12:19 PM Neil Armstrong
<neil.armstrong@linaro.org> wrote:
>
> Use proper name for the soc thermal, fixing:
> thermal-zones: 'soc' does not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,10}-thermal$', 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml#
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 3/7] ARM: dts: amlogic: meson8: fix ao_arc_sram node name
2024-09-11 10:19 [PATCH 0/7] ARM: dts: amlogic: first easy dtbs fixes Neil Armstrong
2024-09-11 10:19 ` [PATCH 1/7] ARM: dts: amlogic: meson6: fix clk81 node name Neil Armstrong
2024-09-11 10:19 ` [PATCH 2/7] ARM: dts: amlogic: meson8: fix soc thermal-zone " Neil Armstrong
@ 2024-09-11 10:19 ` Neil Armstrong
2024-09-15 19:02 ` Martin Blumenstingl
2024-09-11 10:19 ` [PATCH 4/7] ARM: dts: amlogic: meson6: delete undocumented nodes Neil Armstrong
` (4 subsequent siblings)
7 siblings, 1 reply; 18+ messages in thread
From: Neil Armstrong @ 2024-09-11 10:19 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl
Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
Neil Armstrong
Use the proper node name for the sram, fixing:
sram@d9000000: 'ao-arc-sram@0' does not match any of the regexes: '^([a-z0-9]*-)?sram(-section)?@[a-f0-9]+$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/sram/sram.yaml#
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm/boot/dts/amlogic/meson8.dtsi | 2 +-
arch/arm/boot/dts/amlogic/meson8b.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/amlogic/meson8.dtsi b/arch/arm/boot/dts/amlogic/meson8.dtsi
index 06174d8df789..1023ff0a4f9f 100644
--- a/arch/arm/boot/dts/amlogic/meson8.dtsi
+++ b/arch/arm/boot/dts/amlogic/meson8.dtsi
@@ -589,7 +589,7 @@ mux {
};
&ahb_sram {
- ao_arc_sram: ao-arc-sram@0 {
+ ao_arc_sram: aoarc-sram@0 {
compatible = "amlogic,meson8-ao-arc-sram";
reg = <0x0 0x8000>;
pool;
diff --git a/arch/arm/boot/dts/amlogic/meson8b.dtsi b/arch/arm/boot/dts/amlogic/meson8b.dtsi
index a3669025d8da..641cd60781a3 100644
--- a/arch/arm/boot/dts/amlogic/meson8b.dtsi
+++ b/arch/arm/boot/dts/amlogic/meson8b.dtsi
@@ -535,7 +535,7 @@ mux {
};
&ahb_sram {
- ao_arc_sram: ao-arc-sram@0 {
+ ao_arc_sram: aoarc-sram@0 {
compatible = "amlogic,meson8b-ao-arc-sram";
reg = <0x0 0x8000>;
pool;
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH 3/7] ARM: dts: amlogic: meson8: fix ao_arc_sram node name
2024-09-11 10:19 ` [PATCH 3/7] ARM: dts: amlogic: meson8: fix ao_arc_sram " Neil Armstrong
@ 2024-09-15 19:02 ` Martin Blumenstingl
0 siblings, 0 replies; 18+ messages in thread
From: Martin Blumenstingl @ 2024-09-15 19:02 UTC (permalink / raw)
To: Neil Armstrong
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, devicetree, linux-arm-kernel, linux-amlogic,
linux-kernel
On Wed, Sep 11, 2024 at 12:19 PM Neil Armstrong
<neil.armstrong@linaro.org> wrote:
>
> Use the proper node name for the sram, fixing:
> sram@d9000000: 'ao-arc-sram@0' does not match any of the regexes: '^([a-z0-9]*-)?sram(-section)?@[a-f0-9]+$', 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/sram/sram.yaml#
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 4/7] ARM: dts: amlogic: meson6: delete undocumented nodes
2024-09-11 10:19 [PATCH 0/7] ARM: dts: amlogic: first easy dtbs fixes Neil Armstrong
` (2 preceding siblings ...)
2024-09-11 10:19 ` [PATCH 3/7] ARM: dts: amlogic: meson8: fix ao_arc_sram " Neil Armstrong
@ 2024-09-11 10:19 ` Neil Armstrong
2024-09-15 19:12 ` Martin Blumenstingl
2024-09-11 10:19 ` [PATCH 5/7] ARM: dts: amlogic: meson8b-odroidc1: fix invalid reset-gpio Neil Armstrong
` (3 subsequent siblings)
7 siblings, 1 reply; 18+ messages in thread
From: Neil Armstrong @ 2024-09-11 10:19 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl
Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
Neil Armstrong
Delete nodes in meson6.dtsi that are clearly undocumented & unused for meson6,
fixing the following check errors:
audio-controller@5400: compatible:0: 'amlogic,aiu' is not one of ['amlogic,aiu-gxbb', 'amlogic,aiu-gxl', 'amlogic,aiu-meson8', 'amlogic,aiu-meson8b']
from schema $id: http://devicetree.org/schemas/sound/amlogic,aiu.yaml#
audio-controller@5400: compatible: ['amlogic,aiu'] is too short
from schema $id: http://devicetree.org/schemas/sound/amlogic,aiu.yaml#
/soc/bus@c1100000/pwm@8550: failed to match any schema with compatible: ['amlogic,meson-pwm']
/soc/bus@c1100000/pwm@8650: failed to match any schema with compatible: ['amlogic,meson-pwm']
phy@8800: compatible: 'oneOf' conditional failed, one must be fixed:
['amlogic,meson-mx-usb2-phy'] is too short
'amlogic,meson-mx-usb2-phy' is not one of ['amlogic,meson8-usb2-phy', 'amlogic,meson8b-usb2-phy', 'amlogic,meson8m2-usb2-phy']
'amlogic,meson-gxbb-usb2-phy' was expected
from schema $id: http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml#
phy@8820: compatible: 'oneOf' conditional failed, one must be fixed:
['amlogic,meson-mx-usb2-phy'] is too short
'amlogic,meson-mx-usb2-phy' is not one of ['amlogic,meson8-usb2-phy', 'amlogic,meson8b-usb2-phy', 'amlogic,meson8m2-usb2-phy']
'amlogic,meson-gxbb-usb2-phy' was expected
from schema $id: http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml#
/soc/bus@c1100000/mmc@8c20: failed to match any schema with compatible: ['amlogic,meson-mx-sdio']
mmc@8e00: compatible:0: 'amlogic,meson-mx-sdhc' is not one of ['amlogic,meson8-sdhc', 'amlogic,meson8b-sdhc', 'amlogic,meson8m2-sdhc']
from schema $id: http://devicetree.org/schemas/mmc/amlogic,meson-mx-sdhc.yaml#
mmc@8e00: compatible: ['amlogic,meson-mx-sdhc'] is too short
from schema $id: http://devicetree.org/schemas/mmc/amlogic,meson-mx-sdhc.yaml#
remoteproc@1c: compatible:0: 'amlogic,meson-mx-ao-arc' is not one of ['amlogic,meson8-ao-arc', 'amlogic,meson8b-ao-arc']
from schema $id: http://devicetree.org/schemas/remoteproc/amlogic,meson-mx-ao-arc.yaml#
remoteproc@1c: compatible: ['amlogic,meson-mx-ao-arc'] is too short
from schema $id: http://devicetree.org/schemas/remoteproc/amlogic,meson-mx-ao-arc.yaml#
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm/boot/dts/amlogic/meson6.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/amlogic/meson6.dtsi b/arch/arm/boot/dts/amlogic/meson6.dtsi
index 1c4ea7266f66..8952c086d069 100644
--- a/arch/arm/boot/dts/amlogic/meson6.dtsi
+++ b/arch/arm/boot/dts/amlogic/meson6.dtsi
@@ -43,6 +43,10 @@ clk81: clk81 {
};
}; /* end of / */
+/delete-node/ &aiu;
+
+/delete-node/ &ao_arc_rproc;
+
&efuse {
status = "disabled";
};
@@ -71,3 +75,15 @@ &uart_C {
clocks = <&xtal>, <&clk81>, <&clk81>;
clock-names = "xtal", "pclk", "baud";
};
+
+/delete-node/ &pwm_ab;
+/delete-node/ &pwm_cd;
+
+/delete-node/ &sdhc;
+/delete-node/ &sdio;
+
+/delete-node/ &usb0;
+/delete-node/ &usb1;
+
+/delete-node/ &usb0_phy;
+/delete-node/ &usb1_phy;
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH 4/7] ARM: dts: amlogic: meson6: delete undocumented nodes
2024-09-11 10:19 ` [PATCH 4/7] ARM: dts: amlogic: meson6: delete undocumented nodes Neil Armstrong
@ 2024-09-15 19:12 ` Martin Blumenstingl
2024-09-16 5:57 ` Christian Hewitt
0 siblings, 1 reply; 18+ messages in thread
From: Martin Blumenstingl @ 2024-09-15 19:12 UTC (permalink / raw)
To: Neil Armstrong
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, devicetree, linux-arm-kernel, linux-amlogic,
linux-kernel
Hi Neil,
On Wed, Sep 11, 2024 at 12:19 PM Neil Armstrong
<neil.armstrong@linaro.org> wrote:
>
> Delete nodes in meson6.dtsi that are clearly undocumented & unused for meson6,
> fixing the following check errors:
> audio-controller@5400: compatible:0: 'amlogic,aiu' is not one of ['amlogic,aiu-gxbb', 'amlogic,aiu-gxl', 'amlogic,aiu-meson8', 'amlogic,aiu-meson8b']
> from schema $id: http://devicetree.org/schemas/sound/amlogic,aiu.yaml#
> audio-controller@5400: compatible: ['amlogic,aiu'] is too short
> from schema $id: http://devicetree.org/schemas/sound/amlogic,aiu.yaml#
> /soc/bus@c1100000/pwm@8550: failed to match any schema with compatible: ['amlogic,meson-pwm']
> /soc/bus@c1100000/pwm@8650: failed to match any schema with compatible: ['amlogic,meson-pwm']
> phy@8800: compatible: 'oneOf' conditional failed, one must be fixed:
> ['amlogic,meson-mx-usb2-phy'] is too short
> 'amlogic,meson-mx-usb2-phy' is not one of ['amlogic,meson8-usb2-phy', 'amlogic,meson8b-usb2-phy', 'amlogic,meson8m2-usb2-phy']
> 'amlogic,meson-gxbb-usb2-phy' was expected
> from schema $id: http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml#
> phy@8820: compatible: 'oneOf' conditional failed, one must be fixed:
> ['amlogic,meson-mx-usb2-phy'] is too short
> 'amlogic,meson-mx-usb2-phy' is not one of ['amlogic,meson8-usb2-phy', 'amlogic,meson8b-usb2-phy', 'amlogic,meson8m2-usb2-phy']
> 'amlogic,meson-gxbb-usb2-phy' was expected
> from schema $id: http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml#
> /soc/bus@c1100000/mmc@8c20: failed to match any schema with compatible: ['amlogic,meson-mx-sdio']
> mmc@8e00: compatible:0: 'amlogic,meson-mx-sdhc' is not one of ['amlogic,meson8-sdhc', 'amlogic,meson8b-sdhc', 'amlogic,meson8m2-sdhc']
> from schema $id: http://devicetree.org/schemas/mmc/amlogic,meson-mx-sdhc.yaml#
> mmc@8e00: compatible: ['amlogic,meson-mx-sdhc'] is too short
> from schema $id: http://devicetree.org/schemas/mmc/amlogic,meson-mx-sdhc.yaml#
> remoteproc@1c: compatible:0: 'amlogic,meson-mx-ao-arc' is not one of ['amlogic,meson8-ao-arc', 'amlogic,meson8b-ao-arc']
> from schema $id: http://devicetree.org/schemas/remoteproc/amlogic,meson-mx-ao-arc.yaml#
> remoteproc@1c: compatible: ['amlogic,meson-mx-ao-arc'] is too short
> from schema $id: http://devicetree.org/schemas/remoteproc/amlogic,meson-mx-ao-arc.yaml#
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Generally I'm fine with this. I'm wondering if we should go one step
further by decommissioning Meson6 support?
To be specific here, I'm thinking of removing MACH_MESON6 from
arch/arm/mach-meson/Kconfig and deleting meson6{.dtsi,-atv1200.dts}
I don't have any boards with Meson6 SoC, there's no upstream GPIO,
pinctrl, clock, MMC, <you name it> driver for that SoC either.
So all we have upstream is the ability to boot to initramfs and use
serial console(s).
If someone is interested in Meson6 support they should bring it back
along with a few more patches for upstream support of further
peripherals.
Best regards,
Martin
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 4/7] ARM: dts: amlogic: meson6: delete undocumented nodes
2024-09-15 19:12 ` Martin Blumenstingl
@ 2024-09-16 5:57 ` Christian Hewitt
2024-09-16 7:22 ` Neil Armstrong
0 siblings, 1 reply; 18+ messages in thread
From: Christian Hewitt @ 2024-09-16 5:57 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: Neil Armstrong, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Kevin Hilman, Jerome Brunet, devicetree, linux-arm-kernel, AML,
LKML
> On 15 Sep 2024, at 11:12 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
>
> Hi Neil,
>
> On Wed, Sep 11, 2024 at 12:19 PM Neil Armstrong
> <neil.armstrong@linaro.org> wrote:
>>
>> Delete nodes in meson6.dtsi that are clearly undocumented & unused for meson6,
>> fixing the following check errors:
>> audio-controller@5400: compatible:0: 'amlogic,aiu' is not one of ['amlogic,aiu-gxbb', 'amlogic,aiu-gxl', 'amlogic,aiu-meson8', 'amlogic,aiu-meson8b']
>> from schema $id: http://devicetree.org/schemas/sound/amlogic,aiu.yaml#
>> audio-controller@5400: compatible: ['amlogic,aiu'] is too short
>> from schema $id: http://devicetree.org/schemas/sound/amlogic,aiu.yaml#
>> /soc/bus@c1100000/pwm@8550: failed to match any schema with compatible: ['amlogic,meson-pwm']
>> /soc/bus@c1100000/pwm@8650: failed to match any schema with compatible: ['amlogic,meson-pwm']
>> phy@8800: compatible: 'oneOf' conditional failed, one must be fixed:
>> ['amlogic,meson-mx-usb2-phy'] is too short
>> 'amlogic,meson-mx-usb2-phy' is not one of ['amlogic,meson8-usb2-phy', 'amlogic,meson8b-usb2-phy', 'amlogic,meson8m2-usb2-phy']
>> 'amlogic,meson-gxbb-usb2-phy' was expected
>> from schema $id: http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml#
>> phy@8820: compatible: 'oneOf' conditional failed, one must be fixed:
>> ['amlogic,meson-mx-usb2-phy'] is too short
>> 'amlogic,meson-mx-usb2-phy' is not one of ['amlogic,meson8-usb2-phy', 'amlogic,meson8b-usb2-phy', 'amlogic,meson8m2-usb2-phy']
>> 'amlogic,meson-gxbb-usb2-phy' was expected
>> from schema $id: http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml#
>> /soc/bus@c1100000/mmc@8c20: failed to match any schema with compatible: ['amlogic,meson-mx-sdio']
>> mmc@8e00: compatible:0: 'amlogic,meson-mx-sdhc' is not one of ['amlogic,meson8-sdhc', 'amlogic,meson8b-sdhc', 'amlogic,meson8m2-sdhc']
>> from schema $id: http://devicetree.org/schemas/mmc/amlogic,meson-mx-sdhc.yaml#
>> mmc@8e00: compatible: ['amlogic,meson-mx-sdhc'] is too short
>> from schema $id: http://devicetree.org/schemas/mmc/amlogic,meson-mx-sdhc.yaml#
>> remoteproc@1c: compatible:0: 'amlogic,meson-mx-ao-arc' is not one of ['amlogic,meson8-ao-arc', 'amlogic,meson8b-ao-arc']
>> from schema $id: http://devicetree.org/schemas/remoteproc/amlogic,meson-mx-ao-arc.yaml#
>> remoteproc@1c: compatible: ['amlogic,meson-mx-ao-arc'] is too short
>> from schema $id: http://devicetree.org/schemas/remoteproc/amlogic,meson-mx-ao-arc.yaml#
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> Generally I'm fine with this. I'm wondering if we should go one step
> further by decommissioning Meson6 support?
> To be specific here, I'm thinking of removing MACH_MESON6 from
> arch/arm/mach-meson/Kconfig and deleting meson6{.dtsi,-atv1200.dts}
>
> I don't have any boards with Meson6 SoC, there's no upstream GPIO,
> pinctrl, clock, MMC, <you name it> driver for that SoC either.
> So all we have upstream is the ability to boot to initramfs and use
> serial console(s).
> If someone is interested in Meson6 support they should bring it back
> along with a few more patches for upstream support of further
> peripherals.
I think that’s a sensible move. LibreELEC was one of the few distros
that supported Meson6 hardware in the past (via the vendor kernel)
but we ended support in 2018. Meson6 devices are mostly/all? cheap
Android boxes dating from 2011-2013 and these have either been been
discarded by users through upgrades or the boxes died long ago. There
is still community interest in supporting Meson8 boards (the 8x core
devices are used for retro-gaming) but not the earlier Meson6 ones.
Christian
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 4/7] ARM: dts: amlogic: meson6: delete undocumented nodes
2024-09-16 5:57 ` Christian Hewitt
@ 2024-09-16 7:22 ` Neil Armstrong
0 siblings, 0 replies; 18+ messages in thread
From: Neil Armstrong @ 2024-09-16 7:22 UTC (permalink / raw)
To: Christian Hewitt, Martin Blumenstingl
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, devicetree, linux-arm-kernel, AML, LKML
On 16/09/2024 07:57, Christian Hewitt wrote:
>> On 15 Sep 2024, at 11:12 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
>>
>> Hi Neil,
>>
>> On Wed, Sep 11, 2024 at 12:19 PM Neil Armstrong
>> <neil.armstrong@linaro.org> wrote:
>>>
>>> Delete nodes in meson6.dtsi that are clearly undocumented & unused for meson6,
>>> fixing the following check errors:
>>> audio-controller@5400: compatible:0: 'amlogic,aiu' is not one of ['amlogic,aiu-gxbb', 'amlogic,aiu-gxl', 'amlogic,aiu-meson8', 'amlogic,aiu-meson8b']
>>> from schema $id: http://devicetree.org/schemas/sound/amlogic,aiu.yaml#
>>> audio-controller@5400: compatible: ['amlogic,aiu'] is too short
>>> from schema $id: http://devicetree.org/schemas/sound/amlogic,aiu.yaml#
>>> /soc/bus@c1100000/pwm@8550: failed to match any schema with compatible: ['amlogic,meson-pwm']
>>> /soc/bus@c1100000/pwm@8650: failed to match any schema with compatible: ['amlogic,meson-pwm']
>>> phy@8800: compatible: 'oneOf' conditional failed, one must be fixed:
>>> ['amlogic,meson-mx-usb2-phy'] is too short
>>> 'amlogic,meson-mx-usb2-phy' is not one of ['amlogic,meson8-usb2-phy', 'amlogic,meson8b-usb2-phy', 'amlogic,meson8m2-usb2-phy']
>>> 'amlogic,meson-gxbb-usb2-phy' was expected
>>> from schema $id: http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml#
>>> phy@8820: compatible: 'oneOf' conditional failed, one must be fixed:
>>> ['amlogic,meson-mx-usb2-phy'] is too short
>>> 'amlogic,meson-mx-usb2-phy' is not one of ['amlogic,meson8-usb2-phy', 'amlogic,meson8b-usb2-phy', 'amlogic,meson8m2-usb2-phy']
>>> 'amlogic,meson-gxbb-usb2-phy' was expected
>>> from schema $id: http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml#
>>> /soc/bus@c1100000/mmc@8c20: failed to match any schema with compatible: ['amlogic,meson-mx-sdio']
>>> mmc@8e00: compatible:0: 'amlogic,meson-mx-sdhc' is not one of ['amlogic,meson8-sdhc', 'amlogic,meson8b-sdhc', 'amlogic,meson8m2-sdhc']
>>> from schema $id: http://devicetree.org/schemas/mmc/amlogic,meson-mx-sdhc.yaml#
>>> mmc@8e00: compatible: ['amlogic,meson-mx-sdhc'] is too short
>>> from schema $id: http://devicetree.org/schemas/mmc/amlogic,meson-mx-sdhc.yaml#
>>> remoteproc@1c: compatible:0: 'amlogic,meson-mx-ao-arc' is not one of ['amlogic,meson8-ao-arc', 'amlogic,meson8b-ao-arc']
>>> from schema $id: http://devicetree.org/schemas/remoteproc/amlogic,meson-mx-ao-arc.yaml#
>>> remoteproc@1c: compatible: ['amlogic,meson-mx-ao-arc'] is too short
>>> from schema $id: http://devicetree.org/schemas/remoteproc/amlogic,meson-mx-ao-arc.yaml#
>>>
>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> Generally I'm fine with this. I'm wondering if we should go one step
>> further by decommissioning Meson6 support?
>> To be specific here, I'm thinking of removing MACH_MESON6 from
>> arch/arm/mach-meson/Kconfig and deleting meson6{.dtsi,-atv1200.dts}
>>
>> I don't have any boards with Meson6 SoC, there's no upstream GPIO,
>> pinctrl, clock, MMC, <you name it> driver for that SoC either.
>> So all we have upstream is the ability to boot to initramfs and use
>> serial console(s).
>> If someone is interested in Meson6 support they should bring it back
>> along with a few more patches for upstream support of further
>> peripherals.
>
> I think that’s a sensible move. LibreELEC was one of the few distros
> that supported Meson6 hardware in the past (via the vendor kernel)
> but we ended support in 2018. Meson6 devices are mostly/all? cheap
> Android boxes dating from 2011-2013 and these have either been been
> discarded by users through upgrades or the boxes died long ago. There
> is still community interest in supporting Meson8 boards (the 8x core
> devices are used for retro-gaming) but not the earlier Meson6 ones.
Yeah let's remove meson6 dtsi for v6.13, I'll respin this serie but with
the meson6 removal and some more dts fixes.
Neil
>
> Christian
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 5/7] ARM: dts: amlogic: meson8b-odroidc1: fix invalid reset-gpio
2024-09-11 10:19 [PATCH 0/7] ARM: dts: amlogic: first easy dtbs fixes Neil Armstrong
` (3 preceding siblings ...)
2024-09-11 10:19 ` [PATCH 4/7] ARM: dts: amlogic: meson6: delete undocumented nodes Neil Armstrong
@ 2024-09-11 10:19 ` Neil Armstrong
2024-09-15 19:02 ` Martin Blumenstingl
2024-09-11 10:19 ` [PATCH 6/7] ARM: dts: amlogic: fix /memory node name Neil Armstrong
` (2 subsequent siblings)
7 siblings, 1 reply; 18+ messages in thread
From: Neil Armstrong @ 2024-09-11 10:19 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl
Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
Neil Armstrong
Use the proper "-gpios" property name, fixing:
hub@1: 'reset-gpio' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml#
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts b/arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts
index 941682844faf..962bbe3337db 100644
--- a/arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts
+++ b/arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts
@@ -378,6 +378,6 @@ hub@1 {
compatible = "usb5e3,610";
reg = <1>;
vdd-supply = <&p5v0>;
- reset-gpio = <&gpio_ao GPIOAO_4 GPIO_ACTIVE_LOW>;
+ reset-gpios = <&gpio_ao GPIOAO_4 GPIO_ACTIVE_LOW>;
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH 5/7] ARM: dts: amlogic: meson8b-odroidc1: fix invalid reset-gpio
2024-09-11 10:19 ` [PATCH 5/7] ARM: dts: amlogic: meson8b-odroidc1: fix invalid reset-gpio Neil Armstrong
@ 2024-09-15 19:02 ` Martin Blumenstingl
0 siblings, 0 replies; 18+ messages in thread
From: Martin Blumenstingl @ 2024-09-15 19:02 UTC (permalink / raw)
To: Neil Armstrong
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, devicetree, linux-arm-kernel, linux-amlogic,
linux-kernel
On Wed, Sep 11, 2024 at 12:19 PM Neil Armstrong
<neil.armstrong@linaro.org> wrote:
>
> Use the proper "-gpios" property name, fixing:
> hub@1: 'reset-gpio' does not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml#
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 6/7] ARM: dts: amlogic: fix /memory node name
2024-09-11 10:19 [PATCH 0/7] ARM: dts: amlogic: first easy dtbs fixes Neil Armstrong
` (4 preceding siblings ...)
2024-09-11 10:19 ` [PATCH 5/7] ARM: dts: amlogic: meson8b-odroidc1: fix invalid reset-gpio Neil Armstrong
@ 2024-09-11 10:19 ` Neil Armstrong
2024-09-15 19:05 ` Martin Blumenstingl
2024-09-11 10:19 ` [PATCH 7/7] ARM: dts: amlogic: meson8: use correct pinctrl bank " Neil Armstrong
2024-09-11 13:50 ` [PATCH 0/7] ARM: dts: amlogic: first easy dtbs fixes Rob Herring (Arm)
7 siblings, 1 reply; 18+ messages in thread
From: Neil Armstrong @ 2024-09-11 10:19 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl
Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
Neil Armstrong
Use proper address in /memory node name, fixing:
/: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[1073741824, 2147483648]]}
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm/boot/dts/amlogic/meson6-atv1200.dts | 2 +-
arch/arm/boot/dts/amlogic/meson8-minix-neo-x8.dts | 2 +-
arch/arm/boot/dts/amlogic/meson8b-ec100.dts | 2 +-
arch/arm/boot/dts/amlogic/meson8b-mxq.dts | 2 +-
arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts | 2 +-
arch/arm/boot/dts/amlogic/meson8m2-mxiii-plus.dts | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/amlogic/meson6-atv1200.dts b/arch/arm/boot/dts/amlogic/meson6-atv1200.dts
index 98e1c94c0261..f3529e5b0f13 100644
--- a/arch/arm/boot/dts/amlogic/meson6-atv1200.dts
+++ b/arch/arm/boot/dts/amlogic/meson6-atv1200.dts
@@ -18,7 +18,7 @@ chosen {
stdout-path = "serial0:115200n8";
};
- memory {
+ memory@0 {
device_type = "memory";
reg = <0x40000000 0x80000000>;
};
diff --git a/arch/arm/boot/dts/amlogic/meson8-minix-neo-x8.dts b/arch/arm/boot/dts/amlogic/meson8-minix-neo-x8.dts
index c6d1c5a8a3bf..e7f5d290c1b8 100644
--- a/arch/arm/boot/dts/amlogic/meson8-minix-neo-x8.dts
+++ b/arch/arm/boot/dts/amlogic/meson8-minix-neo-x8.dts
@@ -19,7 +19,7 @@ chosen {
stdout-path = "serial0:115200n8";
};
- memory {
+ memory@0 {
device_type = "memory";
reg = <0x40000000 0x80000000>;
};
diff --git a/arch/arm/boot/dts/amlogic/meson8b-ec100.dts b/arch/arm/boot/dts/amlogic/meson8b-ec100.dts
index 49890eb12781..bf5e80c874a7 100644
--- a/arch/arm/boot/dts/amlogic/meson8b-ec100.dts
+++ b/arch/arm/boot/dts/amlogic/meson8b-ec100.dts
@@ -22,7 +22,7 @@ chosen {
stdout-path = "serial0:115200n8";
};
- memory {
+ memory@0 {
device_type = "memory";
reg = <0x40000000 0x40000000>;
};
diff --git a/arch/arm/boot/dts/amlogic/meson8b-mxq.dts b/arch/arm/boot/dts/amlogic/meson8b-mxq.dts
index 7adedd3258c3..f48748a02409 100644
--- a/arch/arm/boot/dts/amlogic/meson8b-mxq.dts
+++ b/arch/arm/boot/dts/amlogic/meson8b-mxq.dts
@@ -22,7 +22,7 @@ chosen {
stdout-path = "serial0:115200n8";
};
- memory {
+ memory@0 {
device_type = "memory";
reg = <0x40000000 0x40000000>;
};
diff --git a/arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts b/arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts
index 962bbe3337db..85dae08afe9e 100644
--- a/arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts
+++ b/arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts
@@ -22,7 +22,7 @@ chosen {
stdout-path = "serial0:115200n8";
};
- memory {
+ memory@0 {
device_type = "memory";
reg = <0x40000000 0x40000000>;
};
diff --git a/arch/arm/boot/dts/amlogic/meson8m2-mxiii-plus.dts b/arch/arm/boot/dts/amlogic/meson8m2-mxiii-plus.dts
index aa4d4bf70629..587bbe706fd1 100644
--- a/arch/arm/boot/dts/amlogic/meson8m2-mxiii-plus.dts
+++ b/arch/arm/boot/dts/amlogic/meson8m2-mxiii-plus.dts
@@ -26,7 +26,7 @@ chosen {
stdout-path = "serial0:115200n8";
};
- memory {
+ memory@0 {
device_type = "memory";
reg = <0x40000000 0x80000000>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH 6/7] ARM: dts: amlogic: fix /memory node name
2024-09-11 10:19 ` [PATCH 6/7] ARM: dts: amlogic: fix /memory node name Neil Armstrong
@ 2024-09-15 19:05 ` Martin Blumenstingl
2024-09-16 7:22 ` Neil Armstrong
0 siblings, 1 reply; 18+ messages in thread
From: Martin Blumenstingl @ 2024-09-15 19:05 UTC (permalink / raw)
To: Neil Armstrong
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, devicetree, linux-arm-kernel, linux-amlogic,
linux-kernel
Hi Neil,
On Wed, Sep 11, 2024 at 12:19 PM Neil Armstrong
<neil.armstrong@linaro.org> wrote:
[...]
> - memory {
> + memory@0 {
> device_type = "memory";
> reg = <0x40000000 0x80000000>;
On the 32-bit SoCs we specify memory at an 0x40000000 offset.
Shouldn't we use memory@40000000 in that case?
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 6/7] ARM: dts: amlogic: fix /memory node name
2024-09-15 19:05 ` Martin Blumenstingl
@ 2024-09-16 7:22 ` Neil Armstrong
0 siblings, 0 replies; 18+ messages in thread
From: Neil Armstrong @ 2024-09-16 7:22 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, devicetree, linux-arm-kernel, linux-amlogic,
linux-kernel
On 15/09/2024 21:05, Martin Blumenstingl wrote:
> Hi Neil,
>
> On Wed, Sep 11, 2024 at 12:19 PM Neil Armstrong
> <neil.armstrong@linaro.org> wrote:
> [...]
>> - memory {
>> + memory@0 {
>> device_type = "memory";
>> reg = <0x40000000 0x80000000>;
> On the 32-bit SoCs we specify memory at an 0x40000000 offset.
> Shouldn't we use memory@40000000 in that case?
Yes you're right, I'll fix it in v2
Neil
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 7/7] ARM: dts: amlogic: meson8: use correct pinctrl bank node name
2024-09-11 10:19 [PATCH 0/7] ARM: dts: amlogic: first easy dtbs fixes Neil Armstrong
` (5 preceding siblings ...)
2024-09-11 10:19 ` [PATCH 6/7] ARM: dts: amlogic: fix /memory node name Neil Armstrong
@ 2024-09-11 10:19 ` Neil Armstrong
2024-09-15 19:03 ` Martin Blumenstingl
2024-09-11 13:50 ` [PATCH 0/7] ARM: dts: amlogic: first easy dtbs fixes Rob Herring (Arm)
7 siblings, 1 reply; 18+ messages in thread
From: Neil Armstrong @ 2024-09-11 10:19 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl
Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
Neil Armstrong
Use the proper name for the pinctrl bank subnode, fixing:
pinctrl@9880: Unevaluated properties are not allowed ('banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'reg', 'reg' were unexpected)
from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-cbus.yaml#
pinctrl@84: Unevaluated properties are not allowed ('ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'reg', 'reg' were unexpected)
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm/boot/dts/amlogic/meson8.dtsi | 4 ++--
arch/arm/boot/dts/amlogic/meson8b.dtsi | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/amlogic/meson8.dtsi b/arch/arm/boot/dts/amlogic/meson8.dtsi
index 1023ff0a4f9f..6c7596c8b96b 100644
--- a/arch/arm/boot/dts/amlogic/meson8.dtsi
+++ b/arch/arm/boot/dts/amlogic/meson8.dtsi
@@ -353,7 +353,7 @@ pinctrl_aobus: pinctrl@84 {
#size-cells = <1>;
ranges;
- gpio_ao: ao-bank@14 {
+ gpio_ao: bank@14 {
reg = <0x14 0x4>,
<0x2c 0x4>,
<0x24 0x8>;
@@ -468,7 +468,7 @@ pinctrl_cbus: pinctrl@9880 {
#size-cells = <1>;
ranges;
- gpio: banks@80b0 {
+ gpio: bank@80b0 {
reg = <0x80b0 0x28>,
<0x80e8 0x18>,
<0x8120 0x18>,
diff --git a/arch/arm/boot/dts/amlogic/meson8b.dtsi b/arch/arm/boot/dts/amlogic/meson8b.dtsi
index 641cd60781a3..c8fbeede7e38 100644
--- a/arch/arm/boot/dts/amlogic/meson8b.dtsi
+++ b/arch/arm/boot/dts/amlogic/meson8b.dtsi
@@ -315,7 +315,7 @@ pinctrl_aobus: pinctrl@84 {
#size-cells = <1>;
ranges;
- gpio_ao: ao-bank@14 {
+ gpio_ao: bank@14 {
reg = <0x14 0x4>,
<0x2c 0x4>,
<0x24 0x8>;
@@ -422,7 +422,7 @@ pinctrl_cbus: pinctrl@9880 {
#size-cells = <1>;
ranges;
- gpio: banks@80b0 {
+ gpio: bank@80b0 {
reg = <0x80b0 0x28>,
<0x80e8 0x18>,
<0x8120 0x18>,
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH 7/7] ARM: dts: amlogic: meson8: use correct pinctrl bank node name
2024-09-11 10:19 ` [PATCH 7/7] ARM: dts: amlogic: meson8: use correct pinctrl bank " Neil Armstrong
@ 2024-09-15 19:03 ` Martin Blumenstingl
0 siblings, 0 replies; 18+ messages in thread
From: Martin Blumenstingl @ 2024-09-15 19:03 UTC (permalink / raw)
To: Neil Armstrong
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, devicetree, linux-arm-kernel, linux-amlogic,
linux-kernel
On Wed, Sep 11, 2024 at 12:19 PM Neil Armstrong
<neil.armstrong@linaro.org> wrote:
>
> Use the proper name for the pinctrl bank subnode, fixing:
> pinctrl@9880: Unevaluated properties are not allowed ('banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'banks@80b0', 'reg', 'reg' were unexpected)
> from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-cbus.yaml#
> pinctrl@84: Unevaluated properties are not allowed ('ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'ao-bank@14', 'reg', 'reg' were unexpected)
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 0/7] ARM: dts: amlogic: first easy dtbs fixes
2024-09-11 10:19 [PATCH 0/7] ARM: dts: amlogic: first easy dtbs fixes Neil Armstrong
` (6 preceding siblings ...)
2024-09-11 10:19 ` [PATCH 7/7] ARM: dts: amlogic: meson8: use correct pinctrl bank " Neil Armstrong
@ 2024-09-11 13:50 ` Rob Herring (Arm)
7 siblings, 0 replies; 18+ messages in thread
From: Rob Herring (Arm) @ 2024-09-11 13:50 UTC (permalink / raw)
To: Neil Armstrong
Cc: Martin Blumenstingl, linux-kernel, devicetree, linux-arm-kernel,
Kevin Hilman, Krzysztof Kozlowski, Conor Dooley, linux-amlogic,
Jerome Brunet
On Wed, 11 Sep 2024 12:19:39 +0200, Neil Armstrong wrote:
> This is the easy fixes to start and fully document the ARM Amlogic
> Device Trees, remaining work includes:
> - ethmac with required phy-mode/clocks/clock-names
> - amlogic,meson-hhi-sysctrl
> - amlogic,meson8-clkc
> - pinctrl: Unevaluated properties are not allowed ('reg', 'reg' were unexpected)
> - bank@80b0:gpio-line-names is too short
> - realtek,rt5640
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Neil Armstrong (7):
> ARM: dts: amlogic: meson6: fix clk81 node name
> ARM: dts: amlogic: meson8: fix soc thermal-zone node name
> ARM: dts: amlogic: meson8: fix ao_arc_sram node name
> ARM: dts: amlogic: meson6: delete undocumented nodes
> ARM: dts: amlogic: meson8b-odroidc1: fix invalid reset-gpio
> ARM: dts: amlogic: fix /memory node name
> ARM: dts: amlogic: meson8: use correct pinctrl bank node name
>
> arch/arm/boot/dts/amlogic/meson6-atv1200.dts | 2 +-
> arch/arm/boot/dts/amlogic/meson6.dtsi | 18 +++++++++++++++++-
> arch/arm/boot/dts/amlogic/meson8-minix-neo-x8.dts | 2 +-
> arch/arm/boot/dts/amlogic/meson8.dtsi | 8 ++++----
> arch/arm/boot/dts/amlogic/meson8b-ec100.dts | 2 +-
> arch/arm/boot/dts/amlogic/meson8b-mxq.dts | 2 +-
> arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts | 4 ++--
> arch/arm/boot/dts/amlogic/meson8b.dtsi | 8 ++++----
> arch/arm/boot/dts/amlogic/meson8m2-mxiii-plus.dts | 2 +-
> 9 files changed, 32 insertions(+), 16 deletions(-)
> ---
> base-commit: 100cc857359b5d731407d1038f7e76cd0e871d94
> change-id: 20240911-topic-amlogic-arm32-upstream-bindings-fixes-69d624b8bccd
>
> Best regards,
> --
> Neil Armstrong <neil.armstrong@linaro.org>
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y amlogic/meson6-atv1200.dtb amlogic/meson8-minix-neo-x8.dtb amlogic/meson8b-ec100.dtb amlogic/meson8b-mxq.dtb amlogic/meson8b-odroidc1.dtb amlogic/meson8m2-mxiii-plus.dtb' for 20240911-topic-amlogic-arm32-upstream-bindings-fixes-v1-0-feaabb45916b@linaro.org:
arch/arm/boot/dts/amlogic/meson8b-mxq.dtb: pinctrl@9880: Unevaluated properties are not valid under the given schema ('reg', 'reg' were unevaluated and invalid)
from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-cbus.yaml#
arch/arm/boot/dts/amlogic/meson8b-odroidc1.dtb: pinctrl@9880: bank@80b0: Unevaluated properties are not allowed ('gpio-line-names' was unexpected)
from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-cbus.yaml#
arch/arm/boot/dts/amlogic/meson8b-odroidc1.dtb: pinctrl@9880: bank@80b0:gpio-line-names: ['J2 Header Pin 35', 'J2 Header Pin 36', 'J2 Header Pin 32', 'J2 Header Pin 31', 'J2 Header Pin 29', 'J2 Header Pin 18', 'J2 Header Pin 22', 'J2 Header Pin 16', 'J2 Header Pin 23', 'J2 Header Pin 21', 'J2 Header Pin 19', 'J2 Header Pin 33', 'J2 Header Pin 8', 'J2 Header Pin 10', 'J2 Header Pin 15', 'J2 Header Pin 13', 'J2 Header Pin 24', 'J2 Header Pin 26', 'Revision (upper)', 'Revision (lower)', 'J2 Header Pin 7', '', 'J2 Header Pin 12', 'J2 Header Pin 11', '', '', '', 'TFLASH_VDD_EN', '', '', 'VCCK_PWM (PWM_C)', 'I2CA_SDA', 'I2CA_SCL', 'I2CB_SDA', 'I2CB_SCL', 'VDDEE_PWM (PWM_D)', '', 'HDMI_HPD', 'HDMI_I2C_SDA', 'HDMI_I2C_SCL', 'ETH_PHY_INTR', 'ETH_PHY_NRST', 'ETH_TXD1', 'ETH_TXD0', 'ETH_TXD3', 'ETH_TXD2', 'ETH_RGMII_TX_CLK', 'SD_DATA1 (SDB_D1)', 'SD_DATA0 (SDB_D0)', 'SD_CLK', 'SD_CMD', 'SD_DATA3 (SDB_D3)', 'SD_DATA2 (SDB_D2)', 'SD_CDN (SD_DET_N)', 'SDC_D0 (EMMC)', 'SDC_D1 (EMMC)', 'SDC_D2 (EMMC
)', 'SDC_D3 (EMMC)', 'SDC_D4 (EMMC)', 'SDC_D5 (EMMC)', 'SDC_D6 (EMMC)', 'SDC_D7 (EMMC)', 'SDC_CLK (EMMC)', 'SDC_RSTn (EMMC)', 'SDC_CMD (EMMC)', 'BOOT_SEL', '', '', '', '', '', '', '', 'ETH_RXD1', 'ETH_RXD0', 'ETH_RX_DV', 'RGMII_RX_CLK', 'ETH_RXD3', 'ETH_RXD2', 'ETH_TXEN', 'ETH_PHY_REF_CLK_25MOUT', 'ETH_MDC', 'ETH_MDIO'] is too short
from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-cbus.yaml#
arch/arm/boot/dts/amlogic/meson8-minix-neo-x8.dtb: pinctrl@9880: Unevaluated properties are not valid under the given schema ('reg', 'reg' were unevaluated and invalid)
from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-cbus.yaml#
arch/arm/boot/dts/amlogic/meson8b-odroidc1.dtb: pinctrl@9880: Unevaluated properties are not valid under the given schema ('reg', 'reg' were unevaluated and invalid)
from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-cbus.yaml#
arch/arm/boot/dts/amlogic/meson8m2-mxiii-plus.dtb: pinctrl@9880: Unevaluated properties are not valid under the given schema ('reg', 'reg' were unevaluated and invalid)
from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-cbus.yaml#
arch/arm/boot/dts/amlogic/meson8b-ec100.dtb: pinctrl@9880: bank@80b0: Unevaluated properties are not allowed ('gpio-line-names' was unexpected)
from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-cbus.yaml#
arch/arm/boot/dts/amlogic/meson8b-ec100.dtb: pinctrl@9880: bank@80b0:gpio-line-names: ['WIFI_SD_D0', 'WIFI_SD_D1', 'WIFI_SD_D2', 'WIFI_SD_D3', 'BTPCM_DOUT', 'BTPCM_DIN', 'BTPCM_SYNC', 'BTPCM_CLK', 'WIFI_SD_CLK', 'WIFI_SD_CMD', 'WIFI_32K', 'WIFI_PWREN', 'UART_B_TX', 'UART_B_RX', 'UART_B_CTS_N', 'UART_B_RTS_N', 'BT_EN', 'WIFI_WAKE_HOST', '', '', '', '', '', '', '', '', '', '', '', '', 'VCCK_PWM_C', 'I2C_SDA_A', 'I2C_SCL_A', 'I2C_SDA_B', 'I2C_SCL_B', 'VDDEE_PWM_D', 'VDDEE_PWM 3V3_5V_EN', 'HDMI_HPD', 'HDMI_I2C_SDA', 'HDMI_I2C_SCL', 'RMII_IRQ', 'RMII_RST#', 'RMII_TXD1', 'RMII_TXD0', 'AV_select_1', 'AV_select_2', 'MCU_Control_S', 'SD_D1_B', 'SD_D0_B', 'SD_CLK_8726MX', 'SD_CMD_8726MX', 'SD_D3_B', 'SD_D2_B', 'CARD_EN_DET (CARD_DET)', 'NAND_D0 (EMMC)', 'NAND_D1 (EMMC)', 'NAND_D2 (EMMC)', 'NAND_D3 (EMMC)', 'NAND_D4 (EMMC)', 'NAND_D5 (EMMC)', 'NAND_D6 (EMMC)', 'NAND_D7 (EMMC)', 'NAND_CS1 (EMMC)', 'NAND_CS2 iNAND_RS1 (EMMC)', 'NAND_nR/B iNAND_CMD (EMMC)', 'NAND_ALE (EMMC)', 'NAND_CLE (EMMC)', 'n
RE_S1 NAND_nRE (EMMC)', 'nWE_S1 NAND_nWE (EMMC)', '', '', 'SPI_CS', 'RMII_RXD1', 'RMII_RXD0', 'RMII_CRS_DV', 'RMII_50M_IN', 'GPIODIF_4', 'GPIODIF_5', 'RMII_TXEN', 'CPUETH_25MOUT', 'RMII_MDC', 'RMII_MDIO'] is too short
from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-cbus.yaml#
arch/arm/boot/dts/amlogic/meson8b-ec100.dtb: pinctrl@9880: Unevaluated properties are not valid under the given schema ('reg', 'reg' were unevaluated and invalid)
from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-cbus.yaml#
arch/arm/boot/dts/amlogic/meson8b-mxq.dtb: pinctrl@84: Unevaluated properties are not valid under the given schema ('reg', 'reg' were unevaluated and invalid)
from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-aobus.yaml#
arch/arm/boot/dts/amlogic/meson8b-odroidc1.dtb: pinctrl@84: Unevaluated properties are not valid under the given schema ('reg', 'reg' were unevaluated and invalid)
from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-aobus.yaml#
arch/arm/boot/dts/amlogic/meson8b-ec100.dtb: pinctrl@84: Unevaluated properties are not valid under the given schema ('reg', 'reg' were unevaluated and invalid)
from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-aobus.yaml#
arch/arm/boot/dts/amlogic/meson8-minix-neo-x8.dtb: pinctrl@84: Unevaluated properties are not valid under the given schema ('reg', 'reg' were unevaluated and invalid)
from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-aobus.yaml#
arch/arm/boot/dts/amlogic/meson8m2-mxiii-plus.dtb: pinctrl@84: Unevaluated properties are not valid under the given schema ('reg', 'reg' were unevaluated and invalid)
from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-aobus.yaml#
^ permalink raw reply [flat|nested] 18+ messages in thread