From: Conor Dooley <conor@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: krzk+dt@kernel.org, jassisinghbrar@gmail.com, robh@kernel.org,
conor+dt@kernel.org, matthias.bgg@gmail.com,
houlong.wei@mediatek.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, kernel@collabora.com,
fshao@chromium.org
Subject: Re: [PATCH] dt-bindings: mailbox: mediatek,gce-mailbox: Stop requiring clock-names
Date: Wed, 11 Sep 2024 18:51:04 +0100 [thread overview]
Message-ID: <20240911-unhappy-wifi-b0a851e261bb@spud> (raw)
In-Reply-To: <20240911104327.123602-1-angelogioacchino.delregno@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]
On Wed, Sep 11, 2024 at 12:43:27PM +0200, AngeloGioacchino Del Regno wrote:
> There is no reason to make specifying the clock-names property
> mandatory, as the Global Command Engine HW needs only one clock.
Have you checked to make sure that there are no users that do the lookup
by name?
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../bindings/mailbox/mediatek,gce-mailbox.yaml | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> index cef9d7601398..ff5d010fbcf0 100644
> --- a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> @@ -56,17 +56,6 @@ required:
> - interrupts
> - clocks
>
> -allOf:
> - - if:
> - not:
> - properties:
> - compatible:
> - contains:
> - const: mediatek,mt8195-gce
> - then:
> - required:
> - - clock-names
> -
> additionalProperties: false
>
> examples:
> --
> 2.46.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-09-11 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 10:43 [PATCH] dt-bindings: mailbox: mediatek,gce-mailbox: Stop requiring clock-names AngeloGioacchino Del Regno
2024-09-11 17:51 ` Conor Dooley [this message]
2024-09-12 7:59 ` AngeloGioacchino Del Regno
2024-09-12 8:27 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240911-unhappy-wifi-b0a851e261bb@spud \
--to=conor@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fshao@chromium.org \
--cc=houlong.wei@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox