From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E4CCEE57D0 for ; Wed, 11 Sep 2024 20:08:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jpvR0RjtP/6Ar/BacV+c4jvmIjp9mTymL/5zFFcJFFo=; b=GSBkNRo8698OA12V5/qty29E4i DIXT1Xgd9/HllV6s+KS8z4L+OVdEE3kjKZLiUskluX31uDvNd6oRlUu6bNhuNGIFNY4i/L7zP+qFn L+pqGpT7inPLxIQ3geucVneu+1fLGYHlf+5CpDL4JQccjB4/3HtqBLq6NKHgYWROcNhlyqz0xQfoR Zc3KeLMzwC/jYXbVT56nBTEZPODnEATSiZA3ogKCEDKBe91Sf9c+I5SHYdEr5X9kbA7BdgbJQDdHX HMHs+FQFD9CJ5difDzMwVMliQaMFG9Y2GJWRq1Rwwfxf6GHcJ9dBIA7Q5JWB1QWe2mYvnl0Hejx1Z K5z5/CWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soTdM-0000000AqBW-24XY; Wed, 11 Sep 2024 20:08:12 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1soTcI-0000000Aq09-2iBi for linux-arm-kernel@lists.infradead.org; Wed, 11 Sep 2024 20:07:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 534025C0345; Wed, 11 Sep 2024 20:07:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1A8DC4CEC0; Wed, 11 Sep 2024 20:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1726085225; bh=I4BJLT6G+F0wLdMtohFskrraQnFUUj6Fg5Q8+RwPmXk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uaeL/Img29qakLFRIxlhJcVZNDw7mlRWB+nv0ap2MGT+YdM3gXm0oEgSWfozHa+Lx XvJ6mdoLIh2WXW0OdkMo2ojZGuTvOwq/M/inTuZEwj6wwut+FnmPuJgVrwcPjCBZz2 O6jenm5DjSaqhX9tsVcV8tb3RnFMWI2LlwYcDDzY= Date: Wed, 11 Sep 2024 22:07:02 +0200 From: Greg Kroah-Hartman To: Danilo Krummrich Cc: Ayush Singh , fabien.parent@linaro.org, d-gole@ti.com, lorforlinux@beagleboard.org, jkridner@beagleboard.org, robertcnelson@beagleboard.org, Andrew Davis , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/8] rust: kernel: Add Platform device and driver abstractions Message-ID: <2024091158-cardinal-theorize-6efe@gregkh> References: <20240911-mikrobus-dt-v1-0-3ded4dc879e7@beagleboard.org> <20240911-mikrobus-dt-v1-1-3ded4dc879e7@beagleboard.org> <2024091106-scouring-smitten-e740@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240911_130706_771875_0355E8D6 X-CRM114-Status: GOOD ( 16.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 11, 2024 at 07:35:35PM +0200, Danilo Krummrich wrote: > On Wed, Sep 11, 2024 at 04:56:14PM +0200, Greg Kroah-Hartman wrote: > > On Wed, Sep 11, 2024 at 07:57:18PM +0530, Ayush Singh wrote: > > > +/// An identifier for Platform devices. > > > +/// > > > +/// Represents the kernel's [`struct of_device_id`]. This is used to find an appropriate > > > +/// Platform driver. > > > +/// > > > +/// [`struct of_device_id`]: srctree/include/linux/mod_devicetable.h > > > +pub struct DeviceId(&'static CStr); > > > + > > > +impl DeviceId { > > > > > > > > I appreciate posting this, but this really should go on top of the > > device driver work Danilo Krummrich has been doing. > > If everyone agrees, I'd offer to just provide platform device / driver > abstractions with my next patch series. This way you don't need to worry > about aligning things with the rest of the abstractions yourself and throughout > potential further versions of the series. That sounds good to me, thanks! > Just be aware that I probably won't get to work on it until after LPC. We will not be able to review anything until after LPC either :) thanks, greg k-h