From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38FA6EEB597 for ; Thu, 12 Sep 2024 11:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w4n+GYZ6xQGCnhlI0MzrUhScT+W1XwcIKjMSfmbo9NU=; b=GOEvEQLrFizCvhsai+w4iNorNi gmqEm9A8mDs0KfobTOOovlpYsdM7htNQ9cJVgA8Km1thZCEYKn25IKRS4xOSqvORcL1faFcEHI4qx 9wOc1ujSn3CCoNZs0agGROwMMa4LyhehKdmXOmtfqMBXTrPIDgORTySO1BLkXo+BD0TnX1cD7l+nE OVe6QaJCenEBln0bWH+BjAqA+qnt4LTYUeSIUXYcZX+hlo3s7q0QNVvMOtyqiacM5mtZ8pN/LhMJa P3YJzwwV2Ho90C4Va74GlwEJuPQIzjIEHWISCs7dn0M73pvi+U519ObCEoYLr33l5yUBJs4C1Ey++ tgMqPuBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soiKf-0000000CuEl-1HKg; Thu, 12 Sep 2024 11:49:53 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1soiJT-0000000Ctzr-3NoL for linux-arm-kernel@lists.infradead.org; Thu, 12 Sep 2024 11:48:41 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-42cb7a2e4d6so7252515e9.0 for ; Thu, 12 Sep 2024 04:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1726141716; x=1726746516; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=w4n+GYZ6xQGCnhlI0MzrUhScT+W1XwcIKjMSfmbo9NU=; b=Dp4da/UGMNTrCmxrk+/Y0t+86XgR48s9aBtfAAk2ANmQ8ROBBPc4mZtzqymC21pvbr +kOxrbbuqCEfIG3nUfDbsLX6SHUwUl2Igtzp11wBG5bIyg0sxItBWIeJH1uXzQ8Yr9vk ObMesbOVXoK8uscG0NVzJ7N30sqx+avc4S9MmgPBn0L0uIZJYOPEfy1IdxWlYYn/1O6r gON8pFj8d9T9LppB0xabebbV5kWcJGEyoFf02EdkpX22vo4x4BlgT26MN9SkqBZpatYX 2tatkIvVTr45bbMGMVFJAJNNzEYtECRGcsZSHYJc3lGlKAnT46we6T05fHT6A7A6MkF6 lV7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726141716; x=1726746516; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w4n+GYZ6xQGCnhlI0MzrUhScT+W1XwcIKjMSfmbo9NU=; b=F6j7eNcvgir0FHTQv+0zNAuzVETsica+ruBqGSEsiOBtBrPAcFlbtRmB3ur/MPE9k3 f/soNFqVuwr2fl6uyECWOMBgMr47Rpw46I5GwHHFunzG/j8s3AC7D5vBQ630F/6Oo6kE ilbKKSblLZPcaLFC6ppLg6LYlGRZftamDH5QpStm5r5wtKQaJ6xGOE24Rk1mu+VdUQ5Y UubktM4B4529hMBpIOZCQBMERhPNDHzOmyN7nL9cfq9zOS9pBY281CdZ39pb9TOgPeR+ yPuvrN1l/6y9QeRVGWxm9VPliYAWNtMFFgmtpQ6NUwMgPqz2EkmdtP3JG6lfsxJxJWjs 5hEg== X-Forwarded-Encrypted: i=1; AJvYcCVFS3L9YcLaBBbATi2Y4bhCeKHC/ENN7f+JI+GZKWkjPge2L/rlhuJvEEhg+MHIQXxrcvXrBqzjA0iyjAANv49w@lists.infradead.org X-Gm-Message-State: AOJu0YwJ1qJqOZEGQNE8WIsStPpq1VFbHYg7RLxqelrXvUg3v8x80V2v py10GPx6paK+rm7fJiTItA12GC3NKEs4wIlF/a3F/TfqqVTu6a/ouVYm/1CiGcE= X-Google-Smtp-Source: AGHT+IGuLMW5PBxZVZzC5sjGav8GQCfg4HAZBPxOo7KZmIvu+1pf6lJkOGjLrp49iZcF/LWq3PE2sw== X-Received: by 2002:a05:600c:548e:b0:42c:a905:9384 with SMTP id 5b1f17b1804b1-42cdb54d606mr17694175e9.20.1726141714874; Thu, 12 Sep 2024 04:48:34 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37895675b7esm14162196f8f.50.2024.09.12.04.48.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 04:48:34 -0700 (PDT) Date: Thu, 12 Sep 2024 13:48:33 +0200 From: Andrew Jones To: Sean Christopherson Cc: Marc Zyngier , Oliver Upton , Anup Patel , Paolo Bonzini , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, James Houghton Subject: Re: [PATCH v2 00/13] KVM: selftests: Morph max_guest_mem to mmu_stress Message-ID: <20240912-757a952b867ea1136cb260cf@orel> References: <20240911204158.2034295-1-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240911204158.2034295-1-seanjc@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240912_044839_910161_93170BBC X-CRM114-Status: GOOD ( 39.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 11, 2024 at 01:41:45PM GMT, Sean Christopherson wrote: > Marc/Oliver, > > I would love a sanity check on patches 2 and 3 before I file a bug against > gcc. The code is pretty darn simple, so I don't think I've misdiagnosed the > problem, but I've also been second guessing myself _because_ it's so simple; > it seems super unlikely that no one else would have run into this before. > > On to the patches... > > The main purpose of this series is to convert the max_guest_memory_test into > a more generic mmu_stress_test. The patches were originally posted as part > a KVM x86/mmu series to test the x86/mmu changes, hence the v2. > > The basic gist of the "conversion" is to have the test do mprotect() on > guest memory while vCPUs are accessing said memory, e.g. to verify KVM and > mmu_notifiers are working as intended. > > Patches 1-4 are a somewhat unexpected side quest that I can (arguably should) > post separately if that would make things easier. The original plan was that > patch 2 would be a single patch, but things snowballed. > > Patch 2 reworks vcpu_get_reg() to return a value instead of using an > out-param. This is the entire motivation for including these patches; > having to define a variable just to bump the program counter on arm64 > annoyed me. > > Patch 4 adds hardening to vcpu_{g,s}et_reg() to detect potential truncation, > as KVM's uAPI allows for registers greater than the 64 bits the are supported > in the "outer" selftests APIs ((vcpu_set_reg() takes a u64, vcpu_get_reg() > now returns a u64). > > Patch 1 is a change to KVM's uAPI headers to move the KVM_REG_SIZE > definition to common code so that the selftests side of things doesn't > need #ifdefs to implement the hardening in patch 4. > > Patch 3 is the truly unexpected part. With the vcpu_get_reg() rework, > arm64's vpmu_counter_test fails when compiled with gcc-13, and on gcc-11 > with an added "noinline". AFAICT, the failure doesn't actually have > anything to with vcpu_get_reg(); I suspect the largely unrelated change > just happened to run afoul of a latent gcc bug. > > Pending a sanity check, I will file a gcc bug. In the meantime, I am > hoping to fudge around the issue in KVM selftests so that the vcpu_get_reg() > cleanup isn't blocked, and because the hack-a-fix is arguably a cleanup > on its own. > > v2: > - Rebase onto kvm/next. > - Add the aforementioned vcpu_get_reg() changes/disaster. > - Actually add arm64 support for the fancy mprotect() testcase (I did this > before v1, but managed to forget to include the changes when posting). > - Emit "mov %rax, (%rax)" on x86. [James] > - Add a comment to explain the fancy mprotect() vs. vCPUs logic. > - Drop the KVM x86 patches (applied and/or will be handled separately). > > v1: https://lore.kernel.org/all/20240809194335.1726916-1-seanjc@google.com > > Sean Christopherson (13): > KVM: Move KVM_REG_SIZE() definition to common uAPI header > KVM: selftests: Return a value from vcpu_get_reg() instead of using an > out-param > KVM: selftests: Fudge around an apparent gcc bug in arm64's PMU test > KVM: selftests: Assert that vcpu_{g,s}et_reg() won't truncate > KVM: selftests: Check for a potential unhandled exception iff KVM_RUN > succeeded > KVM: selftests: Rename max_guest_memory_test to mmu_stress_test > KVM: selftests: Only muck with SREGS on x86 in mmu_stress_test > KVM: selftests: Compute number of extra pages needed in > mmu_stress_test > KVM: selftests: Enable mmu_stress_test on arm64 > KVM: selftests: Use vcpu_arch_put_guest() in mmu_stress_test > KVM: selftests: Precisely limit the number of guest loops in > mmu_stress_test > KVM: selftests: Add a read-only mprotect() phase to mmu_stress_test > KVM: selftests: Verify KVM correctly handles mprotect(PROT_READ) > > arch/arm64/include/uapi/asm/kvm.h | 3 - > arch/riscv/include/uapi/asm/kvm.h | 3 - > include/uapi/linux/kvm.h | 4 + > tools/testing/selftests/kvm/Makefile | 3 +- > .../selftests/kvm/aarch64/aarch32_id_regs.c | 10 +- > .../selftests/kvm/aarch64/debug-exceptions.c | 4 +- > .../selftests/kvm/aarch64/hypercalls.c | 6 +- > .../testing/selftests/kvm/aarch64/psci_test.c | 6 +- > .../selftests/kvm/aarch64/set_id_regs.c | 18 +- > .../kvm/aarch64/vpmu_counter_access.c | 27 ++- > .../testing/selftests/kvm/include/kvm_util.h | 10 +- > .../selftests/kvm/lib/aarch64/processor.c | 8 +- > tools/testing/selftests/kvm/lib/kvm_util.c | 3 +- > .../selftests/kvm/lib/riscv/processor.c | 66 +++---- > ..._guest_memory_test.c => mmu_stress_test.c} | 161 ++++++++++++++++-- > .../testing/selftests/kvm/riscv/arch_timer.c | 2 +- > .../testing/selftests/kvm/riscv/ebreak_test.c | 2 +- > .../selftests/kvm/riscv/sbi_pmu_test.c | 2 +- > tools/testing/selftests/kvm/s390x/resets.c | 2 +- > tools/testing/selftests/kvm/steal_time.c | 3 +- > 20 files changed, 236 insertions(+), 107 deletions(-) > rename tools/testing/selftests/kvm/{max_guest_memory_test.c => mmu_stress_test.c} (60%) > > > base-commit: 15e1c3d65975524c5c792fcd59f7d89f00402261 > -- > 2.46.0.598.g6f2099f65c-goog I gave this test a try on riscv, but it appears to hang in rendezvous_with_vcpus(). My platform is QEMU, so maybe I was just too impatient. Anyway, I haven't read the test yet, so I don't even know what it's doing. It's possibly it's trying to do something not yet supported on riscv. I'll add investigating that to my TODO, but I'm not sure when I'll get to it. As for this series, another patch (or a sneaky change to one of the patches...) should add #include "ucall_common.h" to mmu_stress_test.c since it's not there yet despite using get_ucall(). Building riscv faild because of that. Thanks, drew