From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6F93EEB565 for ; Thu, 12 Sep 2024 09:12:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KDYukj80mIHPYCgHSB2w3O30EP7PG7QCtWy9R/+4O+8=; b=GtpTcED3IXmd+WJ2y250wxHEc2 Qgd2t0OjbQlmQTj+ENKvFTeM9YZXSWNoCaiCcz+w6SE6t1RhgllJSfLov6q5URTeDHz1VlvTTdz1F h9riOvVV5q5msZvz/szf2fjEKh/l9JTGe59VGA6UO4LNTYvO5sI5ThmWmMsvEvBbr6u+CnSmjcgGt mQ0zGIUlg5bJhw5QhYkfNn5E7Maz4ZKtM1ByGaBIryrOUkjOxXxbno85Ju7jvTAUbHqZx7xvt4Hu8 UnUP3VJqnhrtOENh4B0hv4O9MXh3LGz+9NV3/5jrsnO4r+N/4u07JwGpwViXTwUAW5xyXqO2wtdsF k30bPu3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sofsX-0000000CUCV-0OVQ; Thu, 12 Sep 2024 09:12:41 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sofrQ-0000000CTwn-3z1w for linux-arm-kernel@lists.infradead.org; Thu, 12 Sep 2024 09:11:34 +0000 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5c3d20eed0bso804164a12.0 for ; Thu, 12 Sep 2024 02:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1726132291; x=1726737091; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KDYukj80mIHPYCgHSB2w3O30EP7PG7QCtWy9R/+4O+8=; b=dCWyEASp/St5fOVrXYbLAXOVL+aJleoApmzI3nl/vjrlS5Rm4Tn0saIpusDmuP9WYt iLWUS2EP+8uifvLpnMq3Ks251JFbGZRxCf/Lo6SSn5Xxj2mJO2RUwyusC07H56SC9STf 1Hkiq+hiovSBVhK9c51t2HObUiaZwMNohZjOBiufOaav8IOkvvA4TyTIpplqsW9GN8np 1OPO96iX0mf0VChS0q+phAa/DFxTMjBkSVSAVTbmRU8L1dy/Gi2V9M/TBDu9hhsQplIh q47xqSzisbglFaqCZNLicvnMJf/U8fhWyv87ZCx9QEuvKnUBVg496WCYz27Za2pVUBAb z9eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726132291; x=1726737091; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KDYukj80mIHPYCgHSB2w3O30EP7PG7QCtWy9R/+4O+8=; b=bZxPc11ZtQvM9Z7SDJBXZl7P022+mrOi8/7mymv/8en5kjcRSvAemRIBV5pl6XyjI0 W8tJ1F2ZT5mWKjpOMa4PBbzOHy2t1xdwHB3ZB4mwuxp42TRbiutCg49j4oxVsVL8Q2S0 AQRG/zRIiKlqSRsv9L2vP0E54MBNsmSWj13P7EcDMyy6GZ5JHtHKjr1+ZnsKwvf5ztKp R55SJT+zyBpXffMVoAgtALibdzbh40r4DQKb8i2Fp2Y2btGZMz8MCINKk8dXcoc9nlj7 4hWC6+EJyac/xBg62lwZCsR8sZIKfc3NInXrFGi0S8IvTy4GhscyYGYHPczhE99yBWsl jcFQ== X-Forwarded-Encrypted: i=1; AJvYcCW1Kg5Y0eXv1QGht8W6/4i0vpj2zYCifWjfRKGLJEYlcJQ9x8jn6MPnnaGdaO2R49RoN29rDNZOdINy5ipDA/A5@lists.infradead.org X-Gm-Message-State: AOJu0YxElutjZHecODkb9/qzLds5+Rybm6vXuCwTMm4vvp/7SFPKyqeO KE6vIDK6zCecmFHnbWcaTKVNE5mvpA7GlqKU9+g2+Um9XbOilRDM9r57JZ8+aNk= X-Google-Smtp-Source: AGHT+IFYGstY7Ee7hZURlNK3JZABLF8M1RnLjnl2KXSy/Qm7bwNeqA+fGuOPSyrnOfiIz4Olnre2Gw== X-Received: by 2002:a50:cdd4:0:b0:5c2:1f74:114f with SMTP id 4fb4d7f45d1cf-5c413e54913mr1194735a12.34.1726132289759; Thu, 12 Sep 2024 02:11:29 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c3ebd467desm6239500a12.40.2024.09.12.02.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 02:11:29 -0700 (PDT) Date: Thu, 12 Sep 2024 11:11:28 +0200 From: Andrew Jones To: Sean Christopherson Cc: Marc Zyngier , Oliver Upton , Anup Patel , Paolo Bonzini , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, James Houghton Subject: Re: [PATCH v2 02/13] KVM: selftests: Return a value from vcpu_get_reg() instead of using an out-param Message-ID: <20240912-a3894135370bf3fe551ed018@orel> References: <20240911204158.2034295-1-seanjc@google.com> <20240911204158.2034295-3-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240911204158.2034295-3-seanjc@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240912_021133_019113_B13D536A X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 11, 2024 at 01:41:47PM GMT, Sean Christopherson wrote: > Return a uint64_t from vcpu_get_reg() instead of having the caller provide > a pointer to storage, as none of the KVM_GET_ONE_REG usage in KVM selftests "none of the vcpu_get_reg() usage" (There is KVM_GET_ONE_REG usage accessing larger registers, but those are done through __vcpu_get_reg(). See get-reg-list.c) > accesses a register larger than 64 bits, and vcpu_set_reg() only accepts a > 64-bit value. If a use case comes along that needs to get a register that > is larger than 64 bits, then a utility can be added to assert success and > take a void pointer, but until then, forcing an out param yields ugly code > and prevents feeding the output of vcpu_get_reg() into vcpu_set_reg(). > > Signed-off-by: Sean Christopherson > --- > .../selftests/kvm/aarch64/aarch32_id_regs.c | 10 +-- > .../selftests/kvm/aarch64/debug-exceptions.c | 4 +- > .../selftests/kvm/aarch64/hypercalls.c | 6 +- > .../testing/selftests/kvm/aarch64/psci_test.c | 6 +- > .../selftests/kvm/aarch64/set_id_regs.c | 18 ++--- > .../kvm/aarch64/vpmu_counter_access.c | 19 +++--- > .../testing/selftests/kvm/include/kvm_util.h | 6 +- > .../selftests/kvm/lib/aarch64/processor.c | 8 +-- > .../selftests/kvm/lib/riscv/processor.c | 66 +++++++++---------- > .../testing/selftests/kvm/riscv/arch_timer.c | 2 +- > .../testing/selftests/kvm/riscv/ebreak_test.c | 2 +- > .../selftests/kvm/riscv/sbi_pmu_test.c | 2 +- > tools/testing/selftests/kvm/s390x/resets.c | 2 +- > tools/testing/selftests/kvm/steal_time.c | 3 +- > 14 files changed, 77 insertions(+), 77 deletions(-) > Other than the commit message not being quite right, Reviewed-by: Andrew Jones Thanks, drew