Re: [PATCH] dt-bindings: mailbox: mediatek,gce-mailbox: Stop requiring clock-names

Conor Dooley
2024-09-11T17:52:28Z

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

On Wed, Sep 11, 2024 at 12:43:27PM +0200, AngeloGioacchino Del Regno wrote:
> There is no reason to make specifying the clock-names property
> mandatory, as the Global Command Engine HW needs only one clock.

Have you checked to make sure that there are no users that do the lookup
by name?

>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../bindings/mailbox/mediatek,gce-mailbox.yaml | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> index cef9d7601398..ff5d010fbcf0 100644
> --- a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> @@ -56,17 +56,6 @@ required:
> - interrupts
> - clocks
>
> -allOf:
> - - if:
> - not:
> - properties:
> - compatible:
> - contains:
> - const: mediatek,mt8195-gce
> - then:
> - required:
> - - clock-names
> -
> additionalProperties: false
>
> examples:
> --
> 2.46.0
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]