From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B128CEE645B for ; Thu, 12 Sep 2024 07:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vEXsxJ3iMAnv00bJFJtcBqAdOyYe+2cJ888xCENqObI=; b=pO8iWeinoVIdBJKXnmbkZsyrsw nYWn2gj+cqT5cALE7tVN014Jj6/l49dfsU9bS32bJJ/2A+Mq5GwLoIpq2ntO+M0iAcowyx1dZlmde BVEf5/S5jkyweqFNps5dObvLNQT2AG0p8pmuWyC7922GQ3W+5HJErpOK0R4P0DZCiJyU1EhiY5RqN etZwrAp72txr9sOsUjv7KNwrDBxVAbdjbnJ5+TGtCBDnjJqT2Mxq0e8mEq7Zwk5GEtT4Jb88H1pkr kS8ZaJ148naedNz5fws3Qnq9T4bQvjlav2a1ysbqUpck8xkK1/qVyJ7o2c2dyl4q5eJUjiAyANrQ7 7ThOtrMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soehf-0000000CH46-3U8G; Thu, 12 Sep 2024 07:57:23 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1soefs-0000000CGYI-1PW7; Thu, 12 Sep 2024 07:55:33 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 32B83A43FCD; Thu, 12 Sep 2024 07:55:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BDB5C4CEC3; Thu, 12 Sep 2024 07:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726127730; bh=4s+VuwhVbNSAVesYDsrgOzVFuC3dn4Fh96NjWQHHSd4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RE4Jpos0PNEzX+j4gvv4HnNOrUggjKzwMILkyBwl0ysVmjqAOlVX/mQhrIQNly6u5 D4cMLo65bYBMzWlE/3MbcvaGJgeSBNYdVepAt76I+DLSY7juHCYtKFtFSF+NxXRLnf nw0U9baOT3m36ADEOMsC52DEtH41CuFRaJgFalbX5iXcl4IyQp85V7KiijKjx0cNGT 6KayroEwMI5tGGbabloSBt1YK8gCKXHgprPzBlO8p/mD27xX6IExuLkytas4cCy+Lx FeyB97LCD7R1E9Adejrws3/2lIKYd4KEQJJgQvTdJ/MZTah6JaIHWY/t17UQPpDuJl ey2Ge3BBptu3g== Date: Thu, 12 Sep 2024 08:55:23 +0100 From: Lee Jones To: Krzysztof Kozlowski Cc: Junhao Xie , devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, LKML , Alexandre Belloni , Chukun Pan , Conor Dooley , =?iso-8859-1?Q?G=FCnter_R=F6ck?= , Heiko =?iso-8859-1?Q?St=FCbner?= , Jean Delvare , Krzysztof Kozlowski , Pavel Machek , Rob Herring , Sebastian Reichel , Wim Van Sebroeck Subject: Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU Message-ID: <20240912075523.GB24460@google.com> References: <20240906093630.2428329-2-bigfoot@classfun.cn> <43918eda-c4e8-471a-9de4-ea72bb090803@classfun.cn> <917ac8d8-a483-422c-a408-cdd44793e910@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <917ac8d8-a483-422c-a408-cdd44793e910@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240912_005532_518991_65C82995 X-CRM114-Status: GOOD ( 13.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 08 Sep 2024, Krzysztof Kozlowski wrote: > On 07/09/2024 16:33, Junhao Xie wrote: > > On 2024/9/7 16:44, Markus Elfring wrote: > >> … > >>> +++ b/include/linux/mfd/photonicat-pmu.h > >>> @@ -0,0 +1,86 @@ > >> … > >>> +#ifndef _PHOTONICAT_PMU_H > >>> +#define _PHOTONICAT_PMU_H > >> … > >> > >> I suggest to omit leading underscores from such identifiers. > >> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier > >> > >> Regards, > >> Markus > > > > Thanks for your suggestion, does this look better? > > #ifndef MFD_PHOTONICAT_PMU_H > > #define MFD_PHOTONICAT_PMU_H Yes, this is better. >
> Feel free to ignore all comments from Markus, regardless whether the > suggestion is reasonable or not. This person is banned from LKML and > several maintainers ignore Markus' feedback, because it is just a waste > of time. >
If you really _must_ do this, at least keep it factual. To the best of my knowledge Markus is not banned from LKML. -- Lee Jones [李琼斯]