From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 045A5EE6458 for ; Thu, 12 Sep 2024 07:41:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=t1qAsriH/Z4QnHORwR9qJ4x0AcrM9+PlZp7lcnb19L8=; b=UxTrr/8YZysfrWh9Aze7fbfhSu 7gJ/Hx3jZsUa70DR5bfHewB/n4aPLpUmCJOWXKMGNcR3aso0OQOmrcDctOuOI69yZbblsvq+Fo8Ni tkz4NJptK0C2n+NUbsAs0I4RAC/sF/esR1LjwzSOIxeDWLh4p3DBoKNeZ3wJ8FxmWXuf+n+ApZq// ZMh8mgZdPGxJkyURBnDIXwddjDvc2M0Qd94Y+BDil16ABtcttZUxAXPgyE+gg0XOmCP+atG1a0qlX 1UBSrtsUeb57yzHPJXK/U+/Qzmylqb5QhAhWZebqRY4+jqJU1QyiGufbisEs5YHYSiYK9gqeYLZj+ zgGXGdcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soeS2-0000000CDGH-1B3J; Thu, 12 Sep 2024 07:41:14 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1soeQQ-0000000CCdk-1ste for linux-arm-kernel@lists.infradead.org; Thu, 12 Sep 2024 07:39:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id AE720A43FF4; Thu, 12 Sep 2024 07:39:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C76AC4CED2; Thu, 12 Sep 2024 07:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1726126773; bh=gV3RMZWJnnQir9K3hCqxXCfW964fDFkZOcrcBd9k0Q4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ErX2h4WQz1LUJl504c7zcNhfCsuRhNJPrRLmgsmmKY8pgeUqQ+g/VxvSXmFr6VUJm MMqOnbZpOdmirXhV3mgq1fM9jzl8H/5QAgRFUl17Ph4HeLDA+8u53cNK+lEWRRIkhN wO5FOXcMV8RjS4zf61yY/zXtL+aQi5M2cOUyg64U= Date: Thu, 12 Sep 2024 09:39:30 +0200 From: Greg Kroah-Hartman To: Dirk Behme Cc: Ayush Singh , Ayush Singh , fabien.parent@linaro.org, d-gole@ti.com, lorforlinux@beagleboard.org, jkridner@beagleboard.org, robertcnelson@beagleboard.org, Andrew Davis , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 8/8] addon_boards: mikrobus: Add GPS3 Click Message-ID: <2024091211-bladder-runner-2d75@gregkh> References: <20240911-mikrobus-dt-v1-0-3ded4dc879e7@beagleboard.org> <20240911-mikrobus-dt-v1-8-3ded4dc879e7@beagleboard.org> <2024091149-vocalize-composite-6e48@gregkh> <44039255-159a-4284-abd8-a0f558ad006d@gmail.com> <2024091151-unworldly-dance-9a80@gregkh> <097159c7-1602-4e32-8e6f-9cd023d62238@beagleboard.org> <419bf74e-74cb-46ca-95d0-03b3bab3948d@de.bosch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <419bf74e-74cb-46ca-95d0-03b3bab3948d@de.bosch.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240912_003934_675706_939624AE X-CRM114-Status: GOOD ( 22.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 12, 2024 at 09:29:01AM +0200, Dirk Behme wrote: > On 12.09.2024 09:16, Ayush Singh wrote: > > On 9/12/24 01:34, Greg Kroah-Hartman wrote: > > > > > On Wed, Sep 11, 2024 at 09:26:06PM +0530, Ayush Singh wrote: > > > > On 9/11/24 20:28, Greg Kroah-Hartman wrote: > > > > > > > > > On Wed, Sep 11, 2024 at 07:57:25PM +0530, Ayush Singh wrote: > > > > > > - GPS3 Click is a UART MikroBUS addon Board > > > > > > > > > > > > Link: https://www.mikroe.com/gps-3-click > > > > > > > > > > > > Signed-off-by: Ayush Singh > > > > > > --- > > > > > >    addon_boards/mikrobus/Makefile         |  1 + > > > > > >    addon_boards/mikrobus/mikroe-1714.dtso | 28 > > > > > > ++++++++++++++++++++++++++++ > > > > > Odd top-level directory for the kernel, are you sure this is correct? > > > > > > > > > > thanks, > > > > > > > > > > greg k-h > > > > > > > > > Well, it is kinda a temporary location, since well, I could not > > > > find a good > > > > place for board overlays but a top-level location seems better > > > > than putting > > > > them in any arch specific location. I am open to moving them to a more > > > > suitable location if we have one. > > > top-level location is not ok for something so tiny and "special".  Just > > > put it where all other dtso files go. > > > > > > thanks, > > > > > > greg k-h > > > > > > So here are the directories where dtso files currently go: > > > > ❯ find . -type f -name "*.dtso" -printf "%h\n" | sort -u > > ./arch/arm64/boot/dts/amlogic > > ./arch/arm64/boot/dts/freescale > > ./arch/arm64/boot/dts/mediatek > > ./arch/arm64/boot/dts/qcom > > ./arch/arm64/boot/dts/renesas > > ./arch/arm64/boot/dts/rockchip > > ./arch/arm64/boot/dts/ti > > ./arch/arm64/boot/dts/xilinx > > ./arch/arm/boot/dts/nxp/imx > > ./arch/arm/boot/dts/ti/omap > > ./drivers/clk > > ./drivers/of > > ./drivers/of/unittest-data > > > > > > Out of these, `drivers/of` and `drivers/of/unittest-data` contain > > unittest dtso, so probably not the place. > > > > And the `arch/arm` and `arch/arm64` are for arch specific stuff. > > MikroBUS is supported in RISC-V boards as well (BeagleV-Ahead). So > > probably not the correct location either. > > > > Maybe something like `arch/common/addon_boards` would be better? > > Whats about > > drivers/misc/mikrobus/mikrobus.rs > drivers/misc/mikrobus/mikroe-1714.dtso > drivers/misc/mikrobus/mikroe-5761-i2c.dtso Exactly, put them where the drivers are, like clk and of does. thanks, greg k-h