From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F5A2EEB59F for ; Thu, 12 Sep 2024 12:26:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ODHjczwmeCtfmVBqORyQZ7MlQHUmDpDH1OZg24MEd1k=; b=VFhpUBMYPObTKi8mueuO9mULmF 8LDQeTShc/0berjCtzUcpMbh7WYZ4ZwSzMhd9iU48KNWCHhU7VS071UW/ATZ/4QO9iwcO9dIEc/lT qROwdKNtyaKweD1XoYs0G+6NQj6SlPxgFF+PmyR4ECCC+Z/s+6OB+oTytzRrLLx4YO8kvOOEstxf5 vD/PKyW0UpPEOWrz/FmlVipJoMqXl8nQWBfZsJzlw3BpGs6qSopzvW6GGKCFQ62CCzIA+MN5ML91N V+7q9yCdd5TDUjn1JyLxWa+dBj9h09ipEE1pAsF79wg9xESjdgeZ+d5lbybEuYXa/WILdoluBNaOs viPNWYqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soitn-0000000D1NH-46J3; Thu, 12 Sep 2024 12:26:11 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1soisc-0000000D147-20as for linux-arm-kernel@lists.infradead.org; Thu, 12 Sep 2024 12:24:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1F7455C57F6; Thu, 12 Sep 2024 12:24:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1FB9C4CEC3; Thu, 12 Sep 2024 12:24:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726143897; bh=FRng+cMcwQMKVnWZW9h7CJJYKyq4oEf6Bbu86/1oL1Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qcc23E+AfF8wTibBCKmNZ4QMpEN2nWYM4IehjV7PjXYbetENXL2jpMMfWatGznTrU ohnt5H5hZqf0ONtcZ8iaK+LOkmyi4P3pgfKmuusPXCNEM2a3ZvVMKgq7ZGhuz2KHaU Gt2yjnQgy3tpA+PTslxmxNGwKGtylyhu0jxJIw1zguH2EQdGcBqMe6gn5zJy7JN3ck wkhzTB5FN9WpC6yPeqPE1WyvOK2AATdI2kW+9L6EV+wcHRP4hC4lhLBNOG9EXfdyHG oBQaJ0rXxWOifkoBXNqBJLWaCRE/xJyKrgvdE3+h8DtEPgNbmExtvmzSoPnb/M3a6M lHrFJb1lhZSNw== Date: Thu, 12 Sep 2024 13:24:51 +0100 From: Simon Horman To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , Marek =?utf-8?B?QmVow7pu?= , =?utf-8?B?S8O2cnk=?= Maincent , Oleksij Rempel Subject: Re: [PATCH net-next 3/7] net: phy: lxt: Mark LXT973 PHYs as having a broken isolate mode Message-ID: <20240912122451.GM572255@kernel.org> References: <20240911212713.2178943-1-maxime.chevallier@bootlin.com> <20240911212713.2178943-4-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240911212713.2178943-4-maxime.chevallier@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240912_052458_606045_C053543C X-CRM114-Status: GOOD ( 16.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 11, 2024 at 11:27:07PM +0200, Maxime Chevallier wrote: > Testing showed that PHYs from the LXT973 family have a non-working > isolate mode, where the MII lines aren't set in high-impedance as would > be expected. Prevent isolating these PHYs. > > Signed-off-by: Maxime Chevallier > --- > drivers/net/phy/lxt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/phy/lxt.c b/drivers/net/phy/lxt.c > index e3bf827b7959..55cf67391533 100644 > --- a/drivers/net/phy/lxt.c > +++ b/drivers/net/phy/lxt.c > @@ -334,6 +334,7 @@ static struct phy_driver lxt97x_driver[] = { > .read_status = lxt973a2_read_status, > .suspend = genphy_suspend, > .resume = genphy_resume, > + .flags = PHY_NO_ISOLATE, > }, { > .phy_id = 0x00137a10, > .name = "LXT973", > @@ -344,6 +345,7 @@ static struct phy_driver lxt97x_driver[] = { > .config_aneg = lxt973_config_aneg, > .suspend = genphy_suspend, > .resume = genphy_resume, > + .flags = PHY_NO_ISOLATE, > } }; Hi Maxime, This duplicates setting .flags for each array member updated by this patch. > > module_phy_driver(lxt97x_driver); -- pw-bot: cr