From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44D04EE57F8 for ; Thu, 12 Sep 2024 12:58:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8nPPSSngTJXCHRTKLyRZ30S/cKB+a4H4xJtx4gRKmu8=; b=EnbWr3KpiZHpFiI9IP7BNuBbNs bswjj2Y/1VrbACwFzcJGszb0R30+BW8NY24IDmYnFdZhJ+uojh5MrwXv0luqU3W69ym497BHmrQmI CxyTtweZwoSTrDykr6TG4mCiJ+VtTyJkjBgIXv+8WuZVxxGAVC+NxHHOM1TazLKZX+RE4VebrXlfm boOsQgRsgCO2q5liageFL2QsglsTQq1bQeWmEDgM/HiZ2hwV6DkPeBtDS3U40euyasVwgRLgPP0oE EVXBgrVjjWlxIvHseXMVboA8sxzrqHuazRP0m4vEnzUALXAOFh+cZb0vPKGgXgULDcgrtIrV6SMmp l9gTYk6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sojP7-0000000D7bH-2wlt; Thu, 12 Sep 2024 12:58:33 +0000 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sojNF-0000000D7Fh-26M6 for linux-arm-kernel@lists.infradead.org; Thu, 12 Sep 2024 12:57:06 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 62150E000B; Thu, 12 Sep 2024 12:56:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1726145794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8nPPSSngTJXCHRTKLyRZ30S/cKB+a4H4xJtx4gRKmu8=; b=HV0I+FFk4bpF/eRlPaw6c7+2wnIDgdEFx+tTPRBWWDfWv9qptJHiDnuAZAjZUp7XgAcJ7J aWhKVQzqDWxBkIHch+d6ECNXtOyhAFkzH6AUzXkEMeSU8TCI8Z8Q6lKmVic2g3KqGAjUS/ fRMDz83v33UQmmdC69kyX8ETFf+E+GvgYJStoWYi4O9J4xgLFaC8Y1ulqO7s9+/tqqU65b pcoyebevW+pUxzdSpq3L7mqx8NlqbwWOXOlZhXoGwGXdlAACouik+AVFwTGxJ1NVN/Mj4O maPt6Q1JaM19aEvEYDPHUatQuQ0wLtNIMW5eBUMNhXI5NJVRxdtrjIYvpQVTug== Date: Thu, 12 Sep 2024 14:56:31 +0200 From: Maxime Chevallier To: Simon Horman Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , Marek =?UTF-8?B?QmVow7pu?= , =?UTF-8?B?S8O2cnk=?= Maincent , Oleksij Rempel Subject: Re: [PATCH net-next 3/7] net: phy: lxt: Mark LXT973 PHYs as having a broken isolate mode Message-ID: <20240912145631.74c20406@fedora.home> In-Reply-To: <20240912122451.GM572255@kernel.org> References: <20240911212713.2178943-1-maxime.chevallier@bootlin.com> <20240911212713.2178943-4-maxime.chevallier@bootlin.com> <20240912122451.GM572255@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240912_055638_055787_DDF6E8AD X-CRM114-Status: GOOD ( 18.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Simon, On Thu, 12 Sep 2024 13:24:51 +0100 Simon Horman wrote: > On Wed, Sep 11, 2024 at 11:27:07PM +0200, Maxime Chevallier wrote: > > Testing showed that PHYs from the LXT973 family have a non-working > > isolate mode, where the MII lines aren't set in high-impedance as would > > be expected. Prevent isolating these PHYs. > > > > Signed-off-by: Maxime Chevallier > > --- > > drivers/net/phy/lxt.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/phy/lxt.c b/drivers/net/phy/lxt.c > > index e3bf827b7959..55cf67391533 100644 > > --- a/drivers/net/phy/lxt.c > > +++ b/drivers/net/phy/lxt.c > > @@ -334,6 +334,7 @@ static struct phy_driver lxt97x_driver[] = { > > .read_status = lxt973a2_read_status, > > .suspend = genphy_suspend, > > .resume = genphy_resume, > > + .flags = PHY_NO_ISOLATE, > > }, { > > .phy_id = 0x00137a10, > > .name = "LXT973", > > @@ -344,6 +345,7 @@ static struct phy_driver lxt97x_driver[] = { > > .config_aneg = lxt973_config_aneg, > > .suspend = genphy_suspend, > > .resume = genphy_resume, > > + .flags = PHY_NO_ISOLATE, > > } }; > > Hi Maxime, > > This duplicates setting .flags for each array member > updated by this patch. Arg yes you're correct... Don't know how I missed that... Thanks ! Maxime