From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB492EEEC0B for ; Fri, 13 Sep 2024 03:46:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BkeTpU/pviVeeZfhuF3b1FMXXccRppfuIdmUTtdLMrY=; b=hdjHypgHmz+vb+ZCv6/3ZIJ3zZ rsnIeSmi6qN1C20T+2yLDVuRtayoaABtmtS5sdZQnE1+ogAiwvuOfffbT/bZeGsts5cgwMLwoSsAK /1LNad7LjRSwg1CRnM6XMi+u2D+sDojSQVTkZ14I/Znvh8bvXxOdpND4rCTtziNTLN06UopeLtkF2 5sNxH0d7LC1i8VaQ1Rh8PMB8UY4EUA597/6ZqoRlb/QgXQKpci9PzSQCNl0ufcMXOWwfIv270gf9B TahsemkQHgyxsLz5gTXPvYn3pZk6sxve3W3V5jZt2OajRa+uibIMWu6fHSYKaA8sTozYZj3GCKCcP xlkzKGig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soxFk-0000000EqMI-2pox; Fri, 13 Sep 2024 03:45:48 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1soxEf-0000000Eq5o-3F5l for linux-arm-kernel@lists.infradead.org; Fri, 13 Sep 2024 03:44:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6E26E5C5666; Fri, 13 Sep 2024 03:44:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7829AC4CEC0; Fri, 13 Sep 2024 03:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726199080; bh=14FYnHIpK2VkIZXi1OjsNSbKcix+CkvkwHGueSrvBr4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LQV1m+ieF8kilr4Pc0TdiGeaW/6bp1yTGccJ+bcdgww2EymrUdh2PnmVKWx2PxBZa IK7ga/GcPhGlgnD10gZU63yrymwumSoN+EtgC4UY1V1GiBLN3NYeQQMg0eiMtkdScg 0wx4RH5qZFSgdMNMHr3TJwciaP3CfFDvhP3eJtpHf6/fQ8Rhs9NJVu6EkYLs7zxATK 3Iw+6SvDDhYLnCqgNG68+FXRXeYCcT//W6lpxI6kj3ynYtqXRwGs00HHF9TK8SQOpI C6zSp5lyb8321l9H4WAxJJyJtRYaZaicraOZ2KeCTra4SpL1w7i6NLhtXgJjV3FWPc bd3FcOYxJ6fOg== Date: Thu, 12 Sep 2024 20:44:38 -0700 From: Jakub Kicinski To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Nathan Chancellor , Antoine Tenart , Marc Kleine-Budde , Dan Carpenter , Romain Gantois , syzbot+e9ed4e4368d450c8f9db@syzkaller.appspotmail.com Subject: Re: [PATCH net-next] net: ethtool: phy: Clear the netdev context pointer for DUMP requests Message-ID: <20240912204438.629a3019@kernel.org> In-Reply-To: <20240911134623.1739633-1-maxime.chevallier@bootlin.com> References: <20240911134623.1739633-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240912_204441_892410_6A0E23CC X-CRM114-Status: UNSURE ( 9.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 11 Sep 2024 15:46:21 +0200 Maxime Chevallier wrote: > + /* Clear the context netdev pointer so avoid a netdev_put from > + * the .done() callback > + */ > + ctx->phy_req_info->base.dev = NULL; Why do we assign to req_base.dev in the first place? req is for the parsed request in my mind, and I don't see anything in the PHY dump handlers actually using dev?