From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22037EEEC39 for ; Fri, 13 Sep 2024 07:15:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RSAHK7BmZYU2deQi6bi3uBwOceUpjUsOskzSgu2a7TQ=; b=sfP24zuvhiNM0WwNSqoNKkRo4j skcBlGGLONfyFx8qm4CqZuADt+Yy3s8Jq7O9i56c2HgPO5FIa41MRRZizBe+O4LVVUvoBLjPkAcCO Phm9LARzX2JbM8yXHZBTNFhGJ/RiJb9EyeSqPxt7mYbi6a8UEbMeTCv9zDT6Bxamw5ljH+duj8xYp la2iudYxGlB++zlcF3GUtpMMK+6jgi3I1x+AMlKbyTDXXLyKs9JhBEURhumX+LRsZ+5uuv60WYbft DUMI0N+MrbWYJTl4C/HvmlkqBHDdP05hTtjjvRbnebaXV2mX/fVdegKjtl07gTZ+ZeLJ06FrvT8yF 6foPXBPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sp0WX-0000000F7yr-0DVB; Fri, 13 Sep 2024 07:15:21 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sp0VS-0000000F7rq-04fI for linux-arm-kernel@lists.infradead.org; Fri, 13 Sep 2024 07:14:16 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 6FA651C0005; Fri, 13 Sep 2024 07:14:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1726211649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RSAHK7BmZYU2deQi6bi3uBwOceUpjUsOskzSgu2a7TQ=; b=Eo9+JBNHpHFCOcLulM6Tf+tOj/4Vo7FvtPMYomLp8P0wBht4b36JYpVpGCZIFMsx5JSUkr 2u56RLgv703SygEBuKsktPruXY1b7tvE/nIE4tNkxNCoSHYiYN7wupyz19xQn+m7gNmaTg x9lbSYOYp5m7yLAuR70q4JE6imprmHCaZG4jw7d/F3nBMFy5MQG50PBmUrZlL6vsGfWuOE qNdn8AQ6+nL7wxNrYKq7wfjOKU5/nzRPsBoNlYkf6/bfZ+pZY8IMX++MfApVGMyfkFsB8u 1gQwudHlEW/t0AnxDkJZpGjB6OFfXsYntIP7vOD5w/EZQjAZu++B6kJt3xOzXw== Date: Fri, 13 Sep 2024 09:14:04 +0200 From: Maxime Chevallier To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Nathan Chancellor , Antoine Tenart , Marc Kleine-Budde , Dan Carpenter , Romain Gantois , syzbot+e9ed4e4368d450c8f9db@syzkaller.appspotmail.com Subject: Re: [PATCH net-next] net: ethtool: phy: Clear the netdev context pointer for DUMP requests Message-ID: <20240913091404.3d4a9d19@fedora.home> In-Reply-To: <20240912204438.629a3019@kernel.org> References: <20240911134623.1739633-1-maxime.chevallier@bootlin.com> <20240912204438.629a3019@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240913_001414_705193_AD3A4BC0 X-CRM114-Status: GOOD ( 11.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Jakub, On Thu, 12 Sep 2024 20:44:38 -0700 Jakub Kicinski wrote: > On Wed, 11 Sep 2024 15:46:21 +0200 Maxime Chevallier wrote: > > + /* Clear the context netdev pointer so avoid a netdev_put from > > + * the .done() callback > > + */ > > + ctx->phy_req_info->base.dev = NULL; > > Why do we assign to req_base.dev in the first place? > req is for the parsed request in my mind, and I don't > see anything in the PHY dump handlers actually using dev? After reading the code back, that's true. It's just a leftover from when I hadn't considered that dumps could be interrupted/resumed. Let me clean that up then. Thanks for the review Jakub, Maxime