From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12C20FC6176 for ; Sat, 14 Sep 2024 22:24:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MQz2J9wxzx19kd2IR3yA1F+FTH0htjgS/ynNpd24Edo=; b=zb/Pk6vl+FC/WL1KGaeiJOOMly fY0MlZlX1z22O7P7sayq6lAlkcDU7pdDTOUg6L+TNxxZj0YU0kqedVn/S4/ApIIjvrpOj3/dJ6JfR e+Z2AjwxH7GXagnpiMLo+w+jiI1zMV+5bsu7X4ullLyUC19ubgqUIpfJQl3jWbLMgGI94S9YvS+fM YRk1AZBrcSf2rayno7ouTCoYBSAFA/rAqv5wUVLfmZiNWXlejyXc2eG/BuYhxX/q0LIQzgX7lYWCN Soki5v135/LICJvPpLw2NO2JltPaR5isv5EYw25ShuBmoiw5iHvB2mXFJt5ej0hY+ToQfFk8d+3SZ AF5s96Zw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1spbBg-00000001K89-0F2u; Sat, 14 Sep 2024 22:24:16 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1spbAa-00000001K31-44fW for linux-arm-kernel@lists.infradead.org; Sat, 14 Sep 2024 22:23:10 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6C1CA5C5587; Sat, 14 Sep 2024 22:23:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E3A3C4CEC0; Sat, 14 Sep 2024 22:23:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726352586; bh=6f4sJYGh10WHP6XIIiyMztxdnYvZzcortC5SK3D2qz8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sHxgIOuQx4qk2R9Sbd+XDWF/uz80nTlxayfdXhfmsK3wS5bEZKtYlOvjlTl22pcJh ESDVwL1+wHcr3iKbSD5TN6xtMp/yVd3ou7sST4areIk3F12j7JxsqkW8PVM3wlIWV2 rc33vBeRhx/cpcT64h52+X2ckq8A8hn8fxFfeaqoc4yfYbZPV5wFHt+YiPcGK1AHV6 SlQDhhZuKJE3PVcADFoi/g7jP8L1BB5Sh5e6WqxaHiE57kq/zbTi0UF9DAAdrenb8+ AMQ/+Y2NTUql924V+tS61XjzRKFq5veOAPhf7UqlWccIPI70aDligyRdZrRK0EPeI+ fSHg3eZdN2I7Q== Date: Sat, 14 Sep 2024 23:23:00 +0100 From: Conor Dooley To: Nick Chan Cc: Hector Martin , Sven Peter , Alyssa Rosenzweig , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Rafael J . Wysocki" , Viresh Kumar , Linus Walleij , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Mark Kettenis , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, Ivaylo Ivanov , Konrad Dybcio Subject: Re: [PATCH v2 03/22] dt-bindings: cpufreq: apple,cluster-cpufreq: Add A10 compatible Message-ID: <20240914-jiffy-scheming-356866ebc316@spud> References: <20240914052413.68177-1-towinchenmi@gmail.com> <20240914052413.68177-6-towinchenmi@gmail.com> <2ebf5258-b55d-4010-aa94-d5bab1f93bb5@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ki+UkIw/U+rQPBsd" Content-Disposition: inline In-Reply-To: <2ebf5258-b55d-4010-aa94-d5bab1f93bb5@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240914_152309_171939_951B4660 X-CRM114-Status: GOOD ( 24.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --Ki+UkIw/U+rQPBsd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 15, 2024 at 01:17:57AM +0800, Nick Chan wrote: >=20 >=20 > On 14/9/2024 13:17, Nick Chan wrote: > > The block found on the Apple A10 SoC is compatible with the > > existing driver so just add its per-SoC compatible. > >=20 > > Signed-off-by: Nick Chan > > --- > > .../devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/cpufreq/apple,cluster-cp= ufreq.yaml b/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufre= q.yaml > > index 76cb9726660e..e0d1a9813696 100644 > > --- a/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.y= aml > > +++ b/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.y= aml > > @@ -24,7 +24,9 @@ properties: > > - apple,t8112-cluster-cpufreq > > - const: apple,cluster-cpufreq > > - items: > > - - const: apple,t6000-cluster-cpufreq > > + - enum: > > + - apple,t8010-cluster-cpufreq > > + - apple,t6000-cluster-cpufreq > > - const: apple,t8103-cluster-cpufreq > > - const: apple,cluster-cpufreq > > =20 >=20 > Have to retract the cpufreq patches, a v3 without them will be available > tomorrow. cpufreq works on iPad 7 (A10). However it is already pretty > weird when the cpufreq did not work on Apple TV 4K (A10X), with adjusted > p-states. However, it seems that iPhone 7 (A10) is also not working. So > this is definitely broken. As far as the hardware interfaces go they shou= ld > be compatible, so the only explanation that makes sense is that the behav= ior > is not correct on t8010 and t8011 and it only *happened* to work on iPad = 7, > with some incorrect behaviors. >=20 > Marked as deferred on patchwork. When you send the v3, make sure you pick up the acks I already gave you. I didn't check all the patches on this version, but I think you forgot to add some. Thanks, Conor. --Ki+UkIw/U+rQPBsd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZuYMwwAKCRB4tDGHoIJi 0nrkAQC2FOhcj45xEZCSUn6OVcREvB72MdKx61HqWuqQJGOMWAD/XyehiQe31kxj nK74z7sVmXbM5Wh7UgZSbbwg5cj6CQA= =ruKL -----END PGP SIGNATURE----- --Ki+UkIw/U+rQPBsd--