From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3AC84C02183 for ; Sat, 14 Sep 2024 08:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W6ys5e7/oid6UcW+Wu7+F5C9RlJ27QfEyrA9stB2DZw=; b=w8YJUnfPIaq2A8PMwVHVW4VJXf lua+ds/zwwRH7usCO5IWoOP6UWj+P1RDBP185iIHbUCLvNTQNw2cCu6iA5qe8wELV5LCEFgCgzbOZ 2hFSlf1SxpXt6ncGp6UxPGjMlboNQ53utFf8rbQSA3aCM/lnEFeprmtaZGxJAGmvV9qkH8TjKM0QB KKFbEVzcQyemb4FPXiDuifttLfJCdk/w7O0maY3KwYXCL/sWompyjprcAZ/seztWv+bJnqT/QLmBy VN6W1Feq4uUAmCw8ybsrghn6scQkIfl+YbD4U3OiTbwl+D3X8wYgSCRN1wQbZkrY6mhpaQHoOjPug xxHemECA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1spOJi-00000000NUg-2Tzd; Sat, 14 Sep 2024 08:39:42 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1spOIc-00000000NIe-3rR8 for linux-arm-kernel@lists.infradead.org; Sat, 14 Sep 2024 08:38:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3365C5C0FFB; Sat, 14 Sep 2024 08:38:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72665C4CEC0; Sat, 14 Sep 2024 08:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726303113; bh=PKtoMpXxtMNQgMD2WWGoiAlbw1hPMweydHUrcUGVJZE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pm2w91O18pRTdtAcxA5uCMQMvGqPsnuL+ALkfiPQuz8oE3qESOGi9ZD/V0hUapLnp wSO4FFCylWMqc6gVtBIcz2zlBH2704dC1xZINogm8mLpt75+LwU/TYJ4rfIbnepC2T o5Q8uFOUWLGcXmkOK0tYCVnXakHoi/DDsdN51G8dbHoJ9DWCthyv6tH6fu3IGVFJbJ vUjLCxMGTBQvAkJi/vteaZwAMmdbQry0thmV3Nz19gNgNvEqoKWTuu/jZ5BLaVit47 5FTv4bbK4eAUhBQohtpd/YdZ3btToTXDfk+gYuC1CnrDJuzrAGv6GO1nKD1H8zAHGi Vrkdgz/w8Jm4Q== Date: Sat, 14 Sep 2024 09:38:28 +0100 From: Simon Horman To: Aakash Menon Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, daniel.machon@microchip.com, UNGLinuxDriver@microchip.com, aakash.menon@protempis.com, horatiu.vultur@microchip.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: sparx5: Fix invalid timestamps Message-ID: <20240914083828.GC8319@kernel.org> References: <20240913193357.21899-1-aakash.menon@protempis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240913193357.21899-1-aakash.menon@protempis.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240914_013835_031323_E92D377D X-CRM114-Status: GOOD ( 13.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 13, 2024 at 12:33:57PM -0700, Aakash Menon wrote: > Bit 270-271 are occasionally unexpectedly set by the hardware. > > This issue was observed with 10G SFPs causing huge time errors (> 30ms) in PTP. > > Only 30 bits are needed for the nanosecond part of the timestamp, clear 2 most significant bits before extracting timestamp from the internal frame header. Hi Aakash, Thanks for your patch. I'll leave the review of the code change itself to others, but here is some feedback on process. Please line-wrap patch descriptions at 75 columns wide. Link: https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format Assuming this is a bug fix, a Fixes tag should be present. It should go just before the signed-off-by line (or other tags), with no blank lines in between. I'm wondering if this Fixes tag is appropriate: Fixes: 70dfe25cd866 ("net: sparx5: Update extraction/injection for timestamping") > Signed-off-by: Aakash Menon Also, for reference, fixes for Networking should, in general, be targeted at the net tree. Subject: [PATCH net] ... And lastly, if you do post a new patch, be sure to wait 24h since the original patch posting before doing so. Link: https://docs.kernel.org/process/maintainer-netdev.html ...